GNU bug report logs - #49310
website: Redesign video pages

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#49310: closed (website: Redesign video pages)
Date: Sun, 04 Jul 2021 09:41:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 4 Jul 2021 11:40:17 +0200
with message-id <20210704094017.q3wyftip2svgq2ls <at> pelzflorian.localdomain>
and subject line Re: [bug#49310] website: Redesign video pages
has caused the debbugs.gnu.org bug report #49310,
regarding website: Redesign video pages
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
49310: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=49310
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Luis Felipe via Guix-patches <guix-patches <at> gnu.org>
Subject: website: Redesign video pages
Date: Thu, 01 Jul 2021 00:05:45 +0000

[Message part 3 (text/plain, inline)]

Hi,

The attached patch introduces a new design for video pages.

Some things I wanted to add but couldn't:

+ Sort videos/playlists in reverse chronological order.
+ Display only instructional videos in the home page.

Currently, the videos are displayed in reverse chronological order, but by reversing the list of videos and playlists, not checking their dates. The home page does show instructional videos but just because they happen to be the most recent videos.

The reason why I couldn't add these things is that while writing a "videos/reverse-chronological" and "videos/get-video" procedures, I found it very difficult to make them handle both Video records and Playlist records. I thought that redefining both the Video type and the Playlist type as GOOPS classes would make things easier, but then I ran out of time to do that.

So I'm providing this patch as is hoping that it will be usable. At least the user facing part should be OK. And maybe the missing parts can be added later?

Anywho, here it goes...

---
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/

[0001-website-Redesign-video-pages.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 49310-done <at> debbugs.gnu.org
Subject: Re: [bug#49310] website: Redesign video pages
Date: Sun, 4 Jul 2021 11:40:17 +0200

Thanks for the new patch.  Pushed as
7f6ce6dbdef42f6eab53588ebaa7d6f402733ccc.

On Sat, Jul 03, 2021 at 05:01:28PM +0000, Luis Felipe wrote:
> On Saturday, July 3rd, 2021 at 10:08 AM, pelzflorian (Florian Pelz) <pelzflorian <at> pelzflorian.de> wrote:
> > Shall I push your commit and afterwards redirect the old video URLs in
> >
> > maintenance.git?
> 
> Maybe better to redirect to /en/videos/?

I will send a separate patch for the redirects.

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.