GNU bug report logs - #49310
website: Redesign video pages

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 49310 in the body.
You can then email your comments to 49310 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Luis Felipe via Guix-patches <guix-patches <at> gnu.org>
Subject: website: Redesign video pages
Date: Thu, 01 Jul 2021 00:05:45 +0000

[Message part 1 (text/plain, inline)]

Hi,

The attached patch introduces a new design for video pages.

Some things I wanted to add but couldn't:

+ Sort videos/playlists in reverse chronological order.
+ Display only instructional videos in the home page.

Currently, the videos are displayed in reverse chronological order, but by reversing the list of videos and playlists, not checking their dates. The home page does show instructional videos but just because they happen to be the most recent videos.

The reason why I couldn't add these things is that while writing a "videos/reverse-chronological" and "videos/get-video" procedures, I found it very difficult to make them handle both Video records and Playlist records. I thought that redefining both the Video type and the Playlist type as GOOPS classes would make things easier, but then I ran out of time to do that.

So I'm providing this patch as is hoping that it will be usable. At least the user facing part should be OK. And maybe the missing parts can be added later?

Anywho, here it goes...

---
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/

[0001-website-Redesign-video-pages.patch (text/x-patch, attachment)]

Message #8 received at 49310 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 49310 <at> debbugs.gnu.org
Subject: Re: [bug#49310] website: Redesign video pages
Date: Sat, 3 Jul 2021 12:08:59 +0200

Hi Luis / sirgazil,

On Thu, Jul 01, 2021 at 12:05:45AM +0000, Luis Felipe via Guix-patches via wrote:
> Hi,
> 
> The attached patch introduces a new design for video pages.

Thank you!  Much nicer than before, both in looks and code-wise and
also documentation-wise.  This was much effort.

Shall I push your commit and afterwards redirect the old video URLs in
maintenance.git?

> + Sort videos/playlists in reverse chronological order.
> […]
> Currently, the videos are displayed in reverse chronological order,
> but by reversing the list of videos and playlists, not checking
> their dates. The home page does show instructional videos but just
> because they happen to be the most recent videos.

I don’t know the plan for further videos and if forcing reverse
chronological order will be useful someday.




> New miniature and poster images for videos:
> 
> * website/static/media/videos/2018/seagl-everyday-use-of-guix.mini.webp
> * website/static/media/videos/2018/seagl-everyday-use-of-guix.webp
> […]

Yes, switching from .png to .webp seems appropriate, even if it is
unsupported on old still-supported macOS versions or ReactOS or such
things, because they cannot playback the .webm videos anyway, I think.


> diff --git a/website/apps/media/builder.scm b/website/apps/media/builder.scm
> index c270db5..b85dfd1 100644
> --- a/website/apps/media/builder.scm
> +++ b/website/apps/media/builder.scm
> @@ -5,6 +5,7 @@
>  
>  (define-module (apps media builder)
>    #:use-module (apps aux system)
> +  #:use-module (apps base utils)
>    #:use-module (apps media data)
>    #:use-module (apps media templates publication-list)
>    #:use-module (apps media templates screenshot)
> @@ -19,6 +20,7 @@
>    #:use-module (apps aux web)
>    #:use-module (apps media utils)
>    #:use-module (srfi srfi-1)
> +  #:use-module (srfi srfi-19)
>    #:export (builder))

“#:use-module (srfi srfi-1)“ can be removed.



> Modified files:
> 
> […]
> * website/apps/media/data.scm (videos): New list of videos plus
> playlists.
> (playlist): Remove in favor of the new videos list.

s/(playlist)/(playlists)/



> * website/apps/media/templates/components.scm: […]
> (video->shtml, video-content): Removed. Not necessary in the new design. […]
> * website/apps/media/types.scm […](<video>): […] Change description type
> to string to fit the new design.

OK.  If SHTML is needed someday it can be re-added.


LGTM!  Thank you again.

Regards,
Florian

Message #11 received at 49310 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: 49310 <at> debbugs.gnu.org
Subject: Re: [bug#49310] website: Redesign video pages
Date: Sat, 03 Jul 2021 17:01:28 +0000

[Message part 1 (text/plain, inline)]

Hi Florian,

On Saturday, July 3rd, 2021 at 10:08 AM, pelzflorian (Florian Pelz) <pelzflorian <at> pelzflorian.de> wrote:

> Thank you! Much nicer than before, both in looks and code-wise and
>
> also documentation-wise. This was much effort.

Phew, glad to hear that!


> Shall I push your commit and afterwards redirect the old video URLs in
>
> maintenance.git?

Maybe better to redirect to /en/videos/?


> I don’t know the plan for further videos and if forcing reverse
>
> chronological order will be useful someday.

Well, yeah, I'm not sure whether it will be useful either.

I think the idea is to add a selection of videos from the community, as proposed by Julien in https://issues.guix.gnu.org/43871. So the list could grow enough to justify a reverse chronological order, like in the blog.


> > New miniature and poster images for videos:
> >
> > -   website/static/media/videos/2018/seagl-everyday-use-of-guix.mini.webp
> > -   website/static/media/videos/2018/seagl-everyday-use-of-guix.webp
> >
> >     […]
>
> Yes, switching from .png to .webp seems appropriate, even if it is
>
> unsupported on old still-supported macOS versions or ReactOS or such
>
> things, because they cannot playback the .webm videos anyway, I think.

I'd say let's use webp and webm, and if we get complaints, we see how to solve any issues (at least for images; with videos is harder because of storage resources).


> > diff --git a/website/apps/media/builder.scm b/website/apps/media/builder.scm
>
> “#:use-module (srfi srfi-1)“ can be removed.

Removed in the new patch attached.


> > Modified files:
> >
> > -   website/apps/media/data.scm (videos): New list of videos plus
> >
> >     playlists.
> >
> >     (playlist): Remove in favor of the new videos list.
>
> s/(playlist)/(playlists)/

Corrected in the new patch.

Thanks for the review, Florian.

[0001-website-Redesign-video-pages.patch (text/x-patch, attachment)]

Message #16 received at 49310-done <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 49310-done <at> debbugs.gnu.org
Subject: Re: [bug#49310] website: Redesign video pages
Date: Sun, 4 Jul 2021 11:40:17 +0200

Thanks for the new patch.  Pushed as
7f6ce6dbdef42f6eab53588ebaa7d6f402733ccc.

On Sat, Jul 03, 2021 at 05:01:28PM +0000, Luis Felipe wrote:
> On Saturday, July 3rd, 2021 at 10:08 AM, pelzflorian (Florian Pelz) <pelzflorian <at> pelzflorian.de> wrote:
> > Shall I push your commit and afterwards redirect the old video URLs in
> >
> > maintenance.git?
> 
> Maybe better to redirect to /en/videos/?

I will send a separate patch for the redirects.

Regards,
Florian

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.