GNU bug report logs - #4843
creating menus

Previous Next

Package: emacs;

Reported by: Daniel Carvalho <idnael <at> gmail.com>

Date: Sat, 31 Oct 2009 22:35:04 UTC

Severity: important

Tags: patch

Merged with 4122, 4125, 4134, 4866, 4884, 4916, 5353, 5930

Found in version 23.1

Done: Jan Djärv <jan.h.d <at> swipnet.se>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4843 in the body.
You can then email your comments to 4843 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Sat, 31 Oct 2009 22:35:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Daniel Carvalho <idnael <at> gmail.com>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Sat, 31 Oct 2009 22:35:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Daniel Carvalho <idnael <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: creating menus
Date: Sat, 31 Oct 2009 22:29:52 +0000
hi
when I recently upgraded to Ubuntu 9.10 the elisp code to create menus
stop working.

Consider example in http://xahlee.org/emacs/elisp_menu.html
It creates the menu "MyMenu", but the menu itens inside it don't show!

The emacs version didn't change: GNU Emacs 22.2.1

Anyone else had this problem? how to solve it?



;; Creating a new menu pane in the menu bar to the right of “Tools” menu
(define-key-after
  global-map
  [menu-bar mymenu]
  (cons "MyMenu" (make-sparse-keymap "hoot hoot"))
  'tools )

;; Creating a menu item, under the menu by the id “[menu-bar mymenu]”
(define-key
  global-map
  [menu-bar mymenu nl]
  '("Next Line" . next-line))

;; creating another menu item
(define-key
  global-map
  [menu-bar mymenu pl]
  '("Previous Line" . previous-line))

;; code to remove the whole menu panel
;; (global-unset-key [menu-bar mymenu])




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Sun, 01 Nov 2009 12:55:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jan Djärv <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Sun, 01 Nov 2009 12:55:04 GMT) Full text and rfc822 format available.

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Daniel Carvalho <idnael <at> gmail.com>, 4843 <at> debbugs.gnu.org
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4843: creating menus
Date: Sun, 01 Nov 2009 13:45:17 +0100
Daniel Carvalho skrev:
> hi
> when I recently upgraded to Ubuntu 9.10 the elisp code to create menus
> stop working.
> 
> Consider example in http://xahlee.org/emacs/elisp_menu.html
> It creates the menu "MyMenu", but the menu itens inside it don't show!
> 
> The emacs version didn't change: GNU Emacs 22.2.1
> 
> Anyone else had this problem? how to solve it?

It can be because you are now using a newer Gtk+ version.  Please use 
report-emacs-bug so we can see that at once instead of having to ask.

If indeed you are using Gtk+, it is due to the introduction of native windows.
To see if this is the case, start emacs with
% GDK_NATIVE_WINDOWS=1 emacs
and try again.

	Jan D.





Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Sun, 01 Nov 2009 12:55:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jan Djärv <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Sun, 01 Nov 2009 12:55:06 GMT) Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Sun, 01 Nov 2009 13:05:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Daniel Carvalho <idnael <at> gmail.com>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Sun, 01 Nov 2009 13:05:05 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Daniel Carvalho <idnael <at> gmail.com>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 4843 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#4843: creating menus
Date: Sun, 1 Nov 2009 12:58:37 +0000
2009/11/1 Jan Djärv <jan.h.d <at> swipnet.se>:
> Daniel Carvalho skrev:
>>
>> hi
>> when I recently upgraded to Ubuntu 9.10 the elisp code to create menus
>> stop working.
>>
>> Consider example in http://xahlee.org/emacs/elisp_menu.html
>> It creates the menu "MyMenu", but the menu itens inside it don't show!
>>
>> The emacs version didn't change: GNU Emacs 22.2.1
>>
>> Anyone else had this problem? how to solve it?
>
> It can be because you are now using a newer Gtk+ version.  Please use
> report-emacs-bug so we can see that at once instead of having to ask.
>

Please see full report (without setting GDK_NATIVE_WINDOWS=1) at end of message

> If indeed you are using Gtk+, it is due to the introduction of native
> windows.
> To see if this is the case, start emacs with
> % GDK_NATIVE_WINDOWS=1 emacs
> and try again.
>

If I do it that way, the problem is solved!
thanks


--

To: bug-gnu-emacs <at> gnu.org
Subject: creating menus
--text follows this line--

Please write in English if possible, because the Emacs maintainers
usually do not have translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs <at> gnu.org mailing list,
and to the gnu.emacs.bug news group.

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:



If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
If you would like to further debug the crash, please read the file
/usr/share/emacs/22.2/etc/DEBUG for instructions.


In GNU Emacs 22.2.1 (i486-pc-linux-gnu, GTK+ Version 2.18.2)
 of 2009-10-15 on rothera, modified by Ubuntu
Windowing system distributor `The X.Org Foundation', version 11.0.10604000
configured using `configure  '--build=i486-linux-gnu'
'--host=i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib'
'--libexecdir=/usr/lib' '--localstatedir=/var'
'--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes'
'--enable-locallisppath=/etc/emacs22:/etc/emacs:/usr/local/share/emacs/22.2/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/22.2/site-lisp:/usr/share/emacs/site-lisp:/usr/share/emacs/22.2/leim'
'--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu'
'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN
-DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed'
'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: pt_PT.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  show-paren-mode: t
  delete-selection-mode: t
  pc-selection-mode: t
  auto-image-file-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x r e p o t <backspace> r t - e m a c a <tab> <backspace>
<tab> <return>

Recent messages:
Loading delsel...done
Loading paren...done
Loading saveplace...done
Loading /home/daniel/comp/elisp/system-type--gnu-linux.el (source)...done
fim ponto_emacs
Loading /home/daniel/comp/elisp/ponto_emacs.el (source)...done
Loading places from /home/daniel/.emacs-places...done
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading emacsbug...done
call-interactively: End of buffer




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Sun, 01 Nov 2009 13:05:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to Daniel Carvalho <idnael <at> gmail.com>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Sun, 01 Nov 2009 13:05:07 GMT) Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Mon, 02 Nov 2009 01:50:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Chong Yidong <cyd <at> stupidchicken.com>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Mon, 02 Nov 2009 01:50:07 GMT) Full text and rfc822 format available.

Message #30 received at 4843 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 4843 <at> debbugs.gnu.org
Subject: Re: bug#4843: creating menus
Date: Sun, 01 Nov 2009 20:44:23 -0500
> It can be because you are now using a newer Gtk+ version.  Please use
> report-emacs-bug so we can see that at once instead of having to ask.
>
> If indeed you are using Gtk+, it is due to the introduction of native windows.
> To see if this is the case, start emacs with
> % GDK_NATIVE_WINDOWS=1 emacs
> and try again.

I don't have any recollection of this problem.  Could you elaborate?  If
the menus don't work properly unless GDK_NATIVE_WINDOWS=1, maybe we
should set it unconditionally.



Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Mon, 02 Nov 2009 08:15:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Jan D." <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Mon, 02 Nov 2009 08:15:05 GMT) Full text and rfc822 format available.

Message #35 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Jan D." <jan.h.d <at> swipnet.se>
To: Daniel Carvalho <idnael <at> gmail.com>
Cc: 4843 <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org,
        4843-done <at> debbugs.gnu.org
Subject: Re: bug#4843: creating menus
Date: Mon, 02 Nov 2009 09:08:02 +0100
On 2009-11-01 13:58, Daniel Carvalho wrote:
> 2009/11/1 Jan Djärv<jan.h.d <at> swipnet.se>:

>> If indeed you are using Gtk+, it is due to the introduction of native
>> windows.
>> To see if this is the case, start emacs with
>> % GDK_NATIVE_WINDOWS=1 emacs
>> and try again.
>>
>
> If I do it that way, the problem is solved!
> thanks

Closing this report as I don't think there will be a new release in the 
22 branch.  The 23 branch have a fix for this, and the next released 23 
will handle this fine.

For Emacs 22, the workaround is to set GDK_NATIVE_WINDOWS=1 in the 
environment.

	Jan D.




Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Mon, 02 Nov 2009 08:15:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Jan D." <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Mon, 02 Nov 2009 08:15:07 GMT) Full text and rfc822 format available.

Reply sent to "Jan D." <jan.h.d <at> swipnet.se>:
You have taken responsibility. (Mon, 02 Nov 2009 08:15:09 GMT) Full text and rfc822 format available.

Notification sent to Daniel Carvalho <idnael <at> gmail.com>:
bug acknowledged by developer. (Mon, 02 Nov 2009 08:15:10 GMT) Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Mon, 02 Nov 2009 08:30:03 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Jan D." <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Mon, 02 Nov 2009 08:30:03 GMT) Full text and rfc822 format available.

Message #50 received at 4843 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Jan D." <jan.h.d <at> swipnet.se>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 4843 <at> debbugs.gnu.org
Subject: Re: bug#4843: creating menus
Date: Mon, 02 Nov 2009 09:20:18 +0100
On 2009-11-02 02:44, Chong Yidong wrote:
>> It can be because you are now using a newer Gtk+ version.  Please use
>> report-emacs-bug so we can see that at once instead of having to ask.
>>
>> If indeed you are using Gtk+, it is due to the introduction of native windows.
>> To see if this is the case, start emacs with
>> % GDK_NATIVE_WINDOWS=1 emacs
>> and try again.
>
> I don't have any recollection of this problem.  Could you elaborate?  If
> the menus don't work properly unless GDK_NATIVE_WINDOWS=1, maybe we
> should set it unconditionally.

Native windows is Gtk having internal windows that map to the same X 
window.  This confuses Emacs, mostly when it tries to map X events for 
windows to frames.  I.e. there might not be separate X windows in the 
menu that is children to the frame X window.  See bug #4122.

I'd rather not set GDK_NATIVE_WINDOWS as it disables the optimizations 
that native windows give.  It may also be removed in a future Gtk+ 
release, so it isn't a good solution.

It isn't hard to fix emacs 22 as well, but does this bug warrant a new 
22 release?  Maybe, as distributions like Ubuntu still ships 22 (see the 
linked Ubuntu bug in #4122).  A 23-release soonish is not wrong though :-)

	Jan D.




Forcibly Merged 4122 4125 4134 4843 4866. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Thu, 05 Nov 2009 18:40:05 GMT) Full text and rfc822 format available.

Forcibly Merged 4122 4125 4134 4843 4866 4884. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Mon, 09 Nov 2009 08:50:17 GMT) Full text and rfc822 format available.

Forcibly Merged 4122 4125 4134 4843 4866 4884 4916. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> emacsbugs.donarmstrong.com. (Fri, 13 Nov 2009 20:55:14 GMT) Full text and rfc822 format available.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Wed, 09 Dec 2009 08:20:04 GMT) Full text and rfc822 format available.

Acknowledgement sent to Felix Homann <fexpop <at> onlinehome.de>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Wed, 09 Dec 2009 08:20:05 GMT) Full text and rfc822 format available.

Message #61 received at 4843 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Felix Homann <fexpop <at> onlinehome.de>
To: 4843 <at> debbugs.gnu.org
Subject: Is it supposed to be fixed?
Date: Wed, 09 Dec 2009 09:13:58 +0100
Hi,

this bug has been closed over a month ago whith an indication of a 
supposed fix in emacs23.
Since it is not mentioned in which version of emacs23 it is supposed to 
be fixed I would like to ask when a fix can be expected.

If the current emacs23-gtk (23.1+1-2) is supposed to fix this issue I 
would like to inform you that it doesn't. There are still several empty 
menus (e.g. AucTex Menus) without GDK_NATIVE_WINDOWS=1.

Kind regards,

Felix



Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#4843; Package emacs. (Wed, 09 Dec 2009 09:50:07 GMT) Full text and rfc822 format available.

Acknowledgement sent to "Jan D." <jan.h.d <at> swipnet.se>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Wed, 09 Dec 2009 09:50:07 GMT) Full text and rfc822 format available.

Message #66 received at 4843 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: "Jan D." <jan.h.d <at> swipnet.se>
To: Felix Homann <fexpop <at> onlinehome.de>, 4843 <at> debbugs.gnu.org
Subject: Re: bug#4843: Is it supposed to be fixed?
Date: Wed, 09 Dec 2009 10:47:22 +0100
On 2009-12-09 09:13, Felix Homann wrote:
> Hi,
>
> this bug has been closed over a month ago whith an indication of a
> supposed fix in emacs23.
> Since it is not mentioned in which version of emacs23 it is supposed to
> be fixed I would like to ask when a fix can be expected.
>
> If the current emacs23-gtk (23.1+1-2) is supposed to fix this issue I
> would like to inform you that it doesn't. There are still several empty
> menus (e.g. AucTex Menus) without GDK_NATIVE_WINDOWS=1.
>
> Kind regards,
>

Fixed means it is fixed in Emacs CVS HEAD unless something else is said. 
 The next release will be Emacs 23.2.  Pretest for that is starting 
right about now.  A release is months away (2-3 probably).  I don't know 
what you are running, but it looks like some sort of 23.1.  23.1+1-2 is 
not an Emacs version number, I guess it something from some package 
system.  A fix for 23.1 will not be released.  You can request that 
whatever you are running backports the fix to their version of 23.1.

	Jan D.




Forcibly Merged 4122 4125 4134 4843 4866 4884 4916 5353. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 12 Jan 2010 18:33:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <bug-gnu-emacs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 10 Feb 2010 12:24:03 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 12 Apr 2010 00:45:03 GMT) Full text and rfc822 format available.

Forcibly Merged 4122 4125 4134 4843 4866 4884 4916 5353 5930. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 12 Apr 2010 00:45:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 10 May 2010 11:24:03 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 28 Jun 2010 17:43:02 GMT) Full text and rfc822 format available.

Forcibly Merged 4122 4125 4134 4843 4866 4884 4916 5353 5930 6499. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Mon, 28 Jun 2010 17:43:02 GMT) Full text and rfc822 format available.

Did not alter fixed versions and reopened. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 16 Jul 2010 10:51:02 GMT) Full text and rfc822 format available.

Disconnected #6499 from all other report(s). Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Fri, 16 Jul 2010 16:00:05 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 14 Aug 2010 11:24:03 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 28 Sep 2010 22:17:02 GMT) Full text and rfc822 format available.

Forcibly Merged 4122 4125 4134 4843 4866 4884 4916 5353 5930 7095. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 28 Sep 2010 22:17:02 GMT) Full text and rfc822 format available.

Forcibly Merged 4122 4125 4134 4843 4866 4884 4916 5353 5930 7095 7162. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 05 Oct 2010 15:52:02 GMT) Full text and rfc822 format available.

Disconnected #7095 from all other report(s). Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Thu, 14 Oct 2010 15:50:03 GMT) Full text and rfc822 format available.

Disconnected #7162 from all other report(s). Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Thu, 14 Oct 2010 15:50:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 12 Nov 2010 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 14 years and 220 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.