GNU bug report logs - #43273
[PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Tue, 8 Sep 2020 10:50:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#43273: closed ([PATCH] gnu: taglib: Fix 'taglib-config
 --libs' -L flag.)
Date: Wed, 09 Sep 2020 07:40:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Wed, 09 Sep 2020 09:38:57 +0200
with message-id <87mu1zmmb2.fsf <at> gnu.org>
and subject line Re: [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
has caused the debbugs.gnu.org bug report #43273,
regarding [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
43273: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=43273
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.
Date: Tue,  8 Sep 2020 12:48:35 +0200
* gnu/packages/mp3.scm (taglib): Add "" around the substitution of
ZLIB_LIBRARIES_FLAGS.
---
 gnu/packages/mp3.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index a7574f0cf9..2e9b023407 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -182,9 +182,9 @@ a highly stable and efficient implementation.")
                        ;; flag for zlib.
                        (substitute* "CMakeLists.txt"
                          (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
-                          (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
+                          (string-append "set(ZLIB_LIBRARIES_FLAGS \"-L"
                                          (assoc-ref inputs "zlib")
-                                         " -lz)")))
+                                         " -lz\")")))
                        #t)))))
     (inputs `(("zlib" ,zlib)))
     (home-page "https://taglib.org")
-- 
2.28.0



[Message part 3 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43273-done <at> debbugs.gnu.org
Subject: Re: [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L
 flag.
Date: Wed, 09 Sep 2020 09:38:57 +0200
Hi,

Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/mp3.scm (taglib): Add "" around the substitution of
> ZLIB_LIBRARIES_FLAGS.

Applied.  Thanks and sorry for the delay!

Ludo’.


This bug report was last modified 4 years and 251 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.