GNU bug report logs - #43274
"genimage fails to build on arm architecture"

Previous Next

To reply to this bug, email your comments to 43274 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: bug-guix <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: fdisk fails to build on armhf
Date: Tue, 8 Sep 2020 13:19:39 +0200

Hello,

I am trying to build an armhf disk image on an aarch64 machine.

The build fails in this order:
genimage requires fdisk
fdisk requires guile-1.8.8 (!)
guile-1.8.8 fails two of its 16 tests:
ERROR: Value out of range -9223372036854775808 to 9223372036854775807: -9223372036854775808
FAIL: test-num2integral
fail: scm_is_signed_integer ((- (expt 2 63)), -9223372036854775808, 9223372036854775807) == 1
FAIL: test-conversion

This might be due to trying to "pseudo-cross-compile" from an aarch64 machine.
Independently, the last fdisk release dates from 2011, and relying on
guile-1.8.8 is not sustainable.

Can we phase out fdisk in Guix? Replace it by parted? Something else?
Actually genimage is the only package depending on fdisk, so if anything,
we could maybe drop this dependency, marked as
    (native-inputs
       ...
       ("fdisk" ,fdisk) ; for the tests

What do you think?

Andreas

Message #8 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 43274 <at> debbugs.gnu.org
Subject: Re: bug#43274: fdisk fails to build on armhf
Date: Tue, 8 Sep 2020 14:02:26 +0200

The same two tests also fail on an armhf machine.

Andreas

Message #11 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 43274 <at> debbugs.gnu.org
Subject: Re: bug#43274: fdisk fails to build on armhf
Date: Tue, 8 Sep 2020 15:12:03 +0200

Here is what happens when I drop fdisk from native-inputs of genimage:

starting phase `check'
make --no-print-directory check-TESTS
PASS: test/basic-images.test 1 - cpio
SKIP: test/basic-images.test 2 # SKIP cramfs (missing mkcramfs)
...
PASS: test/basic-images.test 20 - fit
============================================================================
Testsuite summary for genimage 11
============================================================================
# TOTAL: 20
# PASS:  19
# SKIP:  1
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0

So there does not even seem to be a test that relies on fdisk.

I would suggest to drop fdisk from this package (and getting closer to
dropping guile <at> 1.8 as well).

Andreas

Message #14 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 43274 <at> debbugs.gnu.org
Subject: Re: bug#43274: fdisk fails to build on armhf
Date: Tue, 8 Sep 2020 17:47:53 +0200

On Tue, Sep 08, 2020 at 03:12:03PM +0200, Andreas Enge wrote:
> So there does not even seem to be a test that relies on fdisk.

Looking at the tests, they do call "fdisk" and "sfdisk", but these come
from the util-linux package. The fdisk package only provides "gnufdisk",
which does not seem to be used at all.

> I would suggest to drop fdisk from this package (and getting closer to
> dropping guile <at> 1.8 as well).

The package without fdisk fails on aarch64 (where it also failed previously)
and on armhf (where previously its dependency fdisk failed). So I will push
a commit that drops fdisk.

The next step would be to check newer releases (12 and 13) of genimage.
Has it actually ever been built on the arm architecture?

Also, is there any opposition to then drop the fdisk package from the
distribution?

Andreas

Message #17 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 43274 <at> debbugs.gnu.org
Subject: Re: bug#43274: fdisk fails to build on armhf
Date: Tue, 8 Sep 2020 18:24:21 +0200

On Tue, Sep 08, 2020 at 05:47:53PM +0200, Andreas Enge wrote:
> The next step would be to check newer releases (12 and 13) of genimage.
> Has it actually ever been built on the arm architecture?

I tried 12 and 13, but already on x86_64 the test
FAIL: test/basic-images.test 7 - mke2fs
fails.

If someone with more experience with the package could have a look, that
would be nice.

Andreas

Message #22 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Timotej Lazar <timotej.lazar <at> araneo.si>
To: 43274 <at> debbugs.gnu.org
Cc: Andreas Enge <andreas <at> enge.fr>
Subject: Re: bug#43274: fdisk fails to build on armhf
Date: Tue, 08 Sep 2020 19:50:58 +0200

Hi,

Andreas Enge <andreas <at> enge.fr> [2020-09-08 18:24:21+0200]:
>> The next step would be to check newer releases (12 and 13) of genimage.
>> Has it actually ever been built on the arm architecture?

genimage tests fail on arm64 due to differently signed char. The fix¹
is in upstream master but has not been released yet. Maybe we can add
it to the current Guix package until then?

¹ https://github.com/pengutronix/genimage/commit/f4524ddc

Message #25 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: Timotej Lazar <timotej.lazar <at> araneo.si>
Cc: 43274 <at> debbugs.gnu.org
Subject: Re: bug#43274: fdisk fails to build on armhf
Date: Tue, 8 Sep 2020 23:00:56 +0200

Hello Timotej,

On Tue, Sep 08, 2020 at 07:50:58PM +0200, Timotej Lazar wrote:
> genimage tests fail on arm64 due to differently signed char. The fix¹
> is in upstream master but has not been released yet. Maybe we can add
> it to the current Guix package until then?
> ¹ https://github.com/pengutronix/genimage/commit/f4524ddc

great, thanks a lot! I applied and pushed this patch, and dropped fdisk
from the inputs. I am happy to report that genimage now builds on all
our four architectures, instead of just x86_64.

So, do we drop fdisk, which now is a leaf package?

Also, I tried updating genimage to version 12, but there is still a test
failure even on x86_64:
   FAIL: test/basic-images.test 7 - mke2fs
Here is the diff of the test:
--- /tmp/guix-build-genimage-12.drv-0/genimage-12-checkout/test/mke2fs.dump     2020-09-08 20:57:40.650216225 +0000
+++ dump        2020-09-08 20:57:47.962216531 +0000
@@ -11,7 +11,7 @@
 Inode count:              8192
 Block count:              32768
 Reserved block count:     1638
-Free blocks:              27592
+Free blocks:              27590
 Free inodes:              8141
 First block:              1
 Block size:               1024
@@ -29,7 +29,7 @@
 Maximum mount count:      -1
 Last checked:             Sat Jan  1 00:00:00 2000
 Check interval:           0 (<none>)
-Lifetime writes:          123 kB
+Lifetime writes:          125 kB
 Reserved blocks uid:      0 (user unknown)
 Reserved blocks gid:      0 (group unknown)
 First inode:              11
@@ -47,13 +47,13 @@
 Journal start:            0


-Group 0: (Blocks 1-8192) csum 0x62cb [ITABLE_ZEROED]
+Group 0: (Blocks 1-8192) csum 0xe083 [ITABLE_ZEROED]
   Primary superblock at 1, Group descriptors at 2-2
++ func_check
-  Block bitmap at 3 (+2), csum 0xb4967804
+  Block bitmap at 3 (+2), csum 0x0fddd371
   Inode bitmap at 7 (+6), csum 0xb1052088
   Inode table at 11-266 (+10)
-  7117 free blocks, 1997 free inodes, 18 directories, 1997 unused inodes
-  Free blocks: 1076-8192
+  7115 free blocks, 1997 free inodes, 18 directories, 1997 unused inodes
+  Free blocks: 1078-8192
   Free inodes: 52-2048
++ local ret=1
 Group 1: (Blocks 8193-16384) csum 0x7d4b [INODE_UNINIT, BLOCK_UNINIT, ITABLE_ZEROED]
++ set +x
Failed to execute 'check_ext'!
   Backup superblock at 8193, Group descriptors at 8194-8194
not ok 7 - mke2fs
FAIL: test/basic-images.test 7 - mke2fs


Andreas

Message #28 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Denis 'GNUtoo' Carikli <GNUtoo <at> cyberdimension.org>
To: 43274 <at> debbugs.gnu.org, bug-guile <at> gnu.org
Subject: Guile: test-num2integral and scm_is_signed_integer test failing.
Date: Mon, 14 Dec 2020 20:03:28 +0100

[Message part 1 (text/plain, inline)]

Hi,

Guile tests (also) fails on my setup.

I use Parabola i686 with a 64bit kernel( 5.7.2-gnu-1-64), and I've Guix
i686 installed[1].

When installing a package (gnurobots) with Guix, Guix tried to build
guile-1.8.8, and the compilation ends up with:
> libtool: link: gcc -I../../test-suite/standalone -I../.. -I../..
> -pthread -g -O2 -Wall -Wmissing-prototypes -pthread -o
> .libs/test-scm-with-guile test_scm_with_guile-test-scm-with-guile.o
> ../../libguile/.libs/libguile.so -lgmp -lcrypt -lm -lltdl -pthread
> -Wl,-rpath
> -Wl,/gnu/store/j6mnhk6iiy77m1ial0ffgjz2zwdc6m4z-guile-1.8.8/lib
> make[4]: Leaving directory
> '/tmp/guix-build-guile-1.8.8.drv-0/guile-1.8.8/test-suite/standalone'
> make  check-TESTS make[4]: Entering directory
> '/tmp/guix-build-guile-1.8.8.drv-0/guile-1.8.8/test-suite/standalone'
> PASS: test-system-cmds PASS: test-require-extension PASS:
> test-bad-identifiers ERROR: Value out of range -9223372036854775808
> to 9223372036854775807: -9223372036854775808 FAIL: test-num2integral
> PASS: test-round PASS: test-gh PASS: test-asmobs PASS: test-list
> PASS: test-unwind fail: scm_is_signed_integer ((- (expt 2 63)),
> -9223372036854775808, 9223372036854775807) == 1 FAIL: test-conversion
> PASS: test-fast-slot-ref
> PASS: test-use-srfi
> PASS: test-scm-c-read
> PASS: test-scm-take-locale-symbol
> PASS: test-with-guile-module
> PASS: test-scm-with-guile
> ==================================
> 2 of 16 tests failed
> Please report to bug-guile gnu.org
> ==================================
> make[4]: *** [Makefile:797: check-TESTS] Error 1
[...]

As bugreport says to bugreport to bug-guile gnu.org, and that there
is already an existing bug in Guix about it (for armhf), I've added
both in To.

I've also attached the full build log.

References:
-----------
[1] I've an x86_64 CPU but I kept my old Parabola rootfs
    around as it had too much configuration, and software in /usr/local.
    As I want to be able to chroot in x86_64 rootfs I need an x86_64
    kernel. So I added one to Parabola and I use that.

Denis.

[var_log_guix_drvs_j1_x0nq81kqygdw7vsvhaj6nxsc5k62zf-guile-1.8.8.drv.txt (text/plain, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #31 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 43274 <at> debbugs.gnu.org, 40331 <at> debbugs.gnu.org
Subject: latest genimage test suite
Date: Thu, 14 Jan 2021 13:33:55 +0100

Those two issues are linked...

The mke2fs test failure happens on
all versions after 11: 12, 13 & even the recent 14.

I tried the coreutils-with-xattrs that was suggested a while back, but
unsuccessfully.

Anyone had a chat with upstream about that failure ?

-- 
Vincent Legoll

Message #34 received at 43274 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: 43274 <at> debbugs.gnu.org, 40331 <at> debbugs.gnu.org
Subject: Re: latest genimage test suite
Date: Thu, 14 Jan 2021 13:45:39 +0100

On Thu, Jan 14, 2021 at 1:33 PM Vincent Legoll <vincent.legoll <at> gmail.com> wrote:
> Those two issues are linked...

The other one being the closed & archived :
40331 <at> debbugs.gnu.org

-- 
Vincent Legoll

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.