GNU bug report logs - #43272
27.1; variable-pitch-mode misaligns org-mode heading tags

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 43272 in the body.
You can then email your comments to 43272 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; variable-pitch-mode misaligns org-mode heading tags
Date: Tue, 08 Sep 2020 13:13:04 +0300

[Message part 1 (text/plain, inline)]

1. Run 'emacs -Q'
2. Open a new Org file 'C-x C-f /tmp/test.org'
3. Insert the following contents:

* TODO this is a test                                                   :tag:
* TODO here is another test                                             :tag:

The tags should align to the right with the standard monospaced font.

4. Run 'M-x variable-pitch-mode'.
5. The tags are now misaligned.

Please see attached screenshots for the before and after states of the
'variable-pitch-mode' activation.

Running 'M-x describe-char' in the space between the heading's title and
the tag informs us that the space's face is the same as the heading's
(e.g. 'org-level-1').

I am also relaying the technical insight of Adam Spiers.  Please see
attached plain text document or visit the comment's URL:
https://gitlab.com/protesilaos/modus-themes/-/issues/85#note_407147422

Overview of my setup:

+ GNU Emacs 27.1 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.22,
  cairo version 1.17.3) of 2020-08-14

+ Org mode version 9.3 (release_9.3 @ /usr/share/emacs/27.1/lisp/org/)

--
Protesilaos Stavrou
protesilaos.com

[variable-pitch-mode-org-headings-misaligned-1.png (image/png, attachment)]

[variable-pitch-mode-org-headings-misaligned-2.png (image/png, attachment)]

[adam-spiers-align-org-tags.txt (text/plain, attachment)]

Message #8 received at 43272 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43272 <at> debbugs.gnu.org
Subject: Re: bug#43272: 27.1; variable-pitch-mode misaligns org-mode heading
 tags
Date: Tue, 08 Sep 2020 14:10:54 +0200

Hi Protesilaos,

thanks for the report.

I suggest you post the same report to emacs-orgmode <at> gnu.org, where
more Org contributors may comment and try to help.

I can reproduce this problem and I don't know how to solve it.

As a comment to Adam's explorations: Org tags are not aligned with
respect to the window margin, but wrt to `org-tags-column'.  And I
don't think we can implement a solution without changing this, so
that's quite a change.

But perhaps someone will want to tackle this.

Thanks,

-- 
 Bastien

Message #11 received at 43272 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 43272 <at> debbugs.gnu.org
Subject: Re: bug#43272: 27.1;
 variable-pitch-mode misaligns org-mode heading tags
Date: Tue, 08 Sep 2020 17:41:23 +0300

> From: Protesilaos Stavrou <info <at> protesilaos.com>
> Date: Tue, 08 Sep 2020 13:13:04 +0300
> 
> 1. Run 'emacs -Q'
> 2. Open a new Org file 'C-x C-f /tmp/test.org'
> 3. Insert the following contents:
> 
> * TODO this is a test                                                   :tag:
> * TODO here is another test                                             :tag:
> 
> The tags should align to the right with the standard monospaced font.
> 
> 4. Run 'M-x variable-pitch-mode'.
> 5. The tags are now misaligned.
> 
> Please see attached screenshots for the before and after states of the
> 'variable-pitch-mode' activation.

This is the expected behavior: with variable-pitch fonts, characters
no longer have the same width, so aligning text by counting columns no
longer works.  You need pixel-level alignment.

This should be fixed in Org, I think.

Message #14 received at 43272 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Bastien <bzg <at> gnu.org>
Cc: info <at> protesilaos.com, 43272 <at> debbugs.gnu.org
Subject: Re: bug#43272: 27.1;
 variable-pitch-mode misaligns org-mode heading tags
Date: Tue, 08 Sep 2020 17:43:48 +0300

> From: Bastien <bzg <at> gnu.org>
> Date: Tue, 08 Sep 2020 14:10:54 +0200
> Cc: 43272 <at> debbugs.gnu.org
> 
> I suggest you post the same report to emacs-orgmode <at> gnu.org, where
> more Org contributors may comment and try to help.

Yes, please.

> As a comment to Adam's explorations: Org tags are not aligned with
> respect to the window margin, but wrt to `org-tags-column'.  And I
> don't think we can implement a solution without changing this, so
> that's quite a change.

Maybe I'm missing something, but :align-to accepts values in pixels,
so in general you could put a display property on the separating
whitespace and request that the whitespace ends at a certain pixel
coordinate from the left; that coordinate could somehow be computed
from org-tags-column, for example by multiplying it by
frame-char-width.

Message #19 received at 43272-done <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: info <at> protesilaos.com, 43272-done <at> debbugs.gnu.org
Subject: Re: bug#43272: 27.1; variable-pitch-mode misaligns org-mode heading
 tags
Date: Thu, 10 Sep 2020 07:41:22 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

> Maybe I'm missing something, but :align-to accepts values in pixels,
> so in general you could put a display property on the separating
> whitespace and request that the whitespace ends at a certain pixel
> coordinate from the left; that coordinate could somehow be computed
> from org-tags-column, for example by multiplying it by
> frame-char-width.

Thanks for the direction, I will try this.

I'm closing this report, as this is not an Emacs bug and it will be
discussed in Org's mailing list.

-- 
 Bastien

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.