GNU bug report logs - #43273
[PATCH] gnu: taglib: Fix 'taglib-config --libs' -L flag.

Previous Next

Package: guix-patches;

Reported by: Michael Rohleder <mike <at> rohleder.de>

Date: Tue, 8 Sep 2020 10:50:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 43273 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 43273 <at> debbugs.gnu.org
Subject: Re: [bug#43273] [PATCH] gnu: taglib: Fix 'taglib-config --libs' -L
 flag.
Date: Wed, 09 Sep 2020 10:28:59 +0200
Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/mp3.scm (taglib): Add "" around the substitution of
> ZLIB_LIBRARIES_FLAGS.
> ---
>  gnu/packages/mp3.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index a7574f0cf9..2e9b023407 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -182,9 +182,9 @@ a highly stable and efficient implementation.")
>                         ;; flag for zlib.
>                         (substitute* "CMakeLists.txt"
>                           (("set\\(ZLIB_LIBRARIES_FLAGS -lz\\)")
> -                          (string-append "set(ZLIB_LIBRARIES_FLAGS -L"
> +                          (string-append "set(ZLIB_LIBRARIES_FLAGS \"-L"
>                                           (assoc-ref inputs "zlib")
> -                                         " -lz)")))
> +                                         " -lz\")")))

As it turns out, we were also missing “/lib” there…  I’ve added it, and
hopefully now we’re all fine!

Ludo’.




This bug report was last modified 4 years and 251 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.