GNU bug report logs - #4194
23.0.91; Cursor face not changing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 4194 in the body.
You can then email your comments to 4194 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Nikolaj Schumacher <me <at> nschum.de>
To: Adrian Robert <adrian.b.robert <at> gmail.com>
Cc: Chong Yidong <cyd <at> stupidchicken.com>,
        Alberto Simões <albie <at> alfarrabio.di.uminho.pt>,
        emacs-pretest-bug <at> gnu.org
Subject: Re: 23.0.91; Cursor face not changing
Date: Tue, 18 Aug 2009 22:56:44 +0200

Sorry for the delay. I checked this again using a build from today.

On 2009-05-31, at 17:27, Adrian Robert wrote:

> On Apr 3, 2009, at 5:33 AM, Chong Yidong wrote:
>
>>> Although I am able to configure the cursor face using the usual
>>> custumization tool, the real colors/face doesn't change.
>>
>> I can't reproduce this, so it's likely a bug on NS.  Adrian, can you
>> reproduce it?
>
> I cannot.

Setting the background color seems to work now. The foreground color,  
inverse-video, and others don't stick.

> Nikolaj Schumacher added later that:
>
>> The same seems to happen for the region face.  The background color
>> reverts to ns_selection_color sometime after the custom variables are
>> read.  (It works when reading the custom settings again, later.)
>
> I looked at the code and cannot see how this could be happening.   
> The region face is set to ns_selection_color in ns-win.el, but this  
> should be overridden by .emacs read later.  This should have been  
> cleared up by David Reitter's changes around 2009-03-14, though  
> since the ChangeLog entries are incomplete it is difficult to be  
> certain when the last broken code was removed.
>
> Anyway, if you still observe these in a recent build let me know and  
> I'll go on a more thorough witch-hunt.

I've looked at this further, and it seems to work with an empty .emacs.
It fails with my configuration, because I set the frame's background  
color like this:

  (setq default-frame-alist
        '((background-color . "#040420")
          (foreground-color . "wheat")))

If I don't set the background-color, I get my customized region face.

If I manually evaluate the line after the initial frame was created,  
any additional frame uses the default ns_selection_color for the  
region. The first frame and customize-face keep my color.


Nik

Message #16 received at 4194-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 4194-done <at> debbugs.gnu.org
Subject: Re: bug#4194: 23.0.91; Cursor face not changing
Date: Wed, 16 Nov 2011 19:17:13 -0500

Version: 24.1

Nikolaj Schumacher wrote:

> Setting the background color seems to work now. The foreground color,
> inverse-video, and others don't stick.

In Emacs 24, the doc for the cursor face will say:

  Currently, only the `:background' attribute is meaningful; all
  other attributes are ignored.

With regards to the region face:

> This bug is easily fixed by changing the following line in ns-win.el:
>
> (set-face-background 'region "ns_selection_color")

This line was removed from ns-win some time ago, so I imagine this is
fixed too.

Please open a new report if there are still issues in the latest version.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.