GNU bug report logs - #3434
23.0.91; Cursor face not changing

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3434 in the body.
You can then email your comments to 3434 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Adrian Robert <adrian.b.robert <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: Alberto Simões <albie <at> alfarrabio.di.uminho.pt>,
        emacs-pretest-bug <at> gnu.org, Nikolaj Schumacher <me <at> nschum.de>
Subject: Re: 23.0.91; Cursor face not changing
Date: Sun, 31 May 2009 22:27:27 +0700

On Apr 3, 2009, at 5:33 AM, Chong Yidong wrote:

>> Although I am able to configure the cursor face using the usual
>> custumization tool, the real colors/face doesn't change.
>>
>> While the customization tool added to my .emacs the line:
>>    '(cursor ((t (:background "wheat" :foreground "black"))))
>>
>> under the faces configuration command, when emacs starts I get back
>> the original cursor colors (that are just annoying because I can't  
>> see
>> the character behind the cursor).
>>
>> Oh, This emacs is compiled by me, from cvs (about 15 days ago), under
>> MacOS/NS.
>
> I can't reproduce this, so it's likely a bug on NS.  Adrian, can you
> reproduce it?

I cannot.


Nikolaj Schumacher added later that:

> The same seems to happen for the region face.  The background color
> reverts to ns_selection_color sometime after the custom variables are
> read.  (It works when reading the custom settings again, later.)

I looked at the code and cannot see how this could be happening.  The  
region face is set to ns_selection_color in ns-win.el, but this  
should be overridden by .emacs read later.  This should have been  
cleared up by David Reitter's changes around 2009-03-14, though since  
the ChangeLog entries are incomplete it is difficult to be certain  
when the last broken code was removed.

Anyway, if you still observe these in a recent build let me know and  
I'll go on a more thorough witch-hunt.


thanks,
Adrian

Message #14 received at 3434 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Luke Renn <luke.renn <at> gmail.com>
To: 3434 <at> debbugs.gnu.org
Cc: adrian.b.robert <at> gmail.com
Subject: Re: 23.0.91; Cursor face not changing
Date: Sun, 16 Aug 2009 00:33:38 -0400

[Message part 1 (text/plain, inline)]

> I looked at the code and cannot see how this could be happening.  The
> region face is set to ns_selection_color in ns-win.el, but this
> should be overridden by .emacs read later.

It probably should, but it doesn't seem to.

This bug is easily fixed by changing the following line in ns-win.el:

(set-face-background 'region "ns_selection_color")

To:

(if (not (face-attribute 'region :background))
    (set-face-background 'region "ns_selection_color"))

Tested and confirmed on a git checkout from 8/14.

The real fix may be to change when ns-win.el runs, but I didn't look into that.

Thanks,

Luke

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.