GNU bug report logs - #40756
gnu: Add ktsuss.

Previous Next

Full log

View this message in rfc822 format

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40756 <at> debbugs.gnu.org
Subject: [bug#40756] gnu: Add ktsuss. (v3)
Date: Fri, 24 Apr 2020 15:23:02 -0400

[Message part 1 (text/plain, inline)]

On Fri, 24 Apr 2020 15:21:31 -0400
Raghav Gururajan <raghavgururajan <at> disroot.org> wrote:

> Hi Nicolas!
> 
> > > Subject: [PATCH 4/4] gnu: Add ktsuss.    
> > 
> > Thank you! 
> > 
> > It looks mostly good. I have some comments, tho.
> >   
> > > +       (modify-phases %standard-phases
> > > +         (add-after 'unpack 'patch    
> > 
> > Could you provide a more insightful name for the new phase? :)
> >   
> > > +           (lambda _
> > > +             (substitute* "configure.ac"
> > > +               (("sudopath=`which sudo 2>/dev/null`")
> > > +                (string-append "sudopath="
> > > +                               (string-append (assoc-ref %build-inputs
> > > "sudo")
> > > +                                              "/bin/sudo"))))    
> > 
> > Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
> > instead of the magical %build-inputs.
> >   
> > > +    (synopsis "Graphical front-end for Su")    
> > 
> > I would write:
> > 
> >   Graphical front end for @command{su}
> >   
> > > +    (description "Ktsuss stands for 'keep the su simple, stupid', and as
> > > the +name says, is a graphical version (frontend) of su written in C and
> > > GTK+ 2.  The +idea of the project is to remain simple and bug free.")    
> > 
> > What about :
> > 
> >     (description
> >      "Ktsuss stands for ``Keep the @command{su} simple, stupid''.
> > It is a graphical version of @command{su} written in C and GTK+ 2,
> > with simplicity in mind.")
> >   
> > > +    (license
> > > +     (list
> > > +      (license:non-copyleft "file://COPYING")
> > > +      (license:non-copyleft "file://LICENSE")))))    
> > 
> > It looks like the license is `bsd-3'. Do you have any reason to think
> > otherwise ?
> > 
> > Could you send an updated patch?  
> 
> Thank you for the feedback. Please find the updated patch attached with this
> email.
> 
> Regards,
> RG.

[0001-gnu-Add-ktsuss.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.