GNU bug report logs - #40757
New package: VisiData

Previous Next

Package: guix-patches;

Reported by: Ryan Prior <rprior <at> protonmail.com>

Date: Wed, 22 Apr 2020 02:06:02 UTC

Severity: normal

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40757 in the body.
You can then email your comments to 40757 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#40757; Package guix-patches. (Wed, 22 Apr 2020 02:06:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ryan Prior <rprior <at> protonmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 22 Apr 2020 02:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: New package: VisiData
Date: Wed, 22 Apr 2020 00:51:10 +0000
[Message part 1 (text/plain, inline)]
Hi Guix! This patch adds a package for VisiData.

VisiData is an interactive multitool for tabular data. It combines the clarity of a spreadsheet, the efficiency of the terminal, and the power of Python, into a lightweight utility which can handle millions of rows with ease. https://www.visidata.org/, GPLv3

Tests are disabled because they are not packaged with the source tarball.
You can view test status here: https://circleci.com/gh/saulpw/visidata/tree/stable
Upstream suggests tests will be packaged with their source tarball around their 2.0 release.

Cheers,
Ryan Prior
[Message part 2 (text/html, inline)]
[0001-gnu-Add-visidata.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#40757; Package guix-patches. (Wed, 22 Apr 2020 15:54:01 GMT) Full text and rfc822 format available.

Message #8 received at 40757 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: 40757 <at> debbugs.gnu.org
Subject: Re: [bug#40757] New package: VisiData
Date: Wed, 22 Apr 2020 11:53:18 -0400 (EDT)
Ryan,

On Wed, 22 Apr 2020, Ryan Prior via Guix-patches via wrote:

> Hi Guix! This patch adds a package for VisiData.
> 
> VisiData is an interactive multitool for tabular data. It combines the clarity of a
> spreadsheet, the efficiency of the terminal, and the power of Python, into a
> lightweight utility which can handle millions of rows with ease.
> https://www.visidata.org/, GPLv3

Thanks for the patch! This looks like some cool software.

I'm not an expert reviewer, but I'd like to try to help by offering the 
following suggestions for improvement.

>diff --git a/gnu/packages/visidata.scm b/gnu/packages/visidata.scm
>new file mode 100644
>index 0000000000..d9df94dc9b
>--- /dev/null
>+++ b/gnu/packages/visidata.scm

When adding new modules, please also add the file to gnu/local.mk

>+(define-module (visidata)

The module name should be (gnu packages visidata) to match the filesystem 
path.

It might be helpful to catch problems like this to try to apply your patch 
apply your patch to a guix source checkout, and try building your package 
from there. The manual has some documentation about that, 
<https://guix.gnu.org/manual/en/html_node/Building-from-Git.html>, but I 
can answer questions as well.

>+(define-public visidata
>+  (package
>+   (name "visidata")
>+   (version "1.5.2")
>+   (source (origin
>+            (method url-fetch)
>+            (uri (string-append "https://github.com/saulpw/visidata/archive/v" version ".tar.gz"))

The GitHub archive URIs are not stable and could result in a different 
hash in the future. Often in these cases we use git-fetch, but since 
visidata is available on pypi, I would recommend

(uri (pypi-uri "visidata" version))

>+            (sha256 (base32 "0h7hq6bnc8svkcc9995kkmgcb9n5qgm85rsshzzdicmg9rg3ymhi"))))
>+   (build-system python-build-system)
>+   (arguments '(#:tests? #f))
>+   ;; Tests disabled because they are not packaged with the source tarball.
>+   ;; View test status here: https://circleci.com/gh/saulpw/visidata/tree/stable
>+   ;; Upstream suggests tests will be packaged with tarball around 2.0 release.

Nitpick: I would prefer to have the comment before the code. I think the 
line about circleci could be removed, but the other two seem good.

>+   (native-inputs
>+    `(("python-dateutil" ,python-dateutil)
>+      ("python-fonttools" ,python-fonttools)
>+      ("python-h5py" ,python-h5py)
>+      ("python-lxml" ,python-lxml)
>+      ("python-openpyxl" ,python-openpyxl)
>+      ("python-psycopg2" ,python-psycopg2)
>+      ("python-pyyaml" ,python-pyyaml)
>+      ("python-requests" ,python-requests)
>+      ("python-xlrd" ,python-xlrd)
>+      ("python-pandas" ,python-pandas)))

Are these all native inputs (required to make the build system run)? I 
expect that some of them could be moved to inputs (run-tine dependencies).

>+   (synopsis "Visidata: A terminal spreadsheet multitool for discovering and arranging data")

guix lint reports that the synopsis should not start with the package 
name. In this case, I think it could be changed to, "Terminal spreadsheet 
for discovering and arranging data".

>+   (description
>+    "VisiData is an interactive multitool for tabular data. It combines the

Please use two spaces between sentences in the description.

>+clarity of a spreadsheet, the efficiency of the terminal, and the power of
>+Python, into a lightweight utility which can handle millions of rows with ease.")

Nitpick: "with ease" sounds like a marketing term, and I believe we can 
leave it out here.

>+   (home-page "https://www.visidata.org/")
>+   (license gpl3)))

In other modules, we import licenses with the license: prefix, so we can 
refer to licenses as like license:gpl3. It might be nice to do that 
here for consistency as well.

The vdtui.py file is under the expat license, so we should record that 
here. With these changes the license field would become something like:

(license (list license:gpl3
               license:expat)) ; visidata/vdtui.py

Thanks and all the best,
Jack




Information forwarded to guix-patches <at> gnu.org:
bug#40757; Package guix-patches. (Wed, 22 Apr 2020 20:56:01 GMT) Full text and rfc822 format available.

Message #11 received at 40757 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Prior <rprior <at> protonmail.com>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: "40757 <at> debbugs.gnu.org" <40757 <at> debbugs.gnu.org>
Subject: Re: [bug#40757] New package: VisiData
Date: Wed, 22 Apr 2020 20:24:25 +0000
[Message part 1 (text/plain, inline)]
Hi Jack,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Wednesday, April 22, 2020 3:53 PM, Jack Hill <jackhill <at> jackhill.us> wrote:


> I'm not an expert reviewer, but I'd like to try to help by offering the
> following suggestions for improvement.

Thank you for these suggestions! I've attached an updated version of the patch.

Ryan
[0001-gnu-Add-visidata.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#40757; Package guix-patches. (Wed, 22 Apr 2020 21:04:01 GMT) Full text and rfc822 format available.

Message #14 received at 40757 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Ryan Prior <rprior <at> protonmail.com>
Cc: "40757 <at> debbugs.gnu.org" <40757 <at> debbugs.gnu.org>
Subject: Re: [bug#40757] New package: VisiData
Date: Wed, 22 Apr 2020 17:03:00 -0400 (EDT)
[Message part 1 (text/plain, inline)]
On Wed, 22 Apr 2020, Ryan Prior via Guix-patches via wrote:

> Hi Jack,
>
> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> On Wednesday, April 22, 2020 3:53 PM, Jack Hill <jackhill <at> jackhill.us> wrote:
>
>
>> I'm not an expert reviewer, but I'd like to try to help by offering the
>> following suggestions for improvement.
>
> Thank you for these suggestions! I've attached an updated version of the patch.

You're welcome, and thanks for sending the updated patch.

I think now we're waiting on a more experienced reviewer to see if I 
missed anything, and if it looks good a committer to push your patch.

Best,
Jack

Information forwarded to guix-patches <at> gnu.org:
bug#40757; Package guix-patches. (Thu, 23 Apr 2020 05:25:02 GMT) Full text and rfc822 format available.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Ryan Prior <rprior <at> protonmail.com>,
 Ryan Prior via Guix-patches <guix-patches <at> gnu.org>
Cc: 40757-done <at> debbugs.gnu.org
Subject: Re: [bug#40757] New package: VisiData
Date: Thu, 23 Apr 2020 07:24:02 +0200
Hi Ryan,

I’ve adjusted the patch to gnu/local.mk which no longer applied, changed
spaces to tabs in gnu/local.mk, fixed the indentation of visidata.scm,
ran “guix lint”, built it and tested it (didn’t know how to exit, so I
just did ^Zkill %1) … and pushed it to the master branch with commit
c47f48d972.

Thank you for your patch!

--
Ricardo




Reply sent to Ricardo Wurmus <rekado <at> elephly.net>:
You have taken responsibility. (Thu, 23 Apr 2020 05:25:02 GMT) Full text and rfc822 format available.

Notification sent to Ryan Prior <rprior <at> protonmail.com>:
bug acknowledged by developer. (Thu, 23 Apr 2020 05:25:03 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#40757; Package guix-patches. (Thu, 23 Apr 2020 05:26:01 GMT) Full text and rfc822 format available.

Message #25 received at 40757 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Jack Hill <jackhill <at> jackhill.us>
Cc: Ryan Prior <rprior <at> protonmail.com>, 40757 <at> debbugs.gnu.org
Subject: Re: [bug#40757] New package: VisiData
Date: Thu, 23 Apr 2020 07:25:32 +0200
Hey Jack,

thanks to your review and Ryan’s response to it I only had to perform
minimal changes to apply the patch.  Thank you very much!

--
Ricardo




Information forwarded to guix-patches <at> gnu.org:
bug#40757; Package guix-patches. (Thu, 23 Apr 2020 15:30:02 GMT) Full text and rfc822 format available.

Message #28 received at 40757 <at> debbugs.gnu.org (full text, mbox):

From: Jack Hill <jackhill <at> jackhill.us>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: Ryan Prior <rprior <at> protonmail.com>, 40757 <at> debbugs.gnu.org
Subject: Re: [bug#40757] New package: VisiData
Date: Thu, 23 Apr 2020 11:29:12 -0400 (EDT)
[Message part 1 (text/plain, inline)]
On Thu, 23 Apr 2020, Ricardo Wurmus wrote:

>
> Hey Jack,
>
> thanks to your review and Ryan’s response to it I only had to perform
> minimal changes to apply the patch.  Thank you very much!

You're welcome. It makes me happy to help where I can.

I 💚 Guix

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 22 May 2020 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 5 years and 88 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.