GNU bug report logs - #40756
gnu: Add ktsuss.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40756 in the body.
You can then email your comments to 40756 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: gnu: Add ktsuss.
Date: Tue, 21 Apr 2020 19:26:22 -0400

[Message part 1 (text/plain, inline)]

[ktsuss.patch (text/x-patch, attachment)]

Message #8 received at 40756 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40756 <at> debbugs.gnu.org
Subject: Re: [bug#40756] gnu: Add ktsuss.
Date: Thu, 23 Apr 2020 10:17:14 +0200

Hello,

Raghav Gururajan <raghavgururajan <at> disroot.org> writes:

> Subject: [PATCH 4/4] gnu: Add ktsuss.

Thank you! 

It looks mostly good. I have some comments, tho.

> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch

Could you provide a more insightful name for the new phase? :)

> +           (lambda _
> +             (substitute* "configure.ac"
> +               (("sudopath=`which sudo 2>/dev/null`")
> +                (string-append "sudopath="
> +                               (string-append (assoc-ref %build-inputs "sudo")
> +                                              "/bin/sudo"))))

Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
instead of the magical %build-inputs.

> +    (synopsis "Graphical front-end for Su")

I would write:

  Graphical front end for @command{su}

> +    (description "Ktsuss stands for 'keep the su simple, stupid', and as the
> +name says, is a graphical version (frontend) of su written in C and GTK+ 2.  The
> +idea of the project is to remain simple and bug free.")

What about :

    (description
     "Ktsuss stands for ``Keep the @command{su} simple, stupid''.
It is a graphical version of @command{su} written in C and GTK+ 2,
with simplicity in mind.")

> +    (license
> +     (list
> +      (license:non-copyleft "file://COPYING")
> +      (license:non-copyleft "file://LICENSE")))))

It looks like the license is `bsd-3'. Do you have any reason to think
otherwise ?

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #11 received at 40756 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40756 <at> debbugs.gnu.org
Subject: Re: [bug#40756] gnu: Add ktsuss.
Date: Fri, 24 Apr 2020 15:21:31 -0400

Hi Nicolas!

> > Subject: [PATCH 4/4] gnu: Add ktsuss.  
> 
> Thank you! 
> 
> It looks mostly good. I have some comments, tho.
> 
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'patch  
> 
> Could you provide a more insightful name for the new phase? :)
> 
> > +           (lambda _
> > +             (substitute* "configure.ac"
> > +               (("sudopath=`which sudo 2>/dev/null`")
> > +                (string-append "sudopath="
> > +                               (string-append (assoc-ref %build-inputs
> > "sudo")
> > +                                              "/bin/sudo"))))  
> 
> Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
> instead of the magical %build-inputs.
> 
> > +    (synopsis "Graphical front-end for Su")  
> 
> I would write:
> 
>   Graphical front end for @command{su}
> 
> > +    (description "Ktsuss stands for 'keep the su simple, stupid', and as
> > the +name says, is a graphical version (frontend) of su written in C and
> > GTK+ 2.  The +idea of the project is to remain simple and bug free.")  
> 
> What about :
> 
>     (description
>      "Ktsuss stands for ``Keep the @command{su} simple, stupid''.
> It is a graphical version of @command{su} written in C and GTK+ 2,
> with simplicity in mind.")
> 
> > +    (license
> > +     (list
> > +      (license:non-copyleft "file://COPYING")
> > +      (license:non-copyleft "file://LICENSE")))))  
> 
> It looks like the license is `bsd-3'. Do you have any reason to think
> otherwise ?
> 
> Could you send an updated patch?

Thank you for the feedback. Please find the updated patch attached with this
email.

Regards,
RG.

Message #14 received at 40756 <at> debbugs.gnu.org (full text, mbox):

From: Raghav Gururajan <raghavgururajan <at> disroot.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40756 <at> debbugs.gnu.org
Subject: Re: [bug#40756] gnu: Add ktsuss. (v3)
Date: Fri, 24 Apr 2020 15:23:02 -0400

[Message part 1 (text/plain, inline)]

On Fri, 24 Apr 2020 15:21:31 -0400
Raghav Gururajan <raghavgururajan <at> disroot.org> wrote:

> Hi Nicolas!
> 
> > > Subject: [PATCH 4/4] gnu: Add ktsuss.    
> > 
> > Thank you! 
> > 
> > It looks mostly good. I have some comments, tho.
> >   
> > > +       (modify-phases %standard-phases
> > > +         (add-after 'unpack 'patch    
> > 
> > Could you provide a more insightful name for the new phase? :)
> >   
> > > +           (lambda _
> > > +             (substitute* "configure.ac"
> > > +               (("sudopath=`which sudo 2>/dev/null`")
> > > +                (string-append "sudopath="
> > > +                               (string-append (assoc-ref %build-inputs
> > > "sudo")
> > > +                                              "/bin/sudo"))))    
> > 
> > Please use (lambda* (#:key inputs #:allow-other-keys) ...) and `inputs'
> > instead of the magical %build-inputs.
> >   
> > > +    (synopsis "Graphical front-end for Su")    
> > 
> > I would write:
> > 
> >   Graphical front end for @command{su}
> >   
> > > +    (description "Ktsuss stands for 'keep the su simple, stupid', and as
> > > the +name says, is a graphical version (frontend) of su written in C and
> > > GTK+ 2.  The +idea of the project is to remain simple and bug free.")    
> > 
> > What about :
> > 
> >     (description
> >      "Ktsuss stands for ``Keep the @command{su} simple, stupid''.
> > It is a graphical version of @command{su} written in C and GTK+ 2,
> > with simplicity in mind.")
> >   
> > > +    (license
> > > +     (list
> > > +      (license:non-copyleft "file://COPYING")
> > > +      (license:non-copyleft "file://LICENSE")))))    
> > 
> > It looks like the license is `bsd-3'. Do you have any reason to think
> > otherwise ?
> > 
> > Could you send an updated patch?  
> 
> Thank you for the feedback. Please find the updated patch attached with this
> email.
> 
> Regards,
> RG.

[0001-gnu-Add-ktsuss.patch (text/x-patch, attachment)]

Message #19 received at 40756-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Raghav Gururajan <raghavgururajan <at> disroot.org>
Cc: 40756-done <at> debbugs.gnu.org
Subject: Re: [bug#40756] gnu: Add ktsuss. (v3)
Date: Fri, 24 Apr 2020 22:12:15 +0200

Hello,

Raghav Gururajan <raghavgururajan <at> disroot.org> writes:

> Subject: [PATCH] gnu: Add ktsuss.
>
> * gnu/packages/admin.scm (ktsuss): New variable.

Applied. Thank you.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.