GNU bug report logs - #40128
[PATCH 1/2] gnu: Add emacs-pretty-hydra.

Previous Next

Full log

View this message in rfc822 format

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40128 <at> debbugs.gnu.org
Subject: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sat, 21 Mar 2020 18:12:34 -0500

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

>> As noted in the description, this package is not intended for 
>> use by
>> end-users.  Is there a convention for communicating that?
>
> I think specifying it in the description is the correct way.

Noted.

>> +    (propagated-inputs
>> +     `(("emacs-hydra" ,emacs-hydra)
>> +       ("emacs-s" ,emacs-s)
>> +       ("emacs-dash" ,emacs-dash)))
>
> Could you re-order them alphabetically?

Done.

>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'add-source-to-load-path 
>> 'remove-pretty-hydra
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             ;; major-mode-hydra is packaged separately.
>> +             (delete-file "major-mode-hydra.el")
>> +             #t)))))
>
> You can use #:exclude keyword from the Emacs build system 
> instead.

Thanks for the tip!

> Could you send an updated patch?

Patch file is attached.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-pretty-hydra.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.