GNU bug report logs - #40127
27.0.90; image-mode fails on all images with short EXIF tags

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40127 in the body.
You can then email your comments to 40127 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.90; image-mode fails on all images with short EXIF tags
Date: Thu, 19 Mar 2020 01:57:03 +0200

I realized that the 4th problem reported in bug#39994 is not related to
image-converter.el, so here is a separate bug report.

The problem is that currently image-mode fails to open all image files
where one of EXIF tags is shorter than 4 bytes.  So none of the
images created by a device whose EXIF tag "Manufacturer" is "HTC"
can not be opened in Emacs 27.

Here's is the patch that at least allows opening any image
ignoring errors in EXIF parser implementation:

diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 22d7d91314..10900be33f 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -769,7 +769,7 @@ image-toggle-display-image
     ;; Get the rotation data from the file, if any.
     (setq image-transform-rotation
           (or (exif-orientation
-               (ignore-error exif-error
+               (ignore-errors
                  (exif-parse-buffer)))
               0.0))
 

Message #8 received at 40127 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 40127 <at> debbugs.gnu.org
Subject: Re: bug#40127: 27.0.90; image-mode fails on all images with short
 EXIF tags
Date: Thu, 19 Mar 2020 16:19:35 +0100

Juri Linkov <juri <at> linkov.net> writes:

> I realized that the 4th problem reported in bug#39994 is not related to
> image-converter.el, so here is a separate bug report.
>
> The problem is that currently image-mode fails to open all image files
> where one of EXIF tags is shorter than 4 bytes.  So none of the
> images created by a device whose EXIF tag "Manufacturer" is "HTC"
> can not be opened in Emacs 27.

OK, fixed now in Emacs 27.  (Well, I did the fix on the trunk and then
cherry-picked it...  I was slightly unsure whether to also include the
new test cases and files, but I did so anyway -- they won't affect the
release anyway, I think?)

> Here's is the patch that at least allows opening any image
> ignoring errors in EXIF parser implementation:

[...]

> -               (ignore-error exif-error
> +               (ignore-errors
>                   (exif-parse-buffer)))

No, we should never wallpaper over bugs in the code -- we should fix the
bugs.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.