GNU bug report logs - #40128
[PATCH 1/2] gnu: Add emacs-pretty-hydra.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 40128 in the body.
You can then email your comments to 40128 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Thu, 19 Mar 2020 00:41:44 -0500

[Message part 1 (text/plain, inline)]

Patch file is attached.

As noted in the description, this package is not intended for use 
by end-users.  Is there a convention for communicating that?

--
Joseph LaFreniere

[0001-gnu-Add-emacs-pretty-hydra.patch (text/x-patch, attachment)]

Message #8 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: 40128 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
Date: Thu, 19 Mar 2020 00:46:29 -0500

[Message part 1 (text/plain, inline)]

Patch file is attached.

--
Joseph LaFreniere

[0002-gnu-Add-emacs-major-mode-hydra.patch (text/x-patch, attachment)]

Message #11 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 40128 <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sat, 21 Mar 2020 17:38:28 +0100

Hello,

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> writes:

> Patch file is attached.

Thank you.

> As noted in the description, this package is not intended for use by
> end-users.  Is there a convention for communicating that?

I think specifying it in the description is the correct way.

> +    (propagated-inputs
> +     `(("emacs-hydra" ,emacs-hydra)
> +       ("emacs-s" ,emacs-s)
> +       ("emacs-dash" ,emacs-dash)))

Could you re-order them alphabetically?

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'add-source-to-load-path 'remove-pretty-hydra
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             ;; major-mode-hydra is packaged separately.
> +             (delete-file "major-mode-hydra.el")
> +             #t)))))

You can use #:exclude keyword from the Emacs build system instead.

Could you send an updated patch?

Regards,

-- 
Nicolas Goaziou

Message #14 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 40128 <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
Date: Sat, 21 Mar 2020 17:41:10 +0100

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> writes:

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'add-source-to-load-path 'remove-pretty-hydra
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             ;; pretty-hydra is provided by dependency.
> +             (delete-file "pretty-hydra.el")
> +             #t)))))

There, too, you may use #:exclude.

Message #17 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40128 <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sat, 21 Mar 2020 18:12:34 -0500

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

>> As noted in the description, this package is not intended for 
>> use by
>> end-users.  Is there a convention for communicating that?
>
> I think specifying it in the description is the correct way.

Noted.

>> +    (propagated-inputs
>> +     `(("emacs-hydra" ,emacs-hydra)
>> +       ("emacs-s" ,emacs-s)
>> +       ("emacs-dash" ,emacs-dash)))
>
> Could you re-order them alphabetically?

Done.

>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'add-source-to-load-path 
>> 'remove-pretty-hydra
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             ;; major-mode-hydra is packaged separately.
>> +             (delete-file "major-mode-hydra.el")
>> +             #t)))))
>
> You can use #:exclude keyword from the Emacs build system 
> instead.

Thanks for the tip!

> Could you send an updated patch?

Patch file is attached.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-pretty-hydra.patch (text/x-patch, attachment)]

Message #20 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40128 <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 2/2] gnu: Add emacs-major-mode-hydra.
Date: Sat, 21 Mar 2020 18:13:51 -0500

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-before 'add-source-to-load-path 
>> 'remove-pretty-hydra
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             ;; pretty-hydra is provided by dependency.
>> +             (delete-file "pretty-hydra.el")
>> +             #t)))))
>
> There, too, you may use #:exclude.

New patch file implemented with #:exclude is attached.  Thank you 
very much for reviewing.

--
Joseph LaFreniere

[0002-gnu-Add-emacs-major-mode-hydra.patch (text/x-patch, attachment)]

Message #23 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40128 <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sun, 19 Apr 2020 12:57:26 -0500

Any updates on this?

--
Joseph LaFreniere

Message #26 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "LaFreniere\, Joseph" <joseph <at> lafreniere.xyz>
Cc: 40128 <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sun, 19 Apr 2020 20:28:50 +0200

Hello,

"LaFreniere, Joseph" <joseph <at> lafreniere.xyz> writes:

> Any updates on this?

Uh? Did I miss your updated patch?

Would you mind sending it again?

Regards,

-- 
Nicolas Goaziou

Message #29 received at 40128 <at> debbugs.gnu.org (full text, mbox):

From: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 40128 <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sun, 19 Apr 2020 14:24:20 -0500

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
> Uh? Did I miss your updated patch?
>
> Would you mind sending it again?

No problem.  :)

Patch file is attached.

--
Joseph LaFreniere

[0001-gnu-Add-emacs-pretty-hydra.patch (text/x-patch, attachment)]

Message #34 received at 40128-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: "LaFreniere, Joseph" <joseph <at> lafreniere.xyz>
Cc: 40128-done <at> debbugs.gnu.org
Subject: Re: [bug#40128] [PATCH 1/2] gnu: Add emacs-pretty-hydra.
Date: Sat, 21 Nov 2020 09:12:50 +0000

[Message part 1 (text/plain, inline)]

LaFreniere, Joseph <joseph <at> lafreniere.xyz> writes:

> Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:
>> Uh? Did I miss your updated patch?
>>
>> Would you mind sending it again?
>
> No problem.  :)
>
> Patch file is attached.

It's been a few months, so I've reviewed and pushed what I think were
the most up to date patches. They're on master as of
90eb5dd6b5989eeb5350c785036c53469496e394.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.