GNU bug report logs - #3950
23.0.91; hs-minor-mode should obey hs-search-mode for viper searches too

Previous Next

To reply to this bug, email your comments to 3950 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Guido Van Hoecke <gnuemacs <at> vanhoecke.org>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.91; hs-minor-mode should obey hs-search-mode for viper searches too
Date: Mon, 27 Jul 2009 19:46:21 +0200

I use 'viper-mode' and 'hs-minor-mode' for most of my editing. Both
modes are part of GNU Emacs and thus should probably cooperate.

Hideshow provides the 'hs-isearch-open' variable that controls what
should be opened when the searched text is inside a closed fold. I
feel that a similar functionality is needed for viper searching,
something like 'hs-viper-open' with similar values.

Right now, I must open the fold ('hs-toggle-hiding') and search again
('viper-search-next') if I want to position point at the searched
text. I feel that this should be automated as it is done for
'isearch'.

Guivho.

In GNU Emacs 23.0.91.1 (x86_64-pc-linux-gnu, GTK+ Version 2.16.0)
 of 2009-04-05 on crested, modified by Debian
 (emacs-snapshot package, version 1:20090320-1ubuntu1)
Windowing system distributor `The X.Org Foundation', version 11.0.10600000
configured using `configure  '--build' 'x86_64-linux-gnu' '--host' 'x86_64-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.91/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.91/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=x86_64-linux-gnu' 'host_alias=x86_64-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  shell-dirtrack-mode: t
  minibuffer-depth-indicate-mode: t
  icicle-mode: t
  show-paren-mode: t
  iswitchb-mode: t
  display-time-mode: t
  savehist-mode: t
  desktop-save-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  hs-minor-mode: t

Recent input:
<left> <left> <left> <left> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
c o m p l y SPC w i t h <right> h s - <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <right> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> o b e y SPC <delete> <delete> <delete> 
<delete> <delete> <delete> <delete> <delete> <delete> 
<delete> <delete> <delete> <end> SPC f o r SPC v i 
p e r <XF86ScrollUp> <XF86ScrollUp> <f1> k / <XF86ScrollUp> 
d <backspace> SPC s e a r c h e s SPC t o o <return> 
<up> <up> <up> <up> <up> <down> <down> <down> <down> 
<up> <up> <up> <up> <up> <up> <up> <up> <up> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <right> <right> 
<right> <right> <right> <right> <right> <down> <down> 
<up> <up> <down> <down> <down> <down> <down> <down> 
<down> <down> <down> <down> <down> <up> <up> <up> <up> 
<down> <down> <next> <next> <next> <prior> <prior> 
<prior> <next> <next> <prior> <prior> <prior> <down-mouse-1> 
<mouse-movement> <mouse-movement> <mouse-movement> 
<help-echo> <mouse-movement> <help-echo> <help-echo> 
<help-echo> <mouse-movement> <mouse-movement> <drag-mouse-1> 
<S-delete> <XF86Cut> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo> 
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:
Loading msgdb for +draft...done
Type C-c C-x C-z to exit MIME mode, and type C-c C-x ? to get help.
Saving...done
Saving...done [2 times]
 [13 times]
call-interactively: Beginning of buffer
Beginning of buffer

Saving...done
 [5 times]

Message #10 received at 3950 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Guido Van Hoecke <gnuemacs <at> vanhoecke.org>
Cc: 3950 <at> debbugs.gnu.org
Subject: Re: bug#3950: 23.0.91; hs-minor-mode should obey hs-search-mode for viper searches too
Date: Tue, 28 Jul 2009 10:03:50 -0400

> Right now, I must open the fold ('hs-toggle-hiding') and search again
> ('viper-search-next') if I want to position point at the searched
> text. I feel that this should be automated as it is done for
> 'isearch'.

You might want to try reveal-mode as well (don't know if it works with
Viper's search, but it might, and if not, it's also a bug).


        Stefan

Message #15 received at 3950 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Guido Van Hoecke <gnuemacs <at> vanhoecke.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 3950 <at> debbugs.gnu.org
Subject: Re: bug#3950: 23.0.91; hs-minor-mode should obey hs-search-mode for
 viper searches too
Date: Tue, 28 Jul 2009 17:28:04 +0200

Stefan Monnier wrote:
>> Right now, I must open the fold ('hs-toggle-hiding') and search again
>> ('viper-search-next') if I want to position point at the searched
>> text. I feel that this should be automated as it is done for
>> 'isearch'.
>
> You might want to try reveal-mode as well (don't know if it works with
> Viper's search, but it might, and if not, it's also a bug).

I didn't know reveal-mode, shame on me!

Thanks Stefan, both for having written it and for pointing my nose in
the proper direction! It works with viper's search, so no bug there!

The cursor sits on the ... for about 2 seconds, and than the fold
opens. Is there some kind of (configurable) time-out before the fold
opens?

Guido

--
What does not destroy me, makes me stronger.
		-- Nietzsche

http://vanhoecke.org ... and go2 places!

Message #20 received at 3950 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Guido Van Hoecke <gnuemacs <at> vanhoecke.org>, 3950 <at> debbugs.gnu.org
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#3950: 23.0.91; hs-minor-mode should obey hs-search-mode for 
	viper searches too
Date: Wed, 29 Jul 2009 01:05:43 +0200

On Tue, Jul 28, 2009 at 5:28 PM, Guido Van Hoecke<gnuemacs <at> vanhoecke.org> wrote:

>> You might want to try reveal-mode as well (don't know if it works with
>> Viper's search, but it might, and if not, it's also a bug).
>
> I didn't know reveal-mode, shame on me!
>
> Thanks Stefan, both for having written it and for pointing my nose in
> the proper direction! It works with viper's search, so no bug there!
>
> The cursor sits on the ... for about 2 seconds, and than the fold
> opens. Is there some kind of (configurable) time-out before the fold
> opens?

I think that is a Viper thing. Isn't there a pause for 2 sec when the
match is highlighted?

Message #25 received at 3950 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Guido Van Hoecke <gnuemacs <at> vanhoecke.org>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: Guido Van Hoecke <gnuemacs <at> vanhoecke.org>, 3950 <at> debbugs.gnu.org,
        Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#3950: 23.0.91; hs-minor-mode should obey hs-search-mode for
 viper searches too
Date: Wed, 29 Jul 2009 08:20:51 +0200

Lennart Borgman wrote:
> On Tue, Jul 28, 2009 at 5:28 PM, Guido Van Hoecke<gnuemacs <at> vanhoecke.org> wrote:
> 
>>> You might want to try reveal-mode as well (don't know if it works with
>>> Viper's search, but it might, and if not, it's also a bug).
>> I didn't know reveal-mode, shame on me!
>>
>> Thanks Stefan, both for having written it and for pointing my nose in
>> the proper direction! It works with viper's search, so no bug there!
>>
>> The cursor sits on the ... for about 2 seconds, and than the fold
>> opens. Is there some kind of (configurable) time-out before the fold
>> opens?
> 
> I think that is a Viper thing. Isn't there a pause for 2 sec when the
> match is highlighted?

I would not know. Did not find anything about such a pause or delay in
the info files nor in viper customization.

Guivho.

Message #30 received at 3950 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: Guido Van Hoecke <gnuemacs <at> vanhoecke.org>
Cc: 3950 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#3950: 23.0.91; hs-minor-mode should obey hs-search-mode for 
	viper searches too
Date: Wed, 29 Jul 2009 11:39:47 +0200

On Wed, Jul 29, 2009 at 8:20 AM, Guido Van Hoecke<gnuemacs <at> vanhoecke.org> wrote:
> Lennart Borgman wrote:
>> On Tue, Jul 28, 2009 at 5:28 PM, Guido Van Hoecke<gnuemacs <at> vanhoecke.org> wrote:
>>
>>>> You might want to try reveal-mode as well (don't know if it works with
>>>> Viper's search, but it might, and if not, it's also a bug).
>>> I didn't know reveal-mode, shame on me!
>>>
>>> Thanks Stefan, both for having written it and for pointing my nose in
>>> the proper direction! It works with viper's search, so no bug there!
>>>
>>> The cursor sits on the ... for about 2 seconds, and than the fold
>>> opens. Is there some kind of (configurable) time-out before the fold
>>> opens?
>>
>> I think that is a Viper thing. Isn't there a pause for 2 sec when the
>> match is highlighted?
>
> I would not know. Did not find anything about such a pause or delay in
> the info files nor in viper customization.

You are right. It is not possible ot customize this. I looked at the
sources for Viper and it is actually hard coded. There are a lot of
calls to (sit-for 2).

Message #37 received at 3950 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 3950 <at> debbugs.gnu.org, Guido Van Hoecke <gnuemacs <at> vanhoecke.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#3950: 23.0.91; hs-minor-mode should obey hs-search-mode for
 viper searches too
Date: Sun, 23 Mar 2025 12:02:08 -0300

Guido Van Hoecke <gnuemacs <at> vanhoecke.org> writes:

> Stefan Monnier wrote:
>>> Right now, I must open the fold ('hs-toggle-hiding') and search again
>>> ('viper-search-next') if I want to position point at the searched
>>> text. I feel that this should be automated as it is done for
>>> 'isearch'.
>>
>> You might want to try reveal-mode as well (don't know if it works with
>> Viper's search, but it might, and if not, it's also a bug).
>
> I didn't know reveal-mode, shame on me!
>
> Thanks Stefan, both for having written it and for pointing my nose in
> the proper direction! It works with viper's search, so no bug there!
>

I took a look at this bug report, but I'm not sure what should be done
about it.

Looking at viper-search, it doesn't support the search-invisible option.
I guess we could add support for that option, considering it as an
extension, reusing the isearch code for opening/closing overlays.  But,
at that point, there's not much difference between viper-search and
viper-isearch-{forward,backward}.

Any opinions? My feeling that it's still OK to add the support for
search-invisible, but since I never use viper, I can't be sure.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.