GNU bug report logs - #3949
23.1.50; C-x 0 should go to a sister window if possible

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3949 in the body.
You can then email your comments to 3949 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.1.50; C-x 0 should go to a sister window if possible
Date: Mon, 27 Jul 2009 18:42:39 +0200

I can't think of any situation where I do not want that.


In GNU Emacs 23.1.50.1 (i386-mingw-nt5.1.2600)
 of 2009-06-30
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4) --no-opt --cflags
-Ic:/g/include -fno-crossjumping'

Message #10 received at 3949 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lennart Borgman <lennart.borgman <at> gmail.com>,
        3949 <at> debbugs.gnu.org
Subject: Re: bug#3949: 23.1.50; C-x 0 should go to a sister window if possible
Date: Mon, 27 Jul 2009 20:05:08 +0200

> I can't think of any situation where I do not want that.

I suppose you refer to configurations like

 -------
| 1 | 2 |
|-------|
|   3   |
 -------

and you do C-x 0 in 1 ending up in 3 or in 3 ending up in 2.

It happens because `delete-window' selects the previous window of the
selected one which is usually also the one that gets enlarged.  You'd
probably prefer C-x 0 in 1 end up in 2 and when in 3 end up in 1.  This
could be done but I'm not sure whether this was a great annoyance over
the years in order to warrant such a change.

martin

Message #15 received at 3949 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 3949 <at> debbugs.gnu.org
Subject: Re: bug#3949: 23.1.50; C-x 0 should go to a sister window if possible
Date: Mon, 27 Jul 2009 20:49:03 +0200

On Mon, Jul 27, 2009 at 8:05 PM, martin rudalics<rudalics <at> gmx.at> wrote:
>> I can't think of any situation where I do not want that.
>
> I suppose you refer to configurations like
>
>  -------
> | 1 | 2 |
> |-------|
> |   3   |
>  -------
>
> and you do C-x 0 in 1 ending up in 3

This is the case I that I find surprising. And I can't figure out what
the algorithm is - it does not go to the previous window. At least not
after

   C-x 1
   C-x 3
   windmove-right
   C-x 2
   windmove-down
   C-x 0

For me it stops in the left window, not the right as I expect.


> or in 3 ending up in 2.

In this case the current default (which I suppose is going to the
previous window ...) should be fine.


> It happens because `delete-window' selects the previous window of the
> selected one which is usually also the one that gets enlarged.  You'd
> probably prefer C-x 0 in 1 end up in 2 and when in 3 end up in 1.  This
> could be done but I'm not sure whether this was a great annoyance over
> the years in order to warrant such a change.
>
> martin
>

Message #20 received at 3949 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Lennart Borgman <lennart.borgman <at> gmail.com>
Cc: 3949 <at> debbugs.gnu.org
Subject: Re: bug#3949: 23.1.50; C-x 0 should go to a sister window if possible
Date: Tue, 28 Jul 2009 09:39:52 +0200

>    C-x 1
>    C-x 3
>    windmove-right
>    C-x 2
>    windmove-down
>    C-x 0
>
> For me it stops in the left window, not the right as I expect.

Looks like a bug indeed.  It behaves this way in the current trunk but
doesn't so in my Emacs.  I'll have to look into this.

martin

Message #25 received at 3949 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: martin rudalics <rudalics <at> gmx.at>, 3949 <at> debbugs.gnu.org
Cc: Lennart Borgman <lennart.borgman <at> gmail.com>
Subject: Re: bug#3949: 23.1.50; C-x 0 should go to a sister window if possible
Date: Sat, 01 Aug 2009 15:12:28 +0200

[Message part 1 (text/plain, inline)]

>  >    C-x 1
>  >    C-x 3
>  >    windmove-right
>  >    C-x 2
>  >    windmove-down
>  >    C-x 0
>  >
>  > For me it stops in the left window, not the right as I expect.
>
> Looks like a bug indeed.  It behaves this way in the current trunk but
> doesn't so in my Emacs.  I'll have to look into this.

OK the problem is with the following assignment in delete_window:

	/* Otherwise, try another window for SWINDOW.  */
	swindow = Fnext_window (swindow, Qlambda, Qnil);

This will fail to pick a useful window when deleting the bottom-right
window of a frame.  I use

	/* Otherwise, try another window for SWINDOW.  */
	swindow = Fprevious_window (swindow, Qlambda, Qnil);

which is better for me but fails miserably when deleting the
top-left window of a frame.  So maybe we need something like the
attached patch.  Could you try it?

martin

[window.c.diff (text/plain, inline)]

*** window.c.~1.639.~	2009-07-04 17:09:38.265625000 +0200
--- window.c	2009-08-01 15:06:48.906250000 +0200
***************
*** 1596,1602 ****
  	if (!EQ (window, pwindow))
  	  break;
  	/* Otherwise, try another window for SWINDOW.  */
! 	swindow = Fnext_window (swindow, Qlambda, Qnil);
  
  	/* If we get back to the frame's selected window,
  	   it means there was no acceptable alternative,
--- 1596,1605 ----
  	if (!EQ (window, pwindow))
  	  break;
  	/* Otherwise, try another window for SWINDOW.  */
! 	if (NILP (XWINDOW (swindow)->prev))
! 	  swindow = Fnext_window (swindow, Qlambda, Qnil);
! 	else
! 	  swindow = Fprevious_window (swindow, Qlambda, Qnil);
  
  	/* If we get back to the frame's selected window,
  	   it means there was no acceptable alternative,

Message #30 received at 3949-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: 3949-done <at> debbugs.gnu.org
Subject: Re: bug#3949: 23.1.50; C-x 0 should go to a sister window if possible
Date: Mon, 05 Sep 2011 10:38:56 +0200

> I can't think of any situation where I do not want that.

The window selected now is the most recently used one.

Closed, martin.

Message #33 received at 3949 <at> debbugs.gnu.org (full text, mbox):

From: Lennart Borgman <lennart.borgman <at> gmail.com>
To: 3949 <at> debbugs.gnu.org, rudalics <at> gmx.at
Cc: 3949-done <at> debbugs.gnu.org
Subject: Re: bug#3949: 23.1.50; C-x 0 should go to a sister window if possible
Date: Mon, 5 Sep 2011 14:36:29 +0200

On Mon, Sep 5, 2011 at 10:38, martin rudalics <rudalics <at> gmx.at> wrote:
>> I can't think of any situation where I do not want that.
>
> The window selected now is the most recently used one.
>
> Closed, martin.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.