GNU bug report logs - #35123
[PATCH] Use lexical-binding in bug-reference

Previous Next

Full log

View this message in rfc822 format

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 35123 <at> debbugs.gnu.org
Subject: bug#35123: [PATCH] Use lexical-binding in bug-reference
Date: Wed, 03 Apr 2019 17:42:31 +0100

Alex Branham <alex.branham <at> gmail.com> writes:

> diff --git a/.dir-locals.el b/.dir-locals.el
> index 9cd39920c2..506edfcf73 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,6 +1,7 @@
>  ((nil . ((tab-width . 8)
>           (sentence-end-double-space . t)
> -         (fill-column . 70)))
> +         (fill-column . 70)
> +         (bug-reference-url-format . "https://debbugs.gnu.org/%s")))
>   (c-mode . ((c-file-style . "GNU")
>              (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK"))
>              (electric-quote-comment . nil)
> @@ -12,7 +13,6 @@
>                     (log-edit-setup-add-author . t)))
>   (change-log-mode . ((add-log-time-zone-rule . t)
>  		     (fill-column . 74)
> -		     (bug-reference-url-format . "https://debbugs.gnu.org/%s")
>  		     (mode . bug-reference)))
>   (diff-mode . ((mode . whitespace)))
>   (emacs-lisp-mode . ((indent-tabs-mode . nil)

While you're at it, why not also change (mode . bug-reference)
to (eval . (bug-reference-mode)) as per the recommended way to enable
minor modes described in (info "(emacs) Specifying File Variables")?

Apart from that, and FWIW, LGTM.

Thanks,

-- 
Basil

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.