GNU bug report logs - #35123
[PATCH] Use lexical-binding in bug-reference

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35123 in the body.
You can then email your comments to 35123 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Use lexical-binding in bug-reference
Date: Wed, 03 Apr 2019 09:40:59 -0500

[Message part 1 (text/plain, inline)]

Hi -

The attached patch switches bug-reference.el to use lexical binding.
There don't appear to be any tests for bug-reference, but I've tested it
locally and everything seems to work just fine. The patch also updates
.dir-locals so that bug-reference-url-format is set in all modes, not
just changelog mode. This helps users who e.g. use magit. Arguably that
should be two commits. Just let me know if you'd prefer that and I can
split it out.

Thanks,
Alex

[0001-Use-lexical-binding-in-bug-reference.el.patch (text/x-patch, attachment)]

Message #8 received at 35123 <at> debbugs.gnu.org (full text, mbox):

From: "Basil L. Contovounesios" <contovob <at> tcd.ie>
To: Alex Branham <alex.branham <at> gmail.com>
Cc: 35123 <at> debbugs.gnu.org
Subject: Re: bug#35123: [PATCH] Use lexical-binding in bug-reference
Date: Wed, 03 Apr 2019 17:42:31 +0100

Alex Branham <alex.branham <at> gmail.com> writes:

> diff --git a/.dir-locals.el b/.dir-locals.el
> index 9cd39920c2..506edfcf73 100644
> --- a/.dir-locals.el
> +++ b/.dir-locals.el
> @@ -1,6 +1,7 @@
>  ((nil . ((tab-width . 8)
>           (sentence-end-double-space . t)
> -         (fill-column . 70)))
> +         (fill-column . 70)
> +         (bug-reference-url-format . "https://debbugs.gnu.org/%s")))
>   (c-mode . ((c-file-style . "GNU")
>              (c-noise-macro-names . ("INLINE" "ATTRIBUTE_NO_SANITIZE_UNDEFINED" "UNINIT" "CALLBACK" "ALIGN_STACK"))
>              (electric-quote-comment . nil)
> @@ -12,7 +13,6 @@
>                     (log-edit-setup-add-author . t)))
>   (change-log-mode . ((add-log-time-zone-rule . t)
>  		     (fill-column . 74)
> -		     (bug-reference-url-format . "https://debbugs.gnu.org/%s")
>  		     (mode . bug-reference)))
>   (diff-mode . ((mode . whitespace)))
>   (emacs-lisp-mode . ((indent-tabs-mode . nil)

While you're at it, why not also change (mode . bug-reference)
to (eval . (bug-reference-mode)) as per the recommended way to enable
minor modes described in (info "(emacs) Specifying File Variables")?

Apart from that, and FWIW, LGTM.

Thanks,

-- 
Basil

Message #11 received at 35123 <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35123 <at> debbugs.gnu.org
Subject: Re: bug#35123: [PATCH] Use lexical-binding in bug-reference
Date: Thu, 04 Apr 2019 09:33:53 -0500

On Wed 03 Apr 2019 at 11:42, Basil L. Contovounesios <contovob <at> tcd.ie> wrote:

> While you're at it, why not also change (mode . bug-reference)
> to (eval . (bug-reference-mode)) as per the recommended way to enable
> minor modes described in (info "(emacs) Specifying File Variables")?

Sure, I can update that too.

Thanks,
Alex

Message #16 received at 35123-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Branham <alex.branham <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35123-done <at> debbugs.gnu.org
Subject: Re: bug#35123: [PATCH] Use lexical-binding in bug-reference
Date: Tue, 09 Apr 2019 16:31:12 -0500

Pushed as commit d96b672f2b738bb6364023c2dcb9111efd3855ed to appear in Emacs 27.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.