GNU bug report logs - #35124
26.1; ada-mode 6.1.0 no longer syntax-highlights package names at end of spec

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 35124 in the body.
You can then email your comments to 35124 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Brenta <ludovic <at> ludovic-brenta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.1; ada-mode 6.1.0 no longer syntax-highlights package names at end
 of spec
Date: Wed, 03 Apr 2019 18:05:17 +0200

X-Debbugs-CC: ada-mode-users <at> nongnu.org
Package: emacs, ada-mode
Version: 26.1
Severity: minor

If you load a file consisting of these three lines:

package Foo is
   procedure P;
end Foo;

then the second "Foo" is not syntax-highlighted.  If
you then remove the "procedure P", the second Foo is
highlighted properly.

This micro-bug is triggered only when
wisi-partial-parse-threshold is less than the size of
the buffer (i.e. it is zero).

-- 
Ludovic Brenta.

Message #8 received at 35124 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: Ludovic Brenta <ludovic <at> ludovic-brenta.org>
Cc: 35124 <at> debbugs.gnu.org, ada-mode-users <at> nongnu.org
Subject: Re: bug#35124: 26.1;
 ada-mode 6.1.0 no longer syntax-highlights package names at end of
 spec
Date: Fri, 24 May 2019 08:49:55 -0800

Ludovic Brenta <ludovic <at> ludovic-brenta.org> writes:

> If you load a file consisting of these three lines:
>
> package Foo is
>    procedure P;
> end Foo;
>
> then the second "Foo" is not syntax-highlighted.  

I can't reproduce this with this small file; font-lock requests that the
entire buffer be parsed, so it is done correctly. With a larger file, so
the start of the package is farther away than the default font-lock
chunk size, the final package name is not highlighted.

This is because the 'end Foo;' is extra text at the end of the partial
parse, and the error recovery inserts 'begin', leaving a labeled block,
in which the label is not highlighted.

If the name has a '.', then it can't be a block label, and it might be
possible to convince the error recovery to insert "package <identifier>
is begin" instead; I'll work on that.

-- 
-- Stephe

Message #13 received at 35124-close <at> debbugs.gnu.org (full text, mbox):

From: Stephen Leake <stephen_leake <at> stephe-leake.org>
To: 35124-close <at> debbugs.gnu.org
Subject: close
Date: Sat, 17 Aug 2019 16:27:17 -0700

-- 
-- Stephe

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.