GNU bug report logs - #35123
[PATCH] Use lexical-binding in bug-reference

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex Branham <alex.branham <at> gmail.com>
Subject: bug#35123: closed (Re: bug#35123: [PATCH] Use lexical-binding in
 bug-reference)
Date: Tue, 09 Apr 2019 21:32:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#35123: [PATCH] Use lexical-binding in bug-reference

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 35123 <at> debbugs.gnu.org.

-- 
35123: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=35123
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: "Basil L. Contovounesios" <contovob <at> tcd.ie>
Cc: 35123-done <at> debbugs.gnu.org
Subject: Re: bug#35123: [PATCH] Use lexical-binding in bug-reference
Date: Tue, 09 Apr 2019 16:31:12 -0500

Pushed as commit d96b672f2b738bb6364023c2dcb9111efd3855ed to appear in Emacs 27.1

[Message part 3 (message/rfc822, inline)]

From: Alex Branham <alex.branham <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Use lexical-binding in bug-reference
Date: Wed, 03 Apr 2019 09:40:59 -0500

[Message part 4 (text/plain, inline)]

Hi -

The attached patch switches bug-reference.el to use lexical binding.
There don't appear to be any tests for bug-reference, but I've tested it
locally and everything seems to work just fine. The patch also updates
.dir-locals so that bug-reference-url-format is set in all modes, not
just changelog mode. This helps users who e.g. use magit. Arguably that
should be two commits. Just let me know if you'd prefer that and I can
split it out.

Thanks,
Alex

[0001-Use-lexical-binding-in-bug-reference.el.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.