GNU bug report logs - #3430
23.0.94; cannot enable two minor modes in .dir-locals.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3430 in the body.
You can then email your comments to 3430 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Sun, 31 May 2009 15:37:59 +0100

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

My LaTeX project setting looks like this:

((latex-mode . ((auto-fill-function . nil)
                (fill-column . 90)
                (mode . outline-minor)
                (mode . longlines)
                (coding . "latin-1"))))

i.e. I want to enable two minor modes for all .TeX files among other
things.

I start with Emacs -q and open a .TeX in that project, only longlines is
enabled. Do you think this is a bug? Thank you.

This is tested on GNU Emacs 23.0.94.1 (i386-apple-darwin9.7.0, NS
apple-appkit-949.46) of 2009-05-23 on 200.sub-75-216-116.myvzw.com

Leo

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 3430 <at> debbugs.gnu.org
Cc: emacs-pretest-bug <at> gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Tue, 02 Jun 2009 22:29:44 +0100

On 2009-05-31 15:37 +0100, Leo wrote:
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:
>
> My LaTeX project setting looks like this:
>
> ((latex-mode . ((auto-fill-function . nil)
>                 (fill-column . 90)
>                 (mode . outline-minor)
>                 (mode . longlines)
>                 (coding . "latin-1"))))
>
> i.e. I want to enable two minor modes for all .TeX files among other
> things.
>
> I start with Emacs -q and open a .TeX in that project, only longlines is
> enabled. Do you think this is a bug? Thank you.
>
> This is tested on GNU Emacs 23.0.94.1 (i386-apple-darwin9.7.0, NS
> apple-appkit-949.46) of 2009-05-23 on 200.sub-75-216-116.myvzw.com
>
> Leo

Any comment on this bug? Can you reproduce it? Thank you.

Leo

Message #20 received at 3430 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: Leo <sdl.web <at> gmail.com>
Cc: 3430 <at> debbugs.gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Mon, 15 Jun 2009 20:26:28 +0300

On 2009-06-02 22:29 (+0100), Leo wrote:

> On 2009-05-31 15:37 +0100, Leo wrote:
>> Please describe exactly what actions triggered the bug
>> and the precise symptoms of the bug:
>>
>> My LaTeX project setting looks like this:
>>
>> ((latex-mode . ((auto-fill-function . nil)
>>                 (fill-column . 90)
>>                 (mode . outline-minor)
>>                 (mode . longlines)
>>                 (coding . "latin-1"))))
>>
>> i.e. I want to enable two minor modes for all .TeX files among other
>> things.
>>
>> I start with Emacs -q and open a .TeX in that project, only longlines is
>> enabled. Do you think this is a bug? Thank you.
>>
>> This is tested on GNU Emacs 23.0.94.1 (i386-apple-darwin9.7.0, NS
>> apple-appkit-949.46) of 2009-05-23 on 200.sub-75-216-116.myvzw.com
>>
>> Leo
>
> Any comment on this bug? Can you reproduce it? Thank you.

I can reproduce this. Just create a file .dir-locals.el somewhere with
content like this:

    ((nil . ((mode . auto-fill)
             (mode . outline-minor))))

When files in that directory are opened only the last mode
(outline-minor) in the alist is turned on.

A side note: It seems that directory local variables feature is still in
a half-finished shape:

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1986
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3572
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3577

Message #23 received at 3430 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm+emacsbugs <at> gnu.org>
To: 3430 <at> debbugs.gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Wed, 17 Jun 2009 20:42:53 -0400

tags 2355
merge 2355 3430
stop

I should imagine this is the same issue as bug #2355.

Message #30 received at 3430 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Glenn Morris <rgm+emacsbugs <at> gnu.org>
Cc: 3430 <at> debbugs.gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Thu, 18 Jun 2009 02:40:33 +0100

On 2009-06-18 01:42 +0100, Glenn Morris wrote:
> tags 2355
> merge 2355 3430
> stop
>
> I should imagine this is the same issue as bug #2355.

Are you sure they are the same? If you put two minor modes at the end of
a file in the local variables section, it works without any problem.

-- 
Leo's Emacs uptime: 7 days, 12 hours, 0 minutes, 36 seconds

Message #35 received at 3430 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm+emacsbugs <at> gnu.org>
To: 3430 <at> debbugs.gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Wed, 17 Jun 2009 22:29:42 -0400

tags 2355 =
unmerge 3430
stop

Leo wrote (on Thu, 18 Jun 2009 at 02:40 +0100):

> Are you sure they are the same? If you put two minor modes at the end of
> a file in the local variables section, it works without any problem.

OK; unimagining, this is because dir-locals-collect-mode-variables has
the effect of filtering the dir-locals variables list so that only one
value is allowed for any given key, and the last one wins.

Message #42 received at 3430 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3430 <at> debbugs.gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Wed, 17 Jun 2009 22:40:26 -0400

Possible hack follows, but I don't know what the point of the
dir-locals-collect-mode-variables function is supposed to be (an
optimization to avoid settings things twice?).

***************
*** 3213,3219 ****
      (let* ((variable (car pair))
       (value (cdr pair))
       (slot (assq variable variables)))
!       (if slot
      (setcdr slot value)
    ;; Need a new cons in case we setcdr later.
    (push (cons variable value) variables)))))
--- 3214,3222 ----
      (let* ((variable (car pair))
       (value (cdr pair))
       (slot (assq variable variables)))
!       ;; If variables are specified more than once, only use the last.
!       ;; But any number of `modes' (assumed to be minor) are allowed.
!       (if (and slot (not (eq variable 'mode)))
      (setcdr slot value)
    ;; Need a new cons in case we setcdr later.
    (push (cons variable value) variables)))))

Message #47 received at 3430 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Glenn Morris <rgm+emacsbugs <at> gnu.org>
Cc: 3430 <at> debbugs.gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Thu, 18 Jun 2009 11:38:48 +0100

On 2009-06-18 03:29 +0100, Glenn Morris wrote:
>> Are you sure they are the same? If you put two minor modes at the end of
>> a file in the local variables section, it works without any problem.
>
> OK; unimagining, this is because dir-locals-collect-mode-variables has
> the effect of filtering the dir-locals variables list so that only one
> value is allowed for any given key, and the last one wins.

Thank you for your interest and attempt in fixing this bug.

It seems to me that is done in dir-locals-collect-variables. Filtering
out the duplications is fine for variables that can only have one value
but not all variables fall into that. For example, there is 'mode' and
'eval' and possibly others.

-- 
Leo's Emacs uptime: 7 days, 20 hours, 41 minutes, 23 seconds

Message #52 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Thu, 18 Jun 2009 11:43:19 +0100

On 2009-06-18 03:40 +0100, Glenn Morris wrote:
> Possible hack follows, but I don't know what the point of the
> dir-locals-collect-mode-variables function is supposed to be (an
> optimization to avoid settings things twice?).

I hope a fix is reached soonish. Thank you.

-- 
Leo's Emacs uptime: 7 days, 21 hours, 0 minutes, 50 seconds

Message #57 received at 3430-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3430-done <at> debbugs.gnu.org
Subject: Re: bug#3430: 23.0.94; cannot enable two minor modes in .dir-locals.el
Date: Mon, 22 Jun 2009 03:02:45 -0400

Fixed in trunk for 23.2

      * files.el (dir-locals-collect-mode-variables): Allow for any
        number of `mode' and `eval' entries.  (Bug#3430)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.