GNU bug report logs - #3429
23.0.91; solar.el: solar seasons variable should not be a constant

Previous Next

Package: emacs;

Reported by: Teemu Likonen <tlikonen <at> iki.fi>

Date: Sun, 31 May 2009 14:00:04 UTC

Severity: normal

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3429 in the body.
You can then email your comments to 3429 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#3429; Package emacs. (Sun, 31 May 2009 14:00:04 GMT) Full text and rfc822 format available.
Acknowledgement sent to Teemu Likonen <tlikonen <at> iki.fi>:
New bug report received and forwarded. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Sun, 31 May 2009 14:00:04 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: emacs-pretest-bug <at> gnu.org
Cc: rfrancoise <at> debian.org
Subject: 23.0.91; solar.el: solar seasons variable should not be a constant
Date: Sun, 31 May 2009 16:58:26 +0300

This commit made solar-?-hemi-seasons constants:

    commit 7ac202f6ec47df634066e61cc4cf17705257d9dc
    Author: Glenn Morris <rgm <at> gnu.org>
    Date:   2008-03-15 02:55:06 +0000

        (solar-n-hemi-seasons, solar-s-hemi-seasons): Make constants.
        (solar-sunrise-sunset): Rename some local variables for clarity.
        (sunrise-sunset): Use zerop.
        (solar-mean-equinoxes/solstices): Doc fix.

What is the rationale for that? They were defvars before.

As the doc of "defconst" says "The intent is that neither programs nor
users should ever change this value." Having solar seasons constants is
not sensible because it's very useful to localize the solar seasons'
names, and I'm trying to do exactly that with my Finnish localized
holidays:

    http://www.emacswiki.org/emacs/suomalainen-kalenteri.el

Yes, I can localize solar season by putting this in my ~/.emacs:

    (eval-after-load 'solar
      '(setq solar-n-hemi-seasons '("Kevätpäiväntasaus" "Kesäpäivänseisaus"
                                    "Syyspäiväntasaus" "Talvipäivänseisaus")
             solar-s-hemi-seasons '("Syyspäiväntasaus" "Talvipäivänseisaus"
                                    "Kevätpäiväntasaus" "Kesäpäivänseisaus")))

But this is not nice and it's difficult for external packages to
localize those variables.

I'd suggest making them defvas again (or defcustoms).
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Thu, 04 Jun 2009 06:45:04 GMT) Full text and rfc822 format available.
Notification sent to Teemu Likonen <tlikonen <at> iki.fi>:
bug acknowledged by developer. (Thu, 04 Jun 2009 06:45:04 GMT) Full text and rfc822 format available.

Message #10 received at 3429-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 3429-done <at> debbugs.gnu.org
Subject: Re: bug#3429: 23.0.91; solar.el: solar seasons variable should not be a constant
Date: Thu, 04 Jun 2009 02:39:10 -0400

OK, it's a defcustom.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> emacsbugs.donarmstrong.com. (Thu, 02 Jul 2009 14:24:18 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 359 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.