GNU bug report logs - #33217
Adding r-weights patch file

Previous Next

Full log

Message #34 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Thu, 8 Nov 2018 20:35:00 +0100

[Message part 1 (text/plain, inline)]

I used the version where the most things were fixed, applied it to the
commit in Björn's message, created a branch, rebased on current master,
then fixed the commit message using amend, signed off and pushed. There is
no additional thing to do.

2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
lakshmiprasannakumaran <at> gmail.com> ezt írta:

> Hi Gábor,
>
> I am extremely sorry that , I did miss out this mail. I would like to know
> , if there is anything more that I need to do on r-weights package
> addition.
> If not could you tell me how you fixed this to do the final commit ?
>
> Thanks,
>
> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits <at> gmail.com wrote:
>
>> Hello Lakshmi,
>>
>> It would be nice if you could give this another shot, if not I will
>> commit it tomorrow with
>> some minor changes.
>>
>> The commit message seems to be missing the second line (what has changed).
>>
>> The license field still misses the prefix. See the mail from Björn
>> earlier.
>>
>> Could you squash your changes to a single commit?
>>
>> (You can either do this on a throw-away branch with a git merge --squash,
>> or
>> you can use git rebase -i, see this for more info
>>
>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>> .)
>>
>> Best regards,
>> g_bor
>>
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.