GNU bug report logs - #33214
Patch file for weight package

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33214 in the body.
You can then email your comments to 33214 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Patch file for weight package
Date: Wed, 31 Oct 2018 10:08:07 +0530

[Message part 1 (text/plain, inline)]

Hi,

Please find the attached patch file for adding weight package from cran
repository.

Thanks,
Lakshmi Prasannakumar
Bangalore

[Message part 2 (text/html, inline)]

[0001-Adding-the-package-weights-for-using-weighted-statis.patch (text/x-patch, attachment)]

Message #8 received at 33214 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33214 <at> debbugs.gnu.org
Subject: Re: Patch Tracker no. 33214
Date: Wed, 31 Oct 2018 11:18:53 +0100

Hello Laksmi,

Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> ezt írta
(időpont: 2018. okt. 31., Sze, 10:30):
>
> Hi Gábor,
>
> I'm sending an email with the tracker no. cc-ing both of you. This is the number I received from the bug tracker. Below is the link from the bug tracker.
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33214
>

Thanks for the tracker id. I did not find it because I was looking in
a slightly wrong way (I was looking for r-weight) :)

In guix, there is a convention on the commit messages, you can see it
in git log, it is also
documented in the coding conventions.

In this case it should look something like this:

gnu: Add r-weight.

* gnu/packages/cran.scm (r-weight): New variable.

You can modify the commit message using git commit --amend, then
create a new patch and send that.

I will test this package, and report back later.



> Do let me know if I need to commit again and create a patch file, as this was the first time I committed, I'm not completely sure if it was right or not.
>
> Thanks,
> Lakshmi Prasannakumar
> Bangalore

Message #11 received at 33214 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: 33214 <at> debbugs.gnu.org
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 Gábor Boskovits <boskovits <at> gmail.com>
Subject: Patch Tracker no. 33214
Date: Wed, 31 Oct 2018 14:59:51 +0530

[Message part 1 (text/plain, inline)]

Hi Gábor,

I'm sending an email with the tracker no. cc-ing both of you. This is the
number I received from the bug tracker. Below is the link from the bug
tracker.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=33214

Do let me know if I need to commit again and create a patch file, as this
was the first time I committed, I'm not completely sure if it was right or
not.

Thanks,
Lakshmi Prasannakumar
Bangalore

[Message part 2 (text/html, inline)]

Message #16 received at 33214 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: 33214 <at> debbugs.gnu.org
Subject: Modifying the commit message to gnu-Add-r-weights
Date: Thu, 1 Nov 2018 14:46:34 +0530

[Message part 1 (text/plain, inline)]

Hi,
Please find the attached patch file with this mail.
The changes made are to the cran.scm
* gnu/packages/cran.scm (r-weights): New variable.

Thanks,
Lakshmi Prasannakumar
Bangalore

[Message part 2 (text/html, inline)]

[0001-gnu-Add-r-weights.patch (text/x-patch, attachment)]

Message #19 received at 33214 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Gábor Boskovits <boskovits <at> gmail.com>, 33214 <at> debbugs.gnu.org
Subject: Re: Video Documentation for GNU GUIX (an Outreachy project)
Date: Fri, 2 Nov 2018 14:31:54 +0100

[Message part 1 (text/plain, inline)]

Hi Lakshmi,

On Fri, 2 Nov 2018 18:25:49 +0530
Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:

> Sure, I'll rebase it to the current master and try to bring in the
> change for commit message .
> 
> Regards,
> 

(For the reference, applied it on top of
7b63047c943a68717b1fc21dc078e44c2415e694 where it applies without trouble).

I have some more remarks:

* Could you please keep the bug-tracker on CC. In that way other people
can follow the discussions and it is saved for later reference. That is
especially useful if the patch gets forgotten and is only later being
picked up again (though I don't think that will be the case here):

33214 <at> debbugs.gnu.org

* As Gabor already said, the period "." was missing. See other commit
messages to get used to the strict rules.

* License field should look like this:

  (license license:gpl2+)))

I.e. it is prefixed  by "license:". That is because in line 31 the
license module was imported with that prefix:

  #:use-module ((guix licenses) #:prefix license:)

Some package modules use this syntax to prevent namespace pollution,
others not.

* Did you execute `guix lint` before submitting the patch? I have
found some linter complaints:

/home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights <at> 1.0: sentences in description should be followed by two spaces; possible infractions at 197, 389
/home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights <at> 1.0: line 6671 is way too long (468 characters)

* The first one just means what it says. That is because the
descriptions use texinfo syntax and there are two spaces used.

* The second can be solved by breaking long lines of the description
before 80 characters. See how it was done in other packages above.

* Homepage:

gnu/packages/cran.scm:6652:0: r-weights <at> 1.0: permanent redirect 
from http://cran.r-project.org/web/packages/weights 
to   http://cran.r-project.org/web/packages/weights/

So please add a trailing "/" to the URL.

Also could you use "https"? instead of just plain "http"? We use the
encrypted URL wherever it is available.

* I'm currently trying to build it but that looks like it takes more
time than usual because substitutes are missing. If anything goes
wrong, I will report back. Did you try to build the package?

Thank you,

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #22 received at 33214 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>,
 33214 <at> debbugs.gnu.org
Subject: Re: Video Documentation for GNU GUIX (an Outreachy project)
Date: Fri, 2 Nov 2018 15:23:04 +0100

Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> ezt írta (időpont:
2018. nov. 2., P, 14:31):
>
> Hi Lakshmi,
>
> On Fri, 2 Nov 2018 18:25:49 +0530
> Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:
>
> > Sure, I'll rebase it to the current master and try to bring in the
> > change for commit message .
> >
> > Regards,
> >
>
> (For the reference, applied it on top of
> 7b63047c943a68717b1fc21dc078e44c2415e694 where it applies without trouble).
>
> I have some more remarks:
>
> * Could you please keep the bug-tracker on CC. In that way other people
> can follow the discussions and it is saved for later reference. That is
> especially useful if the patch gets forgotten and is only later being
> picked up again (though I don't think that will be the case here):
>
> 33214 <at> debbugs.gnu.org
>
> * As Gabor already said, the period "." was missing. See other commit
> messages to get used to the strict rules.
>
> * License field should look like this:
>
>   (license license:gpl2+)))
>
> I.e. it is prefixed  by "license:". That is because in line 31 the
> license module was imported with that prefix:
>
>   #:use-module ((guix licenses) #:prefix license:)
>
> Some package modules use this syntax to prevent namespace pollution,
> others not.
>
> * Did you execute `guix lint` before submitting the patch? I have
> found some linter complaints:
>
> /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights <at> 1.0: sentences in description should be followed by two spaces; possible infractions at 197, 389
> /home/bjoern/guix/guix/gnu/packages/cran.scm:6652:0: r-weights <at> 1.0: line 6671 is way too long (468 characters)
>
> * The first one just means what it says. That is because the
> descriptions use texinfo syntax and there are two spaces used.
>
> * The second can be solved by breaking long lines of the description
> before 80 characters. See how it was done in other packages above.
>
> * Homepage:
>
> gnu/packages/cran.scm:6652:0: r-weights <at> 1.0: permanent redirect
> from http://cran.r-project.org/web/packages/weights
> to   http://cran.r-project.org/web/packages/weights/
>
> So please add a trailing "/" to the URL.
>
> Also could you use "https"? instead of just plain "http"? We use the
> encrypted URL wherever it is available.
>

Thanks Björn. It seems that currently Lakshmi has no working
guix, because of problems related to missing substiutes.

> * I'm currently trying to build it but that looks like it takes more
> time than usual because substitutes are missing. If anything goes
> wrong, I will report back. Did you try to build the package?
>
> Thank you,
>
> Björn

Message #25 received at 33214 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>,
 33214 <at> debbugs.gnu.org
Subject: Re: Video Documentation for GNU GUIX (an Outreachy project)
Date: Fri, 2 Nov 2018 17:29:03 +0100

[Message part 1 (text/plain, inline)]

Hi Lakshmi,

On Fri, 2 Nov 2018 15:23:04 +0100
Gábor Boskovits <boskovits <at> gmail.com> wrote:

> Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> ezt írta (időpont:
> 2018. nov. 2., P, 14:31):

> Thanks Björn. It seems that currently Lakshmi has no working
> guix, because of problems related to missing substiutes.
> 
> > * I'm currently trying to build it but that looks like it takes more
> > time than usual because substitutes are missing. If anything goes
> > wrong, I will report back. Did you try to build the package?

My build is finished now and it builds correctly.

Yes, due to currently missing substitutes it takes a lot of time. But
it should work also.

Björn

[Message part 2 (application/pgp-signature, inline)]

Message #28 received at 33214 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
Cc: Gábor Boskovits <boskovits <at> gmail.com>,
 33214 <at> debbugs.gnu.org
Subject: Re: Video Documentation for GNU GUIX (an Outreachy project)
Date: Sat, 3 Nov 2018 00:46:02 +0530

[Message part 1 (text/plain, inline)]

Hi Björn and Gábor,

Thank you for the comments.
Since the build isn't perfect, I am trying to install GUIX in a new system
with updated ubuntu version. Once done with this , I'll pull the latest
repository and add the package definition to the cran.scm. Later will send
across the patch file to the same bug tracker id, so that it would be in
track.

Regards,
Lakshmi Prasannakumar
Bangalore


On Fri, Nov 2, 2018 at 9:59 PM Björn Höfling <
bjoern.hoefling <at> bjoernhoefling.de> wrote:

> Hi Lakshmi,
>
> On Fri, 2 Nov 2018 15:23:04 +0100
> Gábor Boskovits <boskovits <at> gmail.com> wrote:
>
> > Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de> ezt írta (időpont:
> > 2018. nov. 2., P, 14:31):
>
> > Thanks Björn. It seems that currently Lakshmi has no working
> > guix, because of problems related to missing substiutes.
> >
> > > * I'm currently trying to build it but that looks like it takes more
> > > time than usual because substitutes are missing. If anything goes
> > > wrong, I will report back. Did you try to build the package?
>
> My build is finished now and it builds correctly.
>
> Yes, due to currently missing substitutes it takes a lot of time. But
> it should work also.
>
> Björn
>

[Message part 2 (text/html, inline)]

Message #33 received at 33214-done <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>, 
 Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>, 
 Ludovic Courtès <ludo <at> gnu.org>, 
 Ricardo Wurmus <rekado <at> elephly.net>, 33214-done <at> debbugs.gnu.org
Subject: gnu: Add r-weights.
Date: Tue, 6 Nov 2018 16:23:02 +0100

This has made to master on commit cddc0300b7fb5fbbc80f45a626073f8372bf491f.

Thanks for all the hard work!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.