GNU bug report logs - #33217
Adding r-weights patch file

Previous Next

Package: guix-patches;

Reported by: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>

Date: Wed, 31 Oct 2018 17:57:02 UTC

Severity: normal

Merged with 33214

Done: Gábor Boskovits <boskovits <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 33217 in the body.
You can then email your comments to 33217 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Wed, 31 Oct 2018 17:57:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Wed, 31 Oct 2018 17:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 Gábor Boskovits <boskovits <at> gmail.com>
Subject: Adding r-weights patch file
Date: Wed, 31 Oct 2018 22:55:06 +0530
[Message part 1 (text/plain, inline)]
Hi ,
I'm modifying the patch file name to match the coding standards and sending
it across.

Thanks,
Lakshmi Prasannakumar
Bangalore
[Message part 2 (text/html, inline)]
[0003-gnu-Add-r-weight.patch (text/x-patch, attachment)]

Merged 33214 33217. Request was from Gábor Boskovits <boskovits <at> gmail.com> to control <at> debbugs.gnu.org. (Wed, 31 Oct 2018 20:10:03 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Thu, 01 Nov 2018 18:15:01 GMT) Full text and rfc822 format available.

Message #10 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: 33217 <at> debbugs.gnu.org
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 Gábor Boskovits <boskovits <at> gmail.com>
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Thu, 1 Nov 2018 23:44:04 +0530
[Message part 1 (text/plain, inline)]
Hi,

Adding line breakers to the patch file. Please find the patch file attached
to this mail.

Thanks and Regards,
Lakshmi Prasannakumar
Bangalore


On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
lakshmiprasannakumaran <at> gmail.com> wrote:

> Hi,
> Please find the attached patch file with this mail.
> The changes made are to the cran.scm
> * gnu/packages/cran.scm (r-weights): New variable.
>
> Thanks,
> Lakshmi Prasannakumar
> Bangalore
>
[Message part 2 (text/html, inline)]
[0001-gnu-Add-r-weights.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Sun, 04 Nov 2018 16:29:01 GMT) Full text and rfc822 format available.

Message #13 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: 33217 <at> debbugs.gnu.org
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 Gábor Boskovits <boskovits <at> gmail.com>
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Sun, 4 Nov 2018 21:57:42 +0530
[Message part 1 (text/plain, inline)]
Hi,

Pushing the cran.scm file to the latest branch.
Please find the attached file.

Thanks & Regards,
Lakshmi Prasannakumar
Bangalore


On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <
lakshmiprasannakumaran <at> gmail.com> wrote:

> Hi,
>
> Adding line breakers to the patch file. Please find the patch file
> attached to this mail.
>
> Thanks and Regards,
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran <at> gmail.com> wrote:
>
>> Hi,
>> Please find the attached patch file with this mail.
>> The changes made are to the cran.scm
>> * gnu/packages/cran.scm (r-weights): New variable.
>>
>> Thanks,
>> Lakshmi Prasannakumar
>> Bangalore
>>
>
[Message part 2 (text/html, inline)]
[0003-gnu-r-weights.-Add-r-weights.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Sun, 04 Nov 2018 17:07:01 GMT) Full text and rfc822 format available.

Message #16 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Sun, 4 Nov 2018 18:05:59 +0100
Hello,

Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> ezt írta
(időpont: 2018. nov. 4., V, 17:27):
>
> Hi,
>
> Pushing the cran.scm file to the latest branch.
> Please find the attached file.
>

I got it, will have a look later.

> Thanks & Regards,
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:
>>
>> Hi,
>>
>> Adding line breakers to the patch file. Please find the patch file attached to this mail.
>>
>> Thanks and Regards,
>> Lakshmi Prasannakumar
>> Bangalore
>>
>>
>> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:
>>>
>>> Hi,
>>> Please find the attached patch file with this mail.
>>> The changes made are to the cran.scm
>>> * gnu/packages/cran.scm (r-weights): New variable.
>>>
>>> Thanks,
>>> Lakshmi Prasannakumar
>>> Bangalore

Best regards,
g_bor




Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Sun, 04 Nov 2018 21:13:02 GMT) Full text and rfc822 format available.

Message #19 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Sun, 4 Nov 2018 22:12:38 +0100
Hello Lakshmi,

There was a patch eariler in a better shape, this seems to be missing some
corrections you made earlier. Is that possible?

I intend to push a fixed version of the best patch we had so far
tomorrow, unless
I get a new version from you. WDYT?

Best regards,
g_bor
Gábor Boskovits <boskovits <at> gmail.com> ezt írta (időpont: 2018. nov.
4., V, 18:05):
>
> Hello,
>
> Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> ezt írta
> (időpont: 2018. nov. 4., V, 17:27):
> >
> > Hi,
> >
> > Pushing the cran.scm file to the latest branch.
> > Please find the attached file.
> >
>
> I got it, will have a look later.
>
> > Thanks & Regards,
> > Lakshmi Prasannakumar
> > Bangalore
> >
> >
> > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:
> >>
> >> Hi,
> >>
> >> Adding line breakers to the patch file. Please find the patch file attached to this mail.
> >>
> >> Thanks and Regards,
> >> Lakshmi Prasannakumar
> >> Bangalore
> >>
> >>
> >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:
> >>>
> >>> Hi,
> >>> Please find the attached patch file with this mail.
> >>> The changes made are to the cran.scm
> >>> * gnu/packages/cran.scm (r-weights): New variable.
> >>>
> >>> Thanks,
> >>> Lakshmi Prasannakumar
> >>> Bangalore
>
> Best regards,
> g_bor




Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Mon, 05 Nov 2018 20:42:02 GMT) Full text and rfc822 format available.

Message #22 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Tue, 6 Nov 2018 02:11:10 +0530
[Message part 1 (text/plain, inline)]
Hi Gábor,

As I pulled the latest updated version of cran.scm from git branch and
added the package definition to it, I missed to make the changes for
synopsis case. And the description went little off.
Comparing to the bug tracker, I followed the message lines and tried to
give a new message with the commit thinking it would resolve my build
issues, but I guess the format I followed was wrong again.
So, I have made the changes in cran.scm including all the corrections we
had done before and the commit message is made as the earlier version.
Sending in the updated patch file with this mail.
Kindly take a moment to review the same.

And as suggested, I have reworked on the timelines  where the videos can be
distributed.


Thanks and Regards,


Lakshmi Prasannakumar
Bangalore


On Mon, Nov 5, 2018 at 2:42 AM Gábor Boskovits <boskovits <at> gmail.com> wrote:

> Hello Lakshmi,
>
> There was a patch eariler in a better shape, this seems to be missing some
> corrections you made earlier. Is that possible?
>
> I intend to push a fixed version of the best patch we had so far
> tomorrow, unless
> I get a new version from you. WDYT?
>
> Best regards,
> g_bor
> Gábor Boskovits <boskovits <at> gmail.com> ezt írta (időpont: 2018. nov.
> 4., V, 18:05):
> >
> > Hello,
> >
> > Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> ezt írta
> > (időpont: 2018. nov. 4., V, 17:27):
> > >
> > > Hi,
> > >
> > > Pushing the cran.scm file to the latest branch.
> > > Please find the attached file.
> > >
> >
> > I got it, will have a look later.
> >
> > > Thanks & Regards,
> > > Lakshmi Prasannakumar
> > > Bangalore
> > >
> > >
> > > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran <at> gmail.com> wrote:
> > >>
> > >> Hi,
> > >>
> > >> Adding line breakers to the patch file. Please find the patch file
> attached to this mail.
> > >>
> > >> Thanks and Regards,
> > >> Lakshmi Prasannakumar
> > >> Bangalore
> > >>
> > >>
> > >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran <at> gmail.com> wrote:
> > >>>
> > >>> Hi,
> > >>> Please find the attached patch file with this mail.
> > >>> The changes made are to the cran.scm
> > >>> * gnu/packages/cran.scm (r-weights): New variable.
> > >>>
> > >>> Thanks,
> > >>> Lakshmi Prasannakumar
> > >>> Bangalore
> >
> > Best regards,
> > g_bor
>
[Message part 2 (text/html, inline)]
[0001-gnu-Add-r-weights.patch (application/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Mon, 05 Nov 2018 21:45:02 GMT) Full text and rfc822 format available.

Message #25 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Mon, 5 Nov 2018 22:43:54 +0100
Thanks, I'll take a look.
Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> ezt írta
(időpont: 2018. nov. 5., H, 21:41):
>
> Hi Gábor,
>
> As I pulled the latest updated version of cran.scm from git branch and added the package definition to it, I missed to make the changes for synopsis case. And the description went little off.
> Comparing to the bug tracker, I followed the message lines and tried to give a new message with the commit thinking it would resolve my build issues, but I guess the format I followed was wrong again.
> So, I have made the changes in cran.scm including all the corrections we had done before and the commit message is made as the earlier version.
> Sending in the updated patch file with this mail.
> Kindly take a moment to review the same.
>
> And as suggested, I have reworked on the timelines  where the videos can be distributed.
>
>
> Thanks and Regards,
>
>
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Mon, Nov 5, 2018 at 2:42 AM Gábor Boskovits <boskovits <at> gmail.com> wrote:
>>
>> Hello Lakshmi,
>>
>> There was a patch eariler in a better shape, this seems to be missing some
>> corrections you made earlier. Is that possible?
>>
>> I intend to push a fixed version of the best patch we had so far
>> tomorrow, unless
>> I get a new version from you. WDYT?
>>
>> Best regards,
>> g_bor
>> Gábor Boskovits <boskovits <at> gmail.com> ezt írta (időpont: 2018. nov.
>> 4., V, 18:05):
>> >
>> > Hello,
>> >
>> > Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> ezt írta
>> > (időpont: 2018. nov. 4., V, 17:27):
>> > >
>> > > Hi,
>> > >
>> > > Pushing the cran.scm file to the latest branch.
>> > > Please find the attached file.
>> > >
>> >
>> > I got it, will have a look later.
>> >
>> > > Thanks & Regards,
>> > > Lakshmi Prasannakumar
>> > > Bangalore
>> > >
>> > >
>> > > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:
>> > >>
>> > >> Hi,
>> > >>
>> > >> Adding line breakers to the patch file. Please find the patch file attached to this mail.
>> > >>
>> > >> Thanks and Regards,
>> > >> Lakshmi Prasannakumar
>> > >> Bangalore
>> > >>
>> > >>
>> > >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com> wrote:
>> > >>>
>> > >>> Hi,
>> > >>> Please find the attached patch file with this mail.
>> > >>> The changes made are to the cran.scm
>> > >>> * gnu/packages/cran.scm (r-weights): New variable.
>> > >>>
>> > >>> Thanks,
>> > >>> Lakshmi Prasannakumar
>> > >>> Bangalore
>> >
>> > Best regards,
>> > g_bor




Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Mon, 05 Nov 2018 22:21:01 GMT) Full text and rfc822 format available.

Message #28 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Mon, 5 Nov 2018 23:19:57 +0100
Hello Lakshmi,

It would be nice if you could give this another shot, if not I will
commit it tomorrow with
some minor changes.

The commit message seems to be missing the second line (what has changed).

The license field still misses the prefix. See the mail from Björn earlier.

Could you squash your changes to a single commit?

(You can either do this on a throw-away branch with a git merge --squash, or
you can use git rebase -i, see this for more info
https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history.)

Best regards,
g_bor




Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Thu, 08 Nov 2018 04:08:03 GMT) Full text and rfc822 format available.

Message #31 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Thu, 8 Nov 2018 09:37:24 +0530
[Message part 1 (text/plain, inline)]
Hi Gábor,

I am extremely sorry that , I did miss out this mail. I would like to know
, if there is anything more that I need to do on r-weights package
addition.
If not could you tell me how you fixed this to do the final commit ?

Thanks,

On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits <at> gmail.com wrote:

> Hello Lakshmi,
>
> It would be nice if you could give this another shot, if not I will
> commit it tomorrow with
> some minor changes.
>
> The commit message seems to be missing the second line (what has changed).
>
> The license field still misses the prefix. See the mail from Björn earlier.
>
> Could you squash your changes to a single commit?
>
> (You can either do this on a throw-away branch with a git merge --squash,
> or
> you can use git rebase -i, see this for more info
>
> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
> .)
>
> Best regards,
> g_bor
>
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Thu, 08 Nov 2018 19:36:01 GMT) Full text and rfc822 format available.

Message #34 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Thu, 8 Nov 2018 20:35:00 +0100
[Message part 1 (text/plain, inline)]
I used the version where the most things were fixed, applied it to the
commit in Björn's message, created a branch, rebased on current master,
then fixed the commit message using amend, signed off and pushed. There is
no additional thing to do.

2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
lakshmiprasannakumaran <at> gmail.com> ezt írta:

> Hi Gábor,
>
> I am extremely sorry that , I did miss out this mail. I would like to know
> , if there is anything more that I need to do on r-weights package
> addition.
> If not could you tell me how you fixed this to do the final commit ?
>
> Thanks,
>
> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits <at> gmail.com wrote:
>
>> Hello Lakshmi,
>>
>> It would be nice if you could give this another shot, if not I will
>> commit it tomorrow with
>> some minor changes.
>>
>> The commit message seems to be missing the second line (what has changed).
>>
>> The license field still misses the prefix. See the mail from Björn
>> earlier.
>>
>> Could you squash your changes to a single commit?
>>
>> (You can either do this on a throw-away branch with a git merge --squash,
>> or
>> you can use git rebase -i, see this for more info
>>
>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>> .)
>>
>> Best regards,
>> g_bor
>>
>
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#33217; Package guix-patches. (Thu, 08 Nov 2018 20:37:02 GMT) Full text and rfc822 format available.

Message #37 received at 33217 <at> debbugs.gnu.org (full text, mbox):

From: Lakshmi Prasannakumar <lakshmiprasannakumaran <at> gmail.com>
To: Gábor Boskovits <boskovits <at> gmail.com>
Cc: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>,
 33217 <at> debbugs.gnu.org
Subject: Re: Modifying the commit message to gnu-Add-r-weights
Date: Fri, 9 Nov 2018 02:06:17 +0530
[Message part 1 (text/plain, inline)]
Thank You Gábor,

I was planning to look for dependencies to work on adding anaconda as a
package. Just got my system upgraded and will get back to you with a
roadmap to proceed with.
Or do you think I need to start working on something else?

Regards,
Lakshmi Prasannakumar
Bangalore


On Fri, Nov 9, 2018 at 1:05 AM Gábor Boskovits <boskovits <at> gmail.com> wrote:

> I used the version where the most things were fixed, applied it to the
> commit in Björn's message, created a branch, rebased on current master,
> then fixed the commit message using amend, signed off and pushed. There is
> no additional thing to do.
>
> 2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
> lakshmiprasannakumaran <at> gmail.com> ezt írta:
>
>> Hi Gábor,
>>
>> I am extremely sorry that , I did miss out this mail. I would like to
>> know , if there is anything more that I need to do on r-weights package
>> addition.
>> If not could you tell me how you fixed this to do the final commit ?
>>
>> Thanks,
>>
>> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits <at> gmail.com wrote:
>>
>>> Hello Lakshmi,
>>>
>>> It would be nice if you could give this another shot, if not I will
>>> commit it tomorrow with
>>> some minor changes.
>>>
>>> The commit message seems to be missing the second line (what has
>>> changed).
>>>
>>> The license field still misses the prefix. See the mail from Björn
>>> earlier.
>>>
>>> Could you squash your changes to a single commit?
>>>
>>> (You can either do this on a throw-away branch with a git merge
>>> --squash, or
>>> you can use git rebase -i, see this for more info
>>>
>>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>>> .)
>>>
>>> Best regards,
>>> g_bor
>>>
>>
[Message part 2 (text/html, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Fri, 07 Dec 2018 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 247 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.