GNU bug report logs - #32860
[PATCH] gnu: pocl: Update to 1.2.

Previous Next

Full log

Message #11 received at 32860 <at> debbugs.gnu.org (full text, mbox):

From: fis trivial <ybbs.daans <at> hotmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: "32860 <at> debbugs.gnu.org" <32860 <at> debbugs.gnu.org>,
 fis trivial <ybbs.daans <at> hotmail.com>
Subject: Re: [bug#32860] [PATCH] gnu: pocl: Update to 1.2.
Date: Sat, 29 Sep 2018 01:26:03 +0000

Leo Famulari writes:

> On Fri, Sep 28, 2018 at 10:06:30AM +0000, fis trivial wrote:
>> * gnu/packages/opencl.scm (pocl): Update to 1.2.
>
> Thanks!
>
>>      (source
>>       (origin
>> -       (method git-fetch)
>> -       (uri (git-reference
>> -             (url "https://github.com/pocl/pocl.git")
>> -             (commit (string-append "v" version))))
>> -       (file-name (git-file-name name version))
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/pocl/pocl/archive/v"
>> +             version".tar.gz"))
>
> Is there a particular reason to use the tarball instead of the Git repo
> here? I ask because Github's autogenerated tarballs are subject to
> change [0], which is annoying, whereas the Git repo should be
> bit-identical forever.
>
> [0] https://github.com/libgit2/libgit2/issues/4343

Oh, sorry I didn't know about that.  Tarball feels cleaner than setting up a
git repo (just a feeling).  I will send another patch using git soon.

But isn't those tarball now everywhere in Guix?  It would be a huge headache.

--
Jiaming

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.