GNU bug report logs - #32859
[PATCH 1/3] gnu: Add emacs-all-the-icons.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32859 in the body.
You can then email your comments to 32859 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: guix-patches <at> gnu.org
Cc: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH 1/3] gnu: Add emacs-all-the-icons.
Date: Thu, 27 Sep 2018 21:47:35 +0200

* gnu/packages/emacs.scm (emacs-all-the-icons): New variable.
---
 gnu/packages/emacs.scm | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 8da5add88..fe229b650 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -12262,3 +12262,38 @@ execute its commands and resize images.")
       (description "Synosaurus is a thesaurus fontend for Emacs with pluggable
 backends, including the @command{wordnet} offline backend.")
       (license license:gpl3+))))
+
+(define-public emacs-all-the-icons
+  (package
+    (name "emacs-all-the-icons")
+    (version "3.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/domtronn/all-the-icons.el.git")
+             (commit version)))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1sdl33117lccznj38021lwcdnpi9nxmym295q6y460y4dm4lx0jn"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:include '("\\.el$" "^data/" "^fonts/")
+       ;; Compiling "test/" fails with "Symbol’s value as variable is void:
+       ;; all-the-icons--root-code".  Ignoring tests.
+       #:exclude '("^test/")
+       #:tests? #f))
+    (propagated-inputs
+     `(("f" ,emacs-f)
+       ("memoize" ,emacs-memoize)))
+    (home-page "https://github.com/dommtron/all-the-icons.el")
+    (synopsis "Collect icon fonts and propertize them within Emacs")
+    (description "All-the-icons is a utility package to collect various icon
+fonts and propertize them within Emacs.")
+    ;; Package is released under Expat license.  Fonts come with various
+    ;; licenses: Expat for "all-the-icons.ttf" and "file-icons.ttf", Apache
+    ;; License 2.0 for "material-design-icons.ttf", and SIL OFL 1.1 for
+    ;; "fontawesome.ttf", "ocitcons.ttf" and "weathericons.ttf".
+    (license (list license:expat license:silofl1.1 license:asl2.0))))
+
-- 
2.18.0

Message #8 received at 32859 <at> debbugs.gnu.org (full text, mbox):

From: Timothy Sample <samplet <at> ngyro.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 32859 <at> debbugs.gnu.org
Subject: Re: [bug#32859] [PATCH 1/3] gnu: Add emacs-all-the-icons.
Date: Thu, 27 Sep 2018 22:11:17 -0400

Hi,

There’s a little typo in the home-page below.

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> * gnu/packages/emacs.scm (emacs-all-the-icons): New variable.
> ---
>  gnu/packages/emacs.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 8da5add88..fe229b650 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -12262,3 +12262,38 @@ execute its commands and resize images.")
>        (description "Synosaurus is a thesaurus fontend for Emacs with pluggable
>  backends, including the @command{wordnet} offline backend.")
>        (license license:gpl3+))))
> +
> +(define-public emacs-all-the-icons
> +  (package
> +    (name "emacs-all-the-icons")
> +    (version "3.2.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/domtronn/all-the-icons.el.git")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1sdl33117lccznj38021lwcdnpi9nxmym295q6y460y4dm4lx0jn"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     `(#:include '("\\.el$" "^data/" "^fonts/")
> +       ;; Compiling "test/" fails with "Symbol’s value as variable is void:
> +       ;; all-the-icons--root-code".  Ignoring tests.
> +       #:exclude '("^test/")
> +       #:tests? #f))
> +    (propagated-inputs
> +     `(("f" ,emacs-f)
> +       ("memoize" ,emacs-memoize)))
> +    (home-page "https://github.com/dommtron/all-the-icons.el")

s/dommtron/domtronn/

> +    (synopsis "Collect icon fonts and propertize them within Emacs")
> +    (description "All-the-icons is a utility package to collect various icon
> +fonts and propertize them within Emacs.")
> +    ;; Package is released under Expat license.  Fonts come with various
> +    ;; licenses: Expat for "all-the-icons.ttf" and "file-icons.ttf", Apache
> +    ;; License 2.0 for "material-design-icons.ttf", and SIL OFL 1.1 for
> +    ;; "fontawesome.ttf", "ocitcons.ttf" and "weathericons.ttf".
> +    (license (list license:expat license:silofl1.1 license:asl2.0))))
> +

-- Tim

Message #11 received at 32859 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 32859 <at> debbugs.gnu.org
Subject: Re: [bug#32859] [PATCH 1/3] gnu: Add emacs-all-the-icons.
Date: Sat, 29 Sep 2018 23:59:36 +0200

Hello,

Apart from the typo Timothy reported, I think patches #1 and #2 could
have their descriptions expounded.

Otherwise LGTM, thanks!

Ludo’.

Message #14 received at 32859 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>, 32859 <at> debbugs.gnu.org
Subject: Re: [bug#32859] [PATCH 1/3] gnu: Add emacs-all-the-icons.
Date: Sun, 30 Sep 2018 15:54:00 +0200

[Message part 1 (text/plain, inline)]

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> * gnu/packages/emacs.scm (emacs-all-the-icons): New variable.
> ---
>  gnu/packages/emacs.scm | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 8da5add88..fe229b650 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -12262,3 +12262,38 @@ execute its commands and resize images.")
>        (description "Synosaurus is a thesaurus fontend for Emacs with pluggable
>  backends, including the @command{wordnet} offline backend.")
>        (license license:gpl3+))))
> +
> +(define-public emacs-all-the-icons
> +  (package
> +    (name "emacs-all-the-icons")
> +    (version "3.2.0")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/domtronn/all-the-icons.el.git")
> +             (commit version)))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "1sdl33117lccznj38021lwcdnpi9nxmym295q6y460y4dm4lx0jn"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     `(#:include '("\\.el$" "^data/" "^fonts/")
> +       ;; Compiling "test/" fails with "Symbol’s value as variable is void:
> +       ;; all-the-icons--root-code".  Ignoring tests.
> +       #:exclude '("^test/")
> +       #:tests? #f))
> +    (propagated-inputs
> +     `(("f" ,emacs-f)
> +       ("memoize" ,emacs-memoize)))
> +    (home-page "https://github.com/dommtron/all-the-icons.el")
                                    ^^^
                                    "domtronn"
> +    (synopsis "Collect icon fonts and propertize them within Emacs")
> +    (description "All-the-icons is a utility package to collect various icon
> +fonts and propertize them within Emacs.")
> +    ;; Package is released under Expat license.  Fonts come with various
> +    ;; licenses: Expat for "all-the-icons.ttf" and "file-icons.ttf", Apache
> +    ;; License 2.0 for "material-design-icons.ttf", and SIL OFL 1.1 for
> +    ;; "fontawesome.ttf", "ocitcons.ttf" and "weathericons.ttf".
> +    (license (list license:expat license:silofl1.1 license:asl2.0))))

Actually, while LICENSE says MIT; the source headers in all-the-icons.el
says GPL3+.  I guess Expat is for the files without explicit license
headers?

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 32859 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 32859 <at> debbugs.gnu.org
Subject: Re: [bug#32859] [PATCH 1/3] gnu: Add emacs-all-the-icons.
Date: Wed, 03 Oct 2018 18:57:11 +0200

Hello,

Marius Bakke <mbakke <at> fastmail.com> writes:

> Actually, while LICENSE says MIT; the source headers in all-the-icons.el
> says GPL3+.  I guess Expat is for the files without explicit license
> headers?

I guess so. I added GPL3+ in the list of licenses for Elisp files. Thank you.

Regards,

-- 
Nicolas Goaziou

Message #20 received at 32859 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Timothy Sample <samplet <at> ngyro.com>
Cc: 32859 <at> debbugs.gnu.org
Subject: Re: [bug#32859] [PATCH 1/3] gnu: Add emacs-all-the-icons.
Date: Wed, 03 Oct 2018 18:58:02 +0200

Hello,

Timothy Sample <samplet <at> ngyro.com> writes:

> There’s a little typo in the home-page below.

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou

Message #25 received at 32859-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 32859-done <at> debbugs.gnu.org
Subject: Re: [bug#32859] [PATCH 1/3] gnu: Add emacs-all-the-icons.
Date: Wed, 03 Oct 2018 18:58:53 +0200

Hello,

ludo <at> gnu.org (Ludovic Courtès) writes:

> Apart from the typo Timothy reported, I think patches #1 and #2 could
> have their descriptions expounded.

I tried to expound the descriptions a bit and applied the patches. Let
me know if something is not right.

Thank you.

Regards,

-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.