GNU bug report logs - #32860
[PATCH] gnu: pocl: Update to 1.2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 32860 in the body.
You can then email your comments to 32860 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: fis trivial <ybbs.daans <at> hotmail.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: pocl: Update to 1.2.
Date: Fri, 28 Sep 2018 10:06:30 +0000

* gnu/packages/opencl.scm (pocl): Update to 1.2.
---
 gnu/packages/opencl.scm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index d32e69643..0df4b2e1c 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -294,23 +294,23 @@ back-end for the LLVM compiler framework.")
 (define-public pocl
   (package
     (name "pocl")
-    (version "1.1")
+    (version "1.2")
     (source
      (origin
-       (method git-fetch)
-       (uri (git-reference
-             (url "https://github.com/pocl/pocl.git")
-             (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/pocl/pocl/archive/v"
+             version".tar.gz"))
        (sha256
-        (base32 "1z3sqn20ddv1030adchpzs65qng436gc2mb99p213mkh95jkh1l5"))))
+        (base32 "0iidk05lac83kj3zfxyvpqlza4ljknwvw6ds9jkg74k86f7ychqc"))
+       (file-name (string-append name "-" version ".tar.gz"))))
     (build-system cmake-build-system)
     (native-inputs
      `(("libltdl" ,libltdl)
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("clang" ,clang)
-       ("hwloc" ,hwloc "lib")
+       ("hwloc" ,hwloc-2.0 "lib")
        ("llvm" ,llvm)
        ("ocl-icd" ,ocl-icd)))
     (arguments
--
2.19.0

Message #8 received at 32860 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: fis trivial <ybbs.daans <at> hotmail.com>
Cc: 32860 <at> debbugs.gnu.org
Subject: Re: [bug#32860] [PATCH] gnu: pocl: Update to 1.2.
Date: Fri, 28 Sep 2018 10:41:49 -0400

[Message part 1 (text/plain, inline)]

On Fri, Sep 28, 2018 at 10:06:30AM +0000, fis trivial wrote:
> * gnu/packages/opencl.scm (pocl): Update to 1.2.

Thanks!

>      (source
>       (origin
> -       (method git-fetch)
> -       (uri (git-reference
> -             (url "https://github.com/pocl/pocl.git")
> -             (commit (string-append "v" version))))
> -       (file-name (git-file-name name version))
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/pocl/pocl/archive/v"
> +             version".tar.gz"))

Is there a particular reason to use the tarball instead of the Git repo
here? I ask because Github's autogenerated tarballs are subject to
change [0], which is annoying, whereas the Git repo should be
bit-identical forever.

[0] https://github.com/libgit2/libgit2/issues/4343

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 32860 <at> debbugs.gnu.org (full text, mbox):

From: fis trivial <ybbs.daans <at> hotmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: "32860 <at> debbugs.gnu.org" <32860 <at> debbugs.gnu.org>,
 fis trivial <ybbs.daans <at> hotmail.com>
Subject: Re: [bug#32860] [PATCH] gnu: pocl: Update to 1.2.
Date: Sat, 29 Sep 2018 01:26:03 +0000

Leo Famulari writes:

> On Fri, Sep 28, 2018 at 10:06:30AM +0000, fis trivial wrote:
>> * gnu/packages/opencl.scm (pocl): Update to 1.2.
>
> Thanks!
>
>>      (source
>>       (origin
>> -       (method git-fetch)
>> -       (uri (git-reference
>> -             (url "https://github.com/pocl/pocl.git")
>> -             (commit (string-append "v" version))))
>> -       (file-name (git-file-name name version))
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/pocl/pocl/archive/v"
>> +             version".tar.gz"))
>
> Is there a particular reason to use the tarball instead of the Git repo
> here? I ask because Github's autogenerated tarballs are subject to
> change [0], which is annoying, whereas the Git repo should be
> bit-identical forever.
>
> [0] https://github.com/libgit2/libgit2/issues/4343

Oh, sorry I didn't know about that.  Tarball feels cleaner than setting up a
git repo (just a feeling).  I will send another patch using git soon.

But isn't those tarball now everywhere in Guix?  It would be a huge headache.

--
Jiaming

Message #14 received at 32860 <at> debbugs.gnu.org (full text, mbox):

From: fis trivial <ybbs.daans <at> hotmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: "32860 <at> debbugs.gnu.org" <32860 <at> debbugs.gnu.org>
Subject: [PATCH] gnu: pocl: Update to 1.2.
Date: Sat, 29 Sep 2018 04:05:15 +0000

* gnu/packages/opencl.scm (pocl): Update to 1.2.
---
 gnu/packages/opencl.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/opencl.scm b/gnu/packages/opencl.scm
index d32e69643..da979253b 100644
--- a/gnu/packages/opencl.scm
+++ b/gnu/packages/opencl.scm
@@ -294,23 +294,23 @@ back-end for the LLVM compiler framework.")
 (define-public pocl
   (package
     (name "pocl")
-    (version "1.1")
+    (version "1.2")
     (source
      (origin
        (method git-fetch)
        (uri (git-reference
              (url "https://github.com/pocl/pocl.git")
              (commit (string-append "v" version))))
-       (file-name (git-file-name name version))
        (sha256
-        (base32 "1z3sqn20ddv1030adchpzs65qng436gc2mb99p213mkh95jkh1l5"))))
+        (base32 "0fyiwd9nrqhl0jsac0bx17p9acpfzhyxp50mmp28mzn7psb9qidg"))
+       (file-name (git-file-name name version))))
     (build-system cmake-build-system)
     (native-inputs
      `(("libltdl" ,libltdl)
        ("pkg-config" ,pkg-config)))
     (inputs
      `(("clang" ,clang)
-       ("hwloc" ,hwloc "lib")
+       ("hwloc" ,hwloc-2.0 "lib")
        ("llvm" ,llvm)
        ("ocl-icd" ,ocl-icd)))
     (arguments
--
2.19.0

Message #17 received at 32860 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: fis trivial <ybbs.daans <at> hotmail.com>
Cc: "32860 <at> debbugs.gnu.org" <32860 <at> debbugs.gnu.org>
Subject: Re: [bug#32860] [PATCH] gnu: pocl: Update to 1.2.
Date: Sat, 29 Sep 2018 10:57:57 -0400

[Message part 1 (text/plain, inline)]

On Sat, Sep 29, 2018 at 01:26:03AM +0000, fis trivial wrote:
> Oh, sorry I didn't know about that.  Tarball feels cleaner than setting up a
> git repo (just a feeling).  I will send another patch using git soon.

Yeah, I agree with you. Git is a huge and complicated package. It's
annoying that the packages depend on it.

> But isn't those tarball now everywhere in Guix?  It would be a huge headache.

Yes. Previously we favored the GitHub tarballs, but in September 2017
GitHub caused a large number of them to change, and it was a big
headache for us and many other distros.

GitHub's recommendation is to use Git checkouts or for upstream projects
to upload their own tarballs to their project's GitHub release page. [0]
GitHub doesn't guarantee their automatically generated tarballs will
remain identical in the future.

So, for packages where the upstream maintainers do not upload their own
tarballs, we are slowly changing our package definitions to use Git
checkouts.

[0] You can see an example of the difference between the upstream
project's own tarballs, and the tarballs automatically generated by
GitHub, on the Borg release page:

https://github.com/borgbackup/borg/releases

The file named 'Source code (tar.gz)' is automatically created by
GitHub. It may change in the future. The file named
'borgbackup-1.1.7.tar.gz' is uploaded by Borg's maintainers, and it
should never change.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 32860-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: fis trivial <ybbs.daans <at> hotmail.com>
Cc: "32860 <at> debbugs.gnu.org" <32860-done <at> debbugs.gnu.org>
Subject: Re: [PATCH] gnu: pocl: Update to 1.2.
Date: Sat, 29 Sep 2018 11:17:55 -0400

[Message part 1 (text/plain, inline)]

On Sat, Sep 29, 2018 at 04:05:15AM +0000, fis trivial wrote:
> 
> * gnu/packages/opencl.scm (pocl): Update to 1.2.

Thanks! Pushed as bfb22078fd3a184f60968938851ada97d7dead58

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 32860 <at> debbugs.gnu.org (full text, mbox):

From: fis trivial <ybbs.daans <at> hotmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: "32860 <at> debbugs.gnu.org" <32860 <at> debbugs.gnu.org>,
 fis trivial <ybbs.daans <at> hotmail.com>
Subject: Re: [bug#32860] [PATCH] gnu: pocl: Update to 1.2.
Date: Sun, 30 Sep 2018 01:17:43 +0000

Thanks for the detailed explanation, sometimes it's quite rewarding to
contribute. :)

Leo Famulari writes:

> On Sat, Sep 29, 2018 at 01:26:03AM +0000, fis trivial wrote:
>> Oh, sorry I didn't know about that.  Tarball feels cleaner than setting up a
>> git repo (just a feeling).  I will send another patch using git soon.
>
> Yeah, I agree with you. Git is a huge and complicated package. It's
> annoying that the packages depend on it.
>
>> But isn't those tarball now everywhere in Guix?  It would be a huge headache.
>
> Yes. Previously we favored the GitHub tarballs, but in September 2017
> GitHub caused a large number of them to change, and it was a big
> headache for us and many other distros.
>
> GitHub's recommendation is to use Git checkouts or for upstream projects
> to upload their own tarballs to their project's GitHub release page. [0]
> GitHub doesn't guarantee their automatically generated tarballs will
> remain identical in the future.
>
> So, for packages where the upstream maintainers do not upload their own
> tarballs, we are slowly changing our package definitions to use Git
> checkouts.
>
> [0] You can see an example of the difference between the upstream
> project's own tarballs, and the tarballs automatically generated by
> GitHub, on the Borg release page:
>
> https://github.com/borgbackup/borg/releases
>
> The file named 'Source code (tar.gz)' is automatically created by
> GitHub. It may change in the future. The file named
> 'borgbackup-1.1.7.tar.gz' is uploaded by Borg's maintainers, and it
> should never change.

Jiaming

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.