GNU bug report logs - #31046
[PATCH] gnu: chromaprint: Build fpcalc

Previous Next

Full log

Message #13 received at 31046-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31046-done <at> debbugs.gnu.org
Subject: Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
Date: Wed, 04 Apr 2018 13:56:02 +0200

Hello,

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> ---
>  gnu/packages/mp3.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 6dc58e2cc..f57ebf575 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -508,6 +508,7 @@ command-line tool.")
>      (arguments
>       `(#:tests? #f ; tests require googletest *sources*
>         ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> +       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc

[...]

> It's less than 40kb and does not require additional dependencies.
> The size of the closure (as returned by ~guix size chromaprint~) is
> 510.3 MB, just like before the patch.
>
> Considering how light it is, I don't think it's worth making a separate
> output.

Agreed.

I slightly adjusted the commit log to match the conventions and
committed.  Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.