GNU bug report logs - #31047
[PATCH] gnu: 4store: Remove preprocessor directive.

Previous Next

Package: guix-patches;

Reported by: Roel Janssen <roel <at> gnu.org>

Date: Tue, 3 Apr 2018 16:01:01 UTC

Severity: normal

Tags: patch

Done: Roel Janssen <roel <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31047 in the body.
You can then email your comments to 31047 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#31047; Package guix-patches. (Tue, 03 Apr 2018 16:01:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Roel Janssen <roel <at> gnu.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 03 Apr 2018 16:01:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: 4store: Remove preprocessor directive.
Date: Tue, 03 Apr 2018 17:59:41 +0200

[Message part 1 (text/plain, inline)]
Dear Guix,

The following patch fixes 4store's build.

Kind regards,
Roel Janssen


[0001-gnu-4store-Remove-preprocessor-directive.patch (text/x-patch, attachment)]
Information forwarded to guix-patches <at> gnu.org:
bug#31047; Package guix-patches. (Wed, 04 Apr 2018 11:58:01 GMT) Full text and rfc822 format available.

Message #8 received at 31047 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 31047 <at> debbugs.gnu.org
Subject: Re: [bug#31047] [PATCH] gnu: 4store: Remove preprocessor directive.
Date: Wed, 04 Apr 2018 13:57:15 +0200

Roel Janssen <roel <at> gnu.org> skribis:

> From c199e8bc2ae4db3ecd8dcc4267619d9fdc2e9a1b Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel <at> gnu.org>
> Date: Tue, 3 Apr 2018 17:47:05 +0200
> Subject: [PATCH] gnu: 4store: Remove preprocessor directive.
>
> * gnu/packages/databases.scm (4store): Add patch to remove preprocessor
>   directive.
> * gnu/packages/patches/4store-unset-preprocessor-directive.patch: New file.
> * gnu/local.mk: Register patch.

[...]

> +      (patches (list (search-patch "4store-unset-preprocessor-directive.patch")
> +                     (search-patch "4store-fix-buildsystem.patch")))))

You can even use ‘search-patches’ here.

Otherwise LGTM, thanks!

Ludo’.
Information forwarded to guix-patches <at> gnu.org:
bug#31047; Package guix-patches. (Wed, 04 Apr 2018 12:58:02 GMT) Full text and rfc822 format available.

Message #11 received at 31047 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31047 <at> debbugs.gnu.org
Subject: Re: [bug#31047] [PATCH] gnu: 4store: Remove preprocessor directive.
Date: Wed, 04 Apr 2018 14:57:35 +0200

Ludovic Courtès <ludo <at> gnu.org> writes:

> Roel Janssen <roel <at> gnu.org> skribis:
>
>> From c199e8bc2ae4db3ecd8dcc4267619d9fdc2e9a1b Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Tue, 3 Apr 2018 17:47:05 +0200
>> Subject: [PATCH] gnu: 4store: Remove preprocessor directive.
>>
>> * gnu/packages/databases.scm (4store): Add patch to remove preprocessor
>>   directive.
>> * gnu/packages/patches/4store-unset-preprocessor-directive.patch: New file.
>> * gnu/local.mk: Register patch.
>
> [...]
>
>> +      (patches (list (search-patch "4store-unset-preprocessor-directive.patch")
>> +                     (search-patch "4store-fix-buildsystem.patch")))))
>
> You can even use ‘search-patches’ here.

Of course.  Old habits die hard I suppose..
I used ‘search-patches’ and pushed in ea09f99f7.

Thanks!

Kind regards,
Roel Janssen
Reply sent to Roel Janssen <roel <at> gnu.org>:
You have taken responsibility. (Wed, 04 Apr 2018 13:00:02 GMT) Full text and rfc822 format available.
Notification sent to Roel Janssen <roel <at> gnu.org>:
bug acknowledged by developer. (Wed, 04 Apr 2018 13:00:02 GMT) Full text and rfc822 format available.

Message #16 received at 31047-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31047-done <at> debbugs.gnu.org
Subject: Re: [bug#31047] [PATCH] gnu: 4store: Remove preprocessor directive.
Date: Wed, 04 Apr 2018 14:58:57 +0200

Roel Janssen <roel <at> gnu.org> writes:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Roel Janssen <roel <at> gnu.org> skribis:
>>
>>> From c199e8bc2ae4db3ecd8dcc4267619d9fdc2e9a1b Mon Sep 17 00:00:00 2001
>>> From: Roel Janssen <roel <at> gnu.org>
>>> Date: Tue, 3 Apr 2018 17:47:05 +0200
>>> Subject: [PATCH] gnu: 4store: Remove preprocessor directive.
>>>
>>> * gnu/packages/databases.scm (4store): Add patch to remove preprocessor
>>>   directive.
>>> * gnu/packages/patches/4store-unset-preprocessor-directive.patch: New file.
>>> * gnu/local.mk: Register patch.
>>
>> [...]
>>
>>> +      (patches (list (search-patch "4store-unset-preprocessor-directive.patch")
>>> +                     (search-patch "4store-fix-buildsystem.patch")))))
>>
>> You can even use ‘search-patches’ here.
>
> Of course.  Old habits die hard I suppose..
> I used ‘search-patches’ and pushed in ea09f99f7.
>
> Thanks!
>
> Kind regards,
> Roel Janssen

I forgot to mark is as done.  So here goes.

Kind regards,
Roel Janssen
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 03 May 2018 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 49 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.