GNU bug report logs - #31046
[PATCH] gnu: chromaprint: Build fpcalc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31046 in the body.
You can then email your comments to 31046 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: chromaprint: Build fpcalc
Date: Tue,  3 Apr 2018 19:53:56 +0530

* gnu/packages/mp3.scm (chromaprint): Build fpcalc
---
 gnu/packages/mp3.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
index 6dc58e2cc..f57ebf575 100644
--- a/gnu/packages/mp3.scm
+++ b/gnu/packages/mp3.scm
@@ -508,6 +508,7 @@ command-line tool.")
     (arguments
      `(#:tests? #f ; tests require googletest *sources*
        ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
+       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc
        #:test-target "check"))
     (inputs
      ;; requires one of FFmpeg (prefered), FFTW3 or vDSP
-- 
2.16.3

Message #8 received at 31046 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: 31046 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: chromaprint: Build fpcalc
Date: Tue, 03 Apr 2018 19:58:42 +0530

[Message part 1 (text/plain, inline)]

Toggle on the build of fpcalc, a commandline tool to compute the
fingerprint of audio files.

It's less than 40kb and does not require additional dependencies.
The size of the closure (as returned by ~guix size chromaprint~) is
510.3 MB, just like before the patch.

Considering how light it is, I don't think it's worth making a separate
output.

--
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 31046-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31046-done <at> debbugs.gnu.org
Subject: Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
Date: Wed, 04 Apr 2018 13:56:02 +0200

Hello,

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/mp3.scm (chromaprint): Build fpcalc
> ---
>  gnu/packages/mp3.scm | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gnu/packages/mp3.scm b/gnu/packages/mp3.scm
> index 6dc58e2cc..f57ebf575 100644
> --- a/gnu/packages/mp3.scm
> +++ b/gnu/packages/mp3.scm
> @@ -508,6 +508,7 @@ command-line tool.")
>      (arguments
>       `(#:tests? #f ; tests require googletest *sources*
>         ;;#:configure-flags '("-DBUILD_TESTS=ON") ; for building the tests
> +       #:configure-flags '("-DBUILD_TOOLS=ON") ; for fpcalc

[...]

> It's less than 40kb and does not require additional dependencies.
> The size of the closure (as returned by ~guix size chromaprint~) is
> 510.3 MB, just like before the patch.
>
> Considering how light it is, I don't think it's worth making a separate
> output.

Agreed.

I slightly adjusted the commit log to match the conventions and
committed.  Thank you!

Ludo’.

Message #16 received at 31046-done <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31046-done <at> debbugs.gnu.org
Subject: Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
Date: Wed, 04 Apr 2018 18:53:19 +0530

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> I slightly adjusted the commit log to match the conventions and
> committed.  Thank you!

Thank you.

I'm a bit confused about the log conventions although I've read the GNU
standards.  Are there some unwritten rules?

Maybe it's just a matter of getting use to the change log :)

--
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 31046-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31046-done <at> debbugs.gnu.org
Subject: Re: [bug#31046] [PATCH] gnu: chromaprint: Build fpcalc
Date: Wed, 04 Apr 2018 16:06:16 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> I slightly adjusted the commit log to match the conventions and
>> committed.  Thank you!
>
> Thank you.
>
> I'm a bit confused about the log conventions although I've read the GNU
> standards.  Are there some unwritten rules?

I think about everything is written down, maybe there are actually too
many written rules.  :-)

> Maybe it's just a matter of getting use to the change log :)

Yeah.  I’d suggest looking at past commits when in doubt.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.