GNU bug report logs - #29740
[PATCH] gnu: system: vm: Use loose cache for 9p file system.

Previous Next

Full log

View this message in rfc822 format

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 29740 <at> debbugs.gnu.org
Subject: [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file system.
Date: Sat, 16 Dec 2017 21:10:12 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Sat, Dec 16, 2017 at 07:20:18PM +0000, Christopher Baines wrote:
>> This improves the performance of the shared store for operations involving
>> lots of files, e.g. searching through the store.
>> 
>> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
>
> Okay!
>
>> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
>> index 6102d465b..c1305d3f9 100644
>> --- a/gnu/system/vm.scm
>> +++ b/gnu/system/vm.scm
>> @@ -554,7 +554,7 @@ of the GNU system as described by OS."
>>         (device (file-system->mount-tag source))
>>         (type "9p")
>>         (flags (if writable? '() '(read-only)))
>> -       (options (string-append "trans=virtio"))
>> +       (options "trans=virtio,cache=loose")
>
> Was that string-append unnecessary in this context?

I think so. It has always been like this I think, and I haven't had any
problems with this change.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.