GNU bug report logs - #29740
[PATCH] gnu: system: vm: Use loose cache for 9p file system.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29740 in the body.
You can then email your comments to 29740 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: system: vm: Use loose cache for 9p file system.
Date: Sat, 16 Dec 2017 19:20:18 +0000

This improves the performance of the shared store for operations involving
lots of files, e.g. searching through the store.

* gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
---
 gnu/system/vm.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
index 6102d465b..c1305d3f9 100644
--- a/gnu/system/vm.scm
+++ b/gnu/system/vm.scm
@@ -554,7 +554,7 @@ of the GNU system as described by OS."
        (device (file-system->mount-tag source))
        (type "9p")
        (flags (if writable? '() '(read-only)))
-       (options (string-append "trans=virtio"))
+       (options "trans=virtio,cache=loose")
        (check? #f)
        (create-mount-point? #t)))))
 
-- 
2.15.1

Message #8 received at 29740 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 29740 <at> debbugs.gnu.org
Subject: Re: [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file
 system.
Date: Sat, 16 Dec 2017 15:25:14 -0500

[Message part 1 (text/plain, inline)]

On Sat, Dec 16, 2017 at 07:20:18PM +0000, Christopher Baines wrote:
> This improves the performance of the shared store for operations involving
> lots of files, e.g. searching through the store.
> 
> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.

Okay!

> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
> index 6102d465b..c1305d3f9 100644
> --- a/gnu/system/vm.scm
> +++ b/gnu/system/vm.scm
> @@ -554,7 +554,7 @@ of the GNU system as described by OS."
>         (device (file-system->mount-tag source))
>         (type "9p")
>         (flags (if writable? '() '(read-only)))
> -       (options (string-append "trans=virtio"))
> +       (options "trans=virtio,cache=loose")

Was that string-append unnecessary in this context?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 29740 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 29740 <at> debbugs.gnu.org
Subject: Re: [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file
 system.
Date: Sat, 16 Dec 2017 21:10:12 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Sat, Dec 16, 2017 at 07:20:18PM +0000, Christopher Baines wrote:
>> This improves the performance of the shared store for operations involving
>> lots of files, e.g. searching through the store.
>> 
>> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
>
> Okay!
>
>> diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
>> index 6102d465b..c1305d3f9 100644
>> --- a/gnu/system/vm.scm
>> +++ b/gnu/system/vm.scm
>> @@ -554,7 +554,7 @@ of the GNU system as described by OS."
>>         (device (file-system->mount-tag source))
>>         (type "9p")
>>         (flags (if writable? '() '(read-only)))
>> -       (options (string-append "trans=virtio"))
>> +       (options "trans=virtio,cache=loose")
>
> Was that string-append unnecessary in this context?

I think so. It has always been like this I think, and I haven't had any
problems with this change.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 29740 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Christopher Baines <mail <at> cbaines.net>
Cc: 29740 <at> debbugs.gnu.org
Subject: Re: [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file
 system.
Date: Sun, 17 Dec 2017 17:11:29 +0100

Christopher Baines <mail <at> cbaines.net> skribis:

> This improves the performance of the shared store for operations involving
> lots of files, e.g. searching through the store.
>
> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.

That’s a good idea, thank you!

Ludo’.

Message #17 received at 29740 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29740 <at> debbugs.gnu.org
Subject: Re: [bug#29740] [PATCH] gnu: system: vm: Use loose cache for 9p file
 system.
Date: Sun, 17 Dec 2017 20:53:31 +0000

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> This improves the performance of the shared store for operations involving
>> lots of files, e.g. searching through the store.
>>
>> * gnu/system/vm.scm (mapping->file-system): Add cache=loose to options.
>
> That’s a good idea, thank you!

I've now pushed this patch. Thanks for reviewing :)

Chris

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 29740-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 29740-done <at> debbugs.gnu.org
Subject: done
Date: Sun, 17 Dec 2017 20:54:16 +0000

[Message part 1 (text/plain, inline)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.