GNU bug report logs - #29739
[PATCH] services: certbot: Fix certbot renewal job.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29739 in the body.
You can then email your comments to 29739 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: certbot: Fix certbot renewal job.
Date: Sat, 16 Dec 2017 19:18:43 +0000

Quote the list of hosts, to avoid generating a broken job definition.

* gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
  passing them in to the job gexp.
---
 gnu/services/certbot.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
index dc072ea8d..0d72a4b70 100644
--- a/gnu/services/certbot.scm
+++ b/gnu/services/certbot.scm
@@ -72,7 +72,7 @@
                                (string-concatenate
                                 (map (lambda (host)
                                        (string-append " -d " host))
-                                     #$hosts))))))))))
+                                     '#$hosts))))))))))
 
 (define certbot-activation
   (match-lambda
-- 
2.15.1

Message #8 received at 29739 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Christopher Baines <mail <at> cbaines.net>
Cc: 29739 <at> debbugs.gnu.org
Subject: Re: [bug#29739] [PATCH] services: certbot: Fix certbot renewal job.
Date: Sun, 17 Dec 2017 17:10:34 +0100

Christopher Baines <mail <at> cbaines.net> skribis:

> Quote the list of hosts, to avoid generating a broken job definition.
>
> * gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
>   passing them in to the job gexp.

Good catch, LGTM!

Thanks,
Ludo’.

Message #13 received at 29739-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29739-done <at> debbugs.gnu.org
Subject: Re: [bug#29739] [PATCH] services: certbot: Fix certbot renewal job.
Date: Sun, 17 Dec 2017 20:52:58 +0000

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Quote the list of hosts, to avoid generating a broken job definition.
>>
>> * gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
>>   passing them in to the job gexp.
>
> Good catch, LGTM!

Great, I've now pushed this :)

Thanks for reviewing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.