GNU bug report logs - #29739
[PATCH] services: certbot: Fix certbot renewal job.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29739: closed ([PATCH] services: certbot: Fix certbot renewal
 job.)
Date: Sun, 17 Dec 2017 20:54:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 17 Dec 2017 20:52:58 +0000
with message-id <87r2rtt6tx.fsf <at> cbaines.net>
and subject line Re: [bug#29739] [PATCH] services: certbot: Fix certbot renewal job.
has caused the debbugs.gnu.org bug report #29739,
regarding [PATCH] services: certbot: Fix certbot renewal job.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29739: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29739
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] services: certbot: Fix certbot renewal job.
Date: Sat, 16 Dec 2017 19:18:43 +0000

Quote the list of hosts, to avoid generating a broken job definition.

* gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
  passing them in to the job gexp.
---
 gnu/services/certbot.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
index dc072ea8d..0d72a4b70 100644
--- a/gnu/services/certbot.scm
+++ b/gnu/services/certbot.scm
@@ -72,7 +72,7 @@
                                (string-concatenate
                                 (map (lambda (host)
                                        (string-append " -d " host))
-                                     #$hosts))))))))))
+                                     '#$hosts))))))))))
 
 (define certbot-activation
   (match-lambda
-- 
2.15.1

[Message part 3 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 29739-done <at> debbugs.gnu.org
Subject: Re: [bug#29739] [PATCH] services: certbot: Fix certbot renewal job.
Date: Sun, 17 Dec 2017 20:52:58 +0000

[Message part 4 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Christopher Baines <mail <at> cbaines.net> skribis:
>
>> Quote the list of hosts, to avoid generating a broken job definition.
>>
>> * gnu/services/certbot.scm (certbot-renewal-jobs): Quote the hosts when
>>   passing them in to the job gexp.
>
> Good catch, LGTM!

Great, I've now pushed this :)

Thanks for reviewing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.