GNU bug report logs - #29222
26.0.90; doc string of `search-invisible'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29222: closed (26.0.90; doc string of `search-invisible')
Date: Fri, 10 Nov 2017 10:07:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 10 Nov 2017 12:06:07 +0200
with message-id <83po8qphww.fsf <at> gnu.org>
and subject line Re: bug#29222: 26.0.90; doc string of `search-invisible'
has caused the debbugs.gnu.org bug report #29222,
regarding 26.0.90; doc string of `search-invisible'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29222: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29222
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; doc string of `search-invisible'
Date: Wed, 8 Nov 2017 21:00:29 -0800 (PST)

This part of the doc string:

 When the value is 'open', if the text matched is made invisible by an
 overlay having an 'invisible' property and that overlay has a property
 'isearch-open-invisible', then incremental search will show the
 contents.

would be clearer if it said "an overlay having a non-nil 'invisible'
property" and "...has a non-nil property `isearch-open-invisible'.

Having a property is a bit ambiguous, or at least can be thought so.
Sure, it's true that one cannot tell the difference between not having
a property `foo' and having a property `foo' that has a value of nil.
Still, it's better to be explicit here, I think.



In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32)
 of 2017-10-13 built on LAPHROAIG
Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window, C-M-v to scroll help.

Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 29222-done <at> debbugs.gnu.org
Subject: Re: bug#29222: 26.0.90; doc string of `search-invisible'
Date: Fri, 10 Nov 2017 12:06:07 +0200

> Date: Wed, 8 Nov 2017 21:00:29 -0800 (PST)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> This part of the doc string:
> 
>  When the value is 'open', if the text matched is made invisible by an
>  overlay having an 'invisible' property and that overlay has a property
>  'isearch-open-invisible', then incremental search will show the
>  contents.
> 
> would be clearer if it said "an overlay having a non-nil 'invisible'
> property" and "...has a non-nil property `isearch-open-invisible'.

Thanks, done on the release branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.