GNU bug report logs - #29222
26.0.90; doc string of `search-invisible'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29222 in the body.
You can then email your comments to 29222 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; doc string of `search-invisible'
Date: Wed, 8 Nov 2017 21:00:29 -0800 (PST)

This part of the doc string:

 When the value is 'open', if the text matched is made invisible by an
 overlay having an 'invisible' property and that overlay has a property
 'isearch-open-invisible', then incremental search will show the
 contents.

would be clearer if it said "an overlay having a non-nil 'invisible'
property" and "...has a non-nil property `isearch-open-invisible'.

Having a property is a bit ambiguous, or at least can be thought so.
Sure, it's true that one cannot tell the difference between not having
a property `foo' and having a property `foo' that has a value of nil.
Still, it's better to be explicit here, I think.



In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32)
 of 2017-10-13 built on LAPHROAIG
Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4
Windowing system distributor 'Microsoft Corp.', version 6.1.7601
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Type C-x 1 to delete the help window, C-M-v to scroll help.

Configured using:
 'configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Configured features:
XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB
TOOLKIT_SCROLL_BARS

Message #10 received at 29222-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 29222-done <at> debbugs.gnu.org
Subject: Re: bug#29222: 26.0.90; doc string of `search-invisible'
Date: Fri, 10 Nov 2017 12:06:07 +0200

> Date: Wed, 8 Nov 2017 21:00:29 -0800 (PST)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
> This part of the doc string:
> 
>  When the value is 'open', if the text matched is made invisible by an
>  overlay having an 'invisible' property and that overlay has a property
>  'isearch-open-invisible', then incremental search will show the
>  contents.
> 
> would be clearer if it said "an overlay having a non-nil 'invisible'
> property" and "...has a non-nil property `isearch-open-invisible'.

Thanks, done on the release branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.