GNU bug report logs - #28381
[PATCH] gnu: emacs-skewer-mode: Install html and js files.

Previous Next

Full log

Message #11 received at 28381 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Alex Kost <alezost <at> gmail.com>
Cc: 28381 <at> debbugs.gnu.org
Subject: Re: [bug#28381] [PATCH] gnu: emacs-skewer-mode: Install html and js
 files.
Date: Sun, 17 Sep 2017 12:15:18 +0300

[Message part 1 (text/plain, inline)]

Hello Alex,

Alex Kost <alezost <at> gmail.com> writes:

> Oleg Pykhalov (2017-09-07 15:06 +0300) wrote:
>
>>>>From 1cc40f4a0088cbed1ae9f6ca0efdf89a52bf01a5 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Thu, 7 Sep 2017 15:03:31 +0300
>> Subject: [PATCH] gnu: emacs-skewer-mode: Install html and js files.
>>
>> * gnu/packages/emacs.scm (emacs-skewer-mode): Install html and js files.
>> ---
>>  gnu/packages/emacs.scm | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 9c0f9bc89..a7ec0b146 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -1967,6 +1967,21 @@ serve files and directory listings.")
>>      (propagated-inputs
>>       `(("emacs-simple-httpd" ,emacs-simple-httpd)
>>         ("emacs-js2-mode" ,emacs-js2-mode)))
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'install 'install-html-js
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((skewer-mode (string-append (assoc-ref outputs "out")
>> +                                               "/share/emacs/site-lisp/guix.d"
>> +                                               "/skewer-mode-"
>> +                                               ,version)))
>> +               (for-each (lambda (file)
>> +                           (install-file file skewer-mode))
>> +                         '("example.html"
>> +                           "skewer-everything.user.js"
>> +                           "skewer.js")))
>> +             #t)))))
>
> I think it would be easier to use '#:include' instead of this phase,
> like this:
>
>     (arguments '(#:include '("\\.el$" "\\.js$" "\\.html$")))
>
> What do you think?  If it is OK for you, could you please send an
> updated patch?

Sure, it's better.  Thanks for great suggestion.

[0001-gnu-emacs-skewer-mode-Include-html-and-js-files.patch (text/x-patch, inline)]

From 595a0e662d9e18f366870497555dee77ea22dae2 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sun, 17 Sep 2017 12:08:11 +0300
Subject: [PATCH] gnu: emacs-skewer-mode: Include html and js files.

* gnu/packages/emacs.scm (emacs-skewer-mode): Include html and js files.
---
 gnu/packages/emacs.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2b82ced4e..5839f0faf 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1979,6 +1979,9 @@ serve files and directory listings.")
     (propagated-inputs
      `(("emacs-simple-httpd" ,emacs-simple-httpd)
        ("emacs-js2-mode" ,emacs-js2-mode)))
+    (arguments
+     '(#:include
+       '("\\.el$" "\\.js$" "\\.html$")))
     (home-page "https://github.com/skeeto/skewer-mode")
     (synopsis "Live web development in Emacs")
     (description
-- 
2.14.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.