GNU bug report logs - #28381
[PATCH] gnu: emacs-skewer-mode: Install html and js files.

Previous Next

Package: guix-patches;

Reported by: Oleg Pykhalov <go.wigust <at> gmail.com>

Date: Thu, 7 Sep 2017 12:08:01 UTC

Severity: normal

Tags: patch

Done: Alex Kost <alezost <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28381 in the body.
You can then email your comments to 28381 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#28381; Package guix-patches. (Thu, 07 Sep 2017 12:08:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 07 Sep 2017 12:08:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs-skewer-mode: Install html and js files.
Date: Thu, 07 Sep 2017 15:06:20 +0300

[0001-gnu-emacs-skewer-mode-Install-html-and-js-files.patch (text/x-patch, inline)]
From 1cc40f4a0088cbed1ae9f6ca0efdf89a52bf01a5 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Thu, 7 Sep 2017 15:03:31 +0300
Subject: [PATCH] gnu: emacs-skewer-mode: Install html and js files.

* gnu/packages/emacs.scm (emacs-skewer-mode): Install html and js files.
---
 gnu/packages/emacs.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 9c0f9bc89..a7ec0b146 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1967,6 +1967,21 @@ serve files and directory listings.")
     (propagated-inputs
      `(("emacs-simple-httpd" ,emacs-simple-httpd)
        ("emacs-js2-mode" ,emacs-js2-mode)))
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'install-html-js
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((skewer-mode (string-append (assoc-ref outputs "out")
+                                               "/share/emacs/site-lisp/guix.d"
+                                               "/skewer-mode-"
+                                               ,version)))
+               (for-each (lambda (file)
+                           (install-file file skewer-mode))
+                         '("example.html"
+                           "skewer-everything.user.js"
+                           "skewer.js")))
+             #t)))))
     (home-page "https://github.com/skeeto/skewer-mode")
     (synopsis "Live web development in Emacs")
     (description
-- 
2.14.1
Information forwarded to guix-patches <at> gnu.org:
bug#28381; Package guix-patches. (Sat, 09 Sep 2017 20:17:02 GMT) Full text and rfc822 format available.

Message #8 received at 28381 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 28381 <at> debbugs.gnu.org
Subject: Re: [bug#28381] [PATCH] gnu: emacs-skewer-mode: Install html and js
 files.
Date: Sat, 09 Sep 2017 23:16:28 +0300

Oleg Pykhalov (2017-09-07 15:06 +0300) wrote:

>>From 1cc40f4a0088cbed1ae9f6ca0efdf89a52bf01a5 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Thu, 7 Sep 2017 15:03:31 +0300
> Subject: [PATCH] gnu: emacs-skewer-mode: Install html and js files.
>
> * gnu/packages/emacs.scm (emacs-skewer-mode): Install html and js files.
> ---
>  gnu/packages/emacs.scm | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 9c0f9bc89..a7ec0b146 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -1967,6 +1967,21 @@ serve files and directory listings.")
>      (propagated-inputs
>       `(("emacs-simple-httpd" ,emacs-simple-httpd)
>         ("emacs-js2-mode" ,emacs-js2-mode)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'install-html-js
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((skewer-mode (string-append (assoc-ref outputs "out")
> +                                               "/share/emacs/site-lisp/guix.d"
> +                                               "/skewer-mode-"
> +                                               ,version)))
> +               (for-each (lambda (file)
> +                           (install-file file skewer-mode))
> +                         '("example.html"
> +                           "skewer-everything.user.js"
> +                           "skewer.js")))
> +             #t)))))

I think it would be easier to use '#:include' instead of this phase,
like this:

    (arguments '(#:include '("\\.el$" "\\.js$" "\\.html$")))

What do you think?  If it is OK for you, could you please send an
updated patch?

-- 
Alex
Information forwarded to guix-patches <at> gnu.org:
bug#28381; Package guix-patches. (Sun, 17 Sep 2017 09:16:02 GMT) Full text and rfc822 format available.

Message #11 received at 28381 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Alex Kost <alezost <at> gmail.com>
Cc: 28381 <at> debbugs.gnu.org
Subject: Re: [bug#28381] [PATCH] gnu: emacs-skewer-mode: Install html and js
 files.
Date: Sun, 17 Sep 2017 12:15:18 +0300

[Message part 1 (text/plain, inline)]
Hello Alex,

Alex Kost <alezost <at> gmail.com> writes:

> Oleg Pykhalov (2017-09-07 15:06 +0300) wrote:
>
>>>>From 1cc40f4a0088cbed1ae9f6ca0efdf89a52bf01a5 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust <at> gmail.com>
>> Date: Thu, 7 Sep 2017 15:03:31 +0300
>> Subject: [PATCH] gnu: emacs-skewer-mode: Install html and js files.
>>
>> * gnu/packages/emacs.scm (emacs-skewer-mode): Install html and js files.
>> ---
>>  gnu/packages/emacs.scm | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 9c0f9bc89..a7ec0b146 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -1967,6 +1967,21 @@ serve files and directory listings.")
>>      (propagated-inputs
>>       `(("emacs-simple-httpd" ,emacs-simple-httpd)
>>         ("emacs-js2-mode" ,emacs-js2-mode)))
>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'install 'install-html-js
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let ((skewer-mode (string-append (assoc-ref outputs "out")
>> +                                               "/share/emacs/site-lisp/guix.d"
>> +                                               "/skewer-mode-"
>> +                                               ,version)))
>> +               (for-each (lambda (file)
>> +                           (install-file file skewer-mode))
>> +                         '("example.html"
>> +                           "skewer-everything.user.js"
>> +                           "skewer.js")))
>> +             #t)))))
>
> I think it would be easier to use '#:include' instead of this phase,
> like this:
>
>     (arguments '(#:include '("\\.el$" "\\.js$" "\\.html$")))
>
> What do you think?  If it is OK for you, could you please send an
> updated patch?

Sure, it's better.  Thanks for great suggestion.


[0001-gnu-emacs-skewer-mode-Include-html-and-js-files.patch (text/x-patch, inline)]
From 595a0e662d9e18f366870497555dee77ea22dae2 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sun, 17 Sep 2017 12:08:11 +0300
Subject: [PATCH] gnu: emacs-skewer-mode: Include html and js files.

* gnu/packages/emacs.scm (emacs-skewer-mode): Include html and js files.
---
 gnu/packages/emacs.scm | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 2b82ced4e..5839f0faf 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -1979,6 +1979,9 @@ serve files and directory listings.")
     (propagated-inputs
      `(("emacs-simple-httpd" ,emacs-simple-httpd)
        ("emacs-js2-mode" ,emacs-js2-mode)))
+    (arguments
+     '(#:include
+       '("\\.el$" "\\.js$" "\\.html$")))
     (home-page "https://github.com/skeeto/skewer-mode")
     (synopsis "Live web development in Emacs")
     (description
-- 
2.14.1
Reply sent to Alex Kost <alezost <at> gmail.com>:
You have taken responsibility. (Tue, 19 Sep 2017 16:49:01 GMT) Full text and rfc822 format available.
Notification sent to Oleg Pykhalov <go.wigust <at> gmail.com>:
bug acknowledged by developer. (Tue, 19 Sep 2017 16:49:02 GMT) Full text and rfc822 format available.

Message #16 received at 28381-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 28381-done <at> debbugs.gnu.org
Subject: Re: [bug#28381] [PATCH] gnu: emacs-skewer-mode: Install html and js
 files.
Date: Tue, 19 Sep 2017 19:48:12 +0300

Oleg Pykhalov (2017-09-17 12:15 +0300) wrote:

> Hello Alex,
>
> Alex Kost <alezost <at> gmail.com> writes:
[...]
>> I think it would be easier to use '#:include' instead of this phase,
>> like this:
>>
>>     (arguments '(#:include '("\\.el$" "\\.js$" "\\.html$")))
>>
>> What do you think?  If it is OK for you, could you please send an
>> updated patch?
>
> Sure, it's better.  Thanks for great suggestion.
>
>>From 595a0e662d9e18f366870497555dee77ea22dae2 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust <at> gmail.com>
> Date: Sun, 17 Sep 2017 12:08:11 +0300
> Subject: [PATCH] gnu: emacs-skewer-mode: Include html and js files.

Great, thank you!  Applied:

http://git.savannah.gnu.org/cgit/guix.git/commit/?id=46f5ae0b35c14cd733fd34e46c675e33c6c15682

-- 
Alex
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 18 Oct 2017 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 304 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.