GNU bug report logs - #28136
[PATCH] gnu: Remove libgames-support.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28136 in the body.
You can then email your comments to 28136 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Remove libgames-support.
Date: Fri, 18 Aug 2017 15:16:01 +0200

It was simply the old name (and version) of libgnome-games-support.

* gnu/packages/gnome.scm (libgames-support): Remove variable.  Move the
inherited fields...
(libgnome-games-support): ...to here.
---
 gnu/packages/gnome.scm | 28 +++++++---------------------
 1 file changed, 7 insertions(+), 21 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index f17db8fe1..f14315593 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -3335,10 +3335,10 @@ write applications that need to store structured data as well as make complex
 queries upon that data.")
     (license license:lgpl2.1+)))
 
-(define-public libgames-support
+(define-public libgnome-games-support
   (package
-    (name "libgames-support")
-    (version "1.0.2")
+    (name "libgnome-games-support")
+    (version "1.2.2")
     (source (origin
               (method url-fetch)
               (uri (string-append "mirror://gnome/sources/" name "/"
@@ -3346,14 +3346,14 @@ queries upon that data.")
                                   name "-" version ".tar.xz"))
               (sha256
                (base32
-                "0rms2ksiv7j9944km7r87q22nh05si1fisn5xm3z4zy5vpcfi5mh"))))
+                "04qbgcgmc01sinhbqdljiny8q868l01nkdawj8wrnqnd1i8czvsg"))))
     (build-system gnu-build-system)
     (arguments
      '(#:phases
        (modify-phases %standard-phases
          (add-before 'check 'pre-check
            (lambda _
-             ;; tests require a writable HOME.
+             ;; Tests require a writable HOME.
              (setenv "HOME" (getcwd))
              #t)))))
     (native-inputs
@@ -3361,30 +3361,16 @@ queries upon that data.")
        ("pkg-config" ,pkg-config)
        ("vala" ,vala)))
     (propagated-inputs
-     ;; Required by libgames-support-1.0.pc
+     ;; Required by libgnome-games-support-1.0.pc
      `(("gtk+" ,gtk+)
        ("libgee" ,libgee)))
     (home-page "https://www.gnome.org/")
     (synopsis "Useful functionality shared among GNOME games")
     (description
-     "libgames-support is a small library intended for internal use by
+     "libgnome-games-support is a small library intended for internal use by
 GNOME Games, but it may be used by others.")
     (license license:lgpl3+)))
 
-(define-public libgnome-games-support
-  (package
-    (inherit libgames-support)
-    (name "libgnome-games-support")
-    (version "1.2.2")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "mirror://gnome/sources/" name "/"
-                                  (version-major+minor version) "/"
-                                  name "-" version ".tar.xz"))
-              (sha256
-               (base32
-                "04qbgcgmc01sinhbqdljiny8q868l01nkdawj8wrnqnd1i8czvsg"))))))
-
 (define-public gnome-klotski
   (package
     (name "gnome-klotski")
-- 
2.13.1

Message #8 received at 28136 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>, 28136 <at> debbugs.gnu.org
Subject: Re: [bug#28136] [PATCH] gnu: Remove libgames-support.
Date: Fri, 18 Aug 2017 22:23:49 +0200

[Message part 1 (text/plain, inline)]

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:

> It was simply the old name (and version) of libgnome-games-support.
>
> * gnu/packages/gnome.scm (libgames-support): Remove variable.  Move the
> inherited fields...
> (libgnome-games-support): ...to here.

LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 28136-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: mbakke <at> fastmail.com, 28136-done <at> debbugs.gnu.org
Subject: Re: [bug#28136] [PATCH] gnu: Remove libgames-support.
Date: Sat, 19 Aug 2017 02:18:46 +0200

[Message part 1 (text/plain, inline)]

Marius Bakke wrote on 18/08/17 at 22:23:
> Tobias Geerinckx-Rice <me <at> tobias.gr> writes:
> 
>> It was simply the old name (and version) of libgnome-games-support.
>>
>> * gnu/packages/gnome.scm (libgames-support): Remove variable.  Move the
>> inherited fields...
>> (libgnome-games-support): ...to here.
> 
> LGTM.

Thanks! Pushed.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.