GNU bug report logs - #28137
[PATCH] gnu: Add python-pyalsaaudio.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28137 in the body.
You can then email your comments to 28137 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: guix-patches <at> gnu.org
Cc: Danny Milosavljevic <dannym <at> scratchpost.org>
Subject: [PATCH] gnu: Add python-pyalsaaudio.
Date: Fri, 18 Aug 2017 16:51:28 +0200

* gnu/packages/audio.scm (python-pyalsaaudio, python2-pyalsaaudio): New
variables.
---
 gnu/packages/audio.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
index 40700cae3..5897e5f18 100644
--- a/gnu/packages/audio.scm
+++ b/gnu/packages/audio.scm
@@ -2906,3 +2906,47 @@ code, used in @code{libtoxcore}.")
 06.10 RPE-LTP lossy speech compression algorithm.")
     (home-page "http://quut.com/gsm/")
     (license (license:non-copyleft "file://COPYRIGHT"))))
+
+(define-public python-pyalsaaudio
+  (package
+    (name "python-pyalsaaudio")
+    (version "0.8.4")
+    (source
+      (origin
+        (method url-fetch)
+        (uri (pypi-uri "pyalsaaudio" version))
+        (sha256
+          (base32
+            "1180ypn9596rq4b7y7dyv627j1q0fqilmkkrckclnzsdakdgis44"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #f ; FIXME
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'setup-alsa
+           (lambda _
+             (mkdir-p "/tmp/foo")
+             (setenv "HOME" "/tmp/foo")
+             ;; TODO use snd-dummy kernel module.
+             (call-with-output-file "/tmp/foo/.asoundrc"
+               (lambda (port)
+                 (format port "
+pcm.!default {
+    type hw
+    card 0
+}
+ctl.!default {
+    type hw
+    card 0
+}
+")))
+             #t)))))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)))
+    (home-page "http://larsimmisch.github.io/pyalsaaudio/")
+    (synopsis "ALSA bindings for Python")
+    (description "@code{pyalsaaudio} provides ALSA bindings for Python.")
+    (license license:psfl)))
+
+(define-public python2-pyalsaaudio
+  (package-with-python2 python-pyalsaaudio))

Message #8 received at 28137 <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28137 <at> debbugs.gnu.org
Subject: Re: [bug#28137] [PATCH] gnu: Add python-pyalsaaudio.
Date: Wed, 23 Aug 2017 21:22:16 +0800

[Message part 1 (text/plain, inline)]

Hello!

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> * gnu/packages/audio.scm (python-pyalsaaudio, python2-pyalsaaudio): New
> variables.
> ---
>  gnu/packages/audio.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)
>
> diff --git a/gnu/packages/audio.scm b/gnu/packages/audio.scm
> index 40700cae3..5897e5f18 100644
> --- a/gnu/packages/audio.scm
> +++ b/gnu/packages/audio.scm
> @@ -2906,3 +2906,47 @@ code, used in @code{libtoxcore}.")
>  06.10 RPE-LTP lossy speech compression algorithm.")
>      (home-page "http://quut.com/gsm/")
>      (license (license:non-copyleft "file://COPYRIGHT"))))
> +
> +(define-public python-pyalsaaudio
> +  (package
> +    (name "python-pyalsaaudio")
> +    (version "0.8.4")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "pyalsaaudio" version))
> +        (sha256
> +          (base32
> +            "1180ypn9596rq4b7y7dyv627j1q0fqilmkkrckclnzsdakdgis44"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:tests? #f ; FIXME
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'setup-alsa
> +           (lambda _
> +             (mkdir-p "/tmp/foo")
> +             (setenv "HOME" "/tmp/foo")
> +             ;; TODO use snd-dummy kernel module.
> +             (call-with-output-file "/tmp/foo/.asoundrc"
> +               (lambda (port)
> +                 (format port "
> +pcm.!default {
> +    type hw
> +    card 0
> +}
> +ctl.!default {
> +    type hw
> +    card 0
> +}
> +")))
> +             #t)))))

Do you managed to pass these tests with snd-dummy loaded?  I think there
is no way to load kernel modules to the builder, how about simply leave
a comment?


> +    (inputs
> +     `(("alsa-lib" ,alsa-lib)))
> +    (home-page "http://larsimmisch.github.io/pyalsaaudio/")
> +    (synopsis "ALSA bindings for Python")
> +    (description "@code{pyalsaaudio} provides ALSA bindings for
> Python.")

Its README.md file provides more description.


Here is my update for this patch:

[0001-gnu-Add-python-pyalsaaudio.patch (text/x-patch, attachment)]

Message #11 received at 28137 <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: iyzsong <at> member.fsf.org (宋文武)
Cc: 28137 <at> debbugs.gnu.org
Subject: Re: [bug#28137] [PATCH] gnu: Add python-pyalsaaudio.
Date: Tue, 29 Aug 2017 08:20:09 +0200

Hi,

On Wed, 23 Aug 2017 21:22:16 +0800
iyzsong <at> member.fsf.org (宋文武) wrote:

> Do you managed to pass these tests with snd-dummy loaded?  

No.  I should have marked the patch WIP.

>I think there
> is no way to load kernel modules to the builder, how about simply leave
> a comment?

Yeah.

> > +    (inputs
> > +     `(("alsa-lib" ,alsa-lib)))
> > +    (home-page "http://larsimmisch.github.io/pyalsaaudio/")
> > +    (synopsis "ALSA bindings for Python")
> > +    (description "@code{pyalsaaudio} provides ALSA bindings for
> > Python.")  
> 
> Its README.md file provides more description.
> 
> 
> Here is my update for this patch:

Thanks! LGTM!

Message #16 received at 28137-done <at> debbugs.gnu.org (full text, mbox):

From: iyzsong <at> member.fsf.org (宋文武)
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28137-done <at> debbugs.gnu.org
Subject: Re: [bug#28137] [PATCH] gnu: Add python-pyalsaaudio.
Date: Tue, 29 Aug 2017 20:07:54 +0800

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

>> Here is my update for this patch:
>
> Thanks! LGTM!

Pushed, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.