GNU bug report logs - #28135
Updating gobby

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28135 in the body.
You can then email your comments to 28135 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: guix-patches <at> gnu.org
Subject: Updating gobby
Date: Fri, 18 Aug 2017 14:56:32 +0530

Patches updating gobby coming through...

Message #8 received at 28135 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 28135 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 2/2] gnu: gobby: Update to 0.5.0.
Date: Fri, 18 Aug 2017 15:01:57 +0530

* gnu/packages/gobby.scm (gobby): Update to 0.5.0.
[inputs]: Remove libnet6 and obby. Add libinfinity. Sort.
[arguments]: Add move-executable phase.
---
 gnu/packages/gobby.scm | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/gobby.scm b/gnu/packages/gobby.scm
index e85f86061..f4e57557a 100644
--- a/gnu/packages/gobby.scm
+++ b/gnu/packages/gobby.scm
@@ -101,7 +101,7 @@ documents in one session.  Obby is used by the Gobby collaborative editor.")
 (define-public gobby
   (package
     (name "gobby")
-    (version "0.4.13")
+    (version "0.5.0")
     (source (origin
               (method url-fetch)
               (uri (string-append "http://releases.0x539.de/gobby/gobby-"
@@ -109,21 +109,28 @@ documents in one session.  Obby is used by the Gobby collaborative editor.")
               (file-name (string-append name "-" version ".tar.gz"))
               (sha256
                (base32
-                "0w8q01lf6bcdz537b29m7rwlbc7k87b12vnpm1h6219ypvzqkgcc"))))
+                "165x0r668ma5blziisvbr8qig3jw9hf7i6w8r7wwvz3wsac3bswc"))))
     (build-system gnu-build-system)
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("intltool" ,intltool)))
     (inputs
-     `(("libxml++-2" ,libxml++-2)
-       ("gnutls" ,gnutls)
+     `(("gnutls" ,gnutls)
+       ("gsasl" ,gsasl)
        ("gtkmm-2" ,gtkmm-2)
        ("gtksourceview-2" ,gtksourceview-2)
-       ("libnet6" ,libnet6)
-       ("obby" ,obby)))
+       ("libinfinity" ,libinfinity)
+       ("libxml++-2" ,libxml++-2)))
     (arguments
      ;; Required by libsigc++.
-     `(#:configure-flags '("CXXFLAGS=-std=c++11")))
+     `(#:configure-flags '("CXXFLAGS=-std=c++11")
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'move-executable
+           (lambda* (#:key outputs #:allow-other-keys)
+             (with-directory-excursion (assoc-ref outputs "out")
+               (rename-file "bin/gobby-0.5" "bin/gobby"))
+             #t)))))
     (home-page "https://gobby.github.io/")
     (synopsis "Collaborative editor")
     (description
-- 
2.13.4

Message #11 received at 28135 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: 28135 <at> debbugs.gnu.org
Cc: Arun Isaac <arunisaac <at> systemreboot.net>
Subject: [PATCH 1/2] gnu: Add libinfinity.
Date: Fri, 18 Aug 2017 15:01:56 +0530

* gnu/packages/gobby.scm (libinfinity): New variable.
---
 gnu/packages/gobby.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/gobby.scm b/gnu/packages/gobby.scm
index 961028d00..e85f86061 100644
--- a/gnu/packages/gobby.scm
+++ b/gnu/packages/gobby.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Andy Wingo <wingo <at> igalia.com>
+;;; Copyright © 2017 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -25,6 +26,7 @@
   #:use-module (gnu packages)
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnome)
+  #:use-module (gnu packages gsasl)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages tls)
@@ -129,3 +131,34 @@ documents in one session.  Obby is used by the Gobby collaborative editor.")
 a multi-user chat.  Gobby allows multiple users to edit the same document
 together over the internet in real-time.")
     (license license:gpl2+)))
+
+(define-public libinfinity
+  (package
+    (name "libinfinity")
+    (version "0.6.8")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "http://releases.0x539.de/libinfinity/libinfinity-"
+                           version ".tar.gz"))
+       (sha256
+        (base32
+         "0nylsb6qz9pjw3agjp27c4za205i6zg6i5g1vgs5vbdnbh77wkhc"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("glib" ,glib)
+       ("gsasl" ,gsasl)
+       ("gtk+" ,gtk+-2)
+       ("libxml2" ,libxml2)))
+    (native-inputs
+     `(("pkg-config" ,pkg-config)))
+    (arguments
+     `(#:configure-flags (list "--with-inftextgtk"
+                               "--with-infgtk")))
+    (home-page "https://gobby.github.io/")
+    (synopsis "Infininote protocol implementation")
+    (description "Gobby is a collaborative editor that allows multiple users
+to edit the same document together over the internet in real-time.  The
+libinfinity shared library contains the implementation of the protocol that is
+used to synchronize document changes between users.")
+    (license license:isc)))
-- 
2.13.4

Message #14 received at 28135 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 28135 <at> debbugs.gnu.org
Subject: Re: [bug#28135] [PATCH 2/2] gnu: gobby: Update to 0.5.0.
Date: Fri, 18 Aug 2017 22:12:46 +0200

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/gobby.scm (gobby): Update to 0.5.0.
> [inputs]: Remove libnet6 and obby. Add libinfinity. Sort.
> [arguments]: Add move-executable phase.

LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 28135 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 28135 <at> debbugs.gnu.org
Subject: Re: [bug#28135] [PATCH 1/2] gnu: Add libinfinity.
Date: Fri, 18 Aug 2017 22:21:43 +0200

[Message part 1 (text/plain, inline)]

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> * gnu/packages/gobby.scm (libinfinity): New variable.

[...]

> +    (synopsis "Infininote protocol implementation")
> +    (description "Gobby is a collaborative editor that allows multiple users
> +to edit the same document together over the internet in real-time.  The
> +libinfinity shared library contains the implementation of the protocol that is
> +used to synchronize document changes between users.")

I'm not sure if repeating the Gobby description in the first sentence is
necessary.  The description from their README is pretty good:

libinfinity is library to build collaborative text editors. Changes to
the text buffers are synced to all other clients over a central
server. Even though a central server is involved, the local user sees
his changes applied instantly and the merging is done on the individual
clients.

> +    (license license:isc)))

COPYING and the source files I looked at say LGPL2.1+.  Can you check?

The rest LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 28135-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 28135-done <at> debbugs.gnu.org
Subject: Re: [bug#28135] [PATCH 1/2] gnu: Add libinfinity.
Date: Sun, 20 Aug 2017 10:56:40 +0530

Marius Bakke writes:

> Arun Isaac <arunisaac <at> systemreboot.net> writes:
>
>> * gnu/packages/gobby.scm (libinfinity): New variable.
>
> [...]
>
>> +    (synopsis "Infininote protocol implementation")
>> +    (description "Gobby is a collaborative editor that allows multiple users
>> +to edit the same document together over the internet in real-time.  The
>> +libinfinity shared library contains the implementation of the protocol that is
>> +used to synchronize document changes between users.")
>
> I'm not sure if repeating the Gobby description in the first sentence is
> necessary.  The description from their README is pretty good:
>
> libinfinity is library to build collaborative text editors. Changes to
> the text buffers are synced to all other clients over a central
> server. Even though a central server is involved, the local user sees
> his changes applied instantly and the merging is done on the individual
> clients.
>
>> +    (license license:isc)))
>
> COPYING and the source files I looked at say LGPL2.1+.  Can you check?
>
> The rest LGTM.

Fixed both issues and pushed! Thanks for the review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.