GNU bug report logs - #28061
[PATCH] gnu: moreutils: Add more inputs to moreutils.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Subject: bug#28061: closed (Re: [bug#28061] [PATCH] gnu: moreutils: Add
 more inputs to moreutils.)
Date: Sat, 12 Aug 2017 21:12:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#28061: [PATCH] gnu: moreutils: Add more inputs to moreutils.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 28061 <at> debbugs.gnu.org.

-- 
28061: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28061
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 28061-done <at> debbugs.gnu.org
Subject: Re: [bug#28061] [PATCH] gnu: moreutils: Add more inputs to moreutils.
Date: Sat, 12 Aug 2017 22:11:27 +0100

[Message part 3 (text/plain, inline)]

On Sat, 12 Aug 2017 14:18:26 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Christopher Baines <mail <at> cbaines.net> writes:
> 
> > ts requires the Time::Duration and Date::Parse perl modules for the
> > -r option.
> >
> > * gnu/packages/moreutils.scm (moreutils)[inputs]: Add perl-timedate
> > and perl-time-duration.
> >   [arguments]: Wrap ts with PERL5LIB.  
> 
> LGTM. Hopefully we can get #27003 et.al in with the next core-updates
> cycle so the wrapping is done automatically.

Thanks for your review Marius :) I've now pushed this.

[Message part 4 (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: moreutils: Add more inputs to moreutils.
Date: Sat, 12 Aug 2017 12:43:39 +0100

ts requires the Time::Duration and Date::Parse perl modules for the -r option.

* gnu/packages/moreutils.scm (moreutils)[inputs]: Add perl-timedate and
  perl-time-duration.
  [arguments]: Wrap ts with PERL5LIB.
---
 gnu/packages/moreutils.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/moreutils.scm b/gnu/packages/moreutils.scm
index 03ffa8f99..bb6228af7 100644
--- a/gnu/packages/moreutils.scm
+++ b/gnu/packages/moreutils.scm
@@ -52,10 +52,18 @@
        ("libxml2" ,libxml2)
        ("libxslt" ,libxslt)))
     (inputs
-     `(("perl" ,perl)))
+     `(("perl" ,perl)
+       ("perl-timedate" ,perl-timedate)
+       ("perl-time-duration" ,perl-time-duration)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out")))
+                        (wrap-program
+                            (string-append out "/bin/ts")
+                          `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB")))))))
          (delete 'configure))           ; no configure script
        #:make-flags
        (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
-- 
2.13.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.