GNU bug report logs - #28060
[PATCH] gnu: Add emacs-nixos-mode.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28060 in the body.
You can then email your comments to 28060 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 10:02:42 +0300

[0001-gnu-Add-emacs-nixos-mode.patch (text/x-patch, inline)]

From 90ef6b8f1bf57820db95d7daf17f7e0fae303356 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 12 Aug 2017 09:48:53 +0300
Subject: [PATCH] gnu: Add emacs-nixos-mode.

* gnu/packages/emacs.scm (emacs-nixos-mode): New variable.
---
 gnu/packages/emacs.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index bb5d2349f..adf1ef167 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5331,3 +5331,29 @@ enables you to easily define search engines, bind them to keybindings, and
 query them from the comfort of your editor.")
     (home-page "https://github.com/hrs/engine-mode")
     (license license:gpl3+)))
+
+(define-public emacs-nixos-mode
+  (package
+    (name "emacs-nixos-mode")
+    (version "1.11.13")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/NixOS/nix/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "12110drl51r9bi45ql865jwvax1gladb5hfpwk0vi5bjybns6c9b"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'chdir-elisp
+           (lambda _
+             (chdir "misc/emacs"))))))
+    (synopsis "Emacs major mode for editing Nix expressions")
+    (description "@code{nixos-mode} provides an Emacs major mode for editing
+Nix expressions.")
+    (home-page "https://github.com/NixOS/nix")
+    (license license:gpl3+)))
-- 
2.14.1

Message #8 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 20:36:28 +0530

Thanks for the patch!

Oleg Pykhalov writes:

> +(define-public emacs-nixos-mode
> +  (package
> +    (name "emacs-nixos-mode")
> +    (version "1.11.13")

misc/emacs/nix-mode.el says the version number is 1.0. This contradicts
the release version number 1.11.13. But, I guess we can go with the
release version number.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'chdir-elisp
> +           (lambda _
> +             (chdir "misc/emacs"))))))

It is kinda obvious, but do add a short comment explaining why we are
changing directory.

> +    (synopsis "Emacs major mode for editing Nix expressions")
> +    (description "@code{nixos-mode} provides an Emacs major mode for editing
> +Nix expressions.")

Could you add the following line to the description?

"It supports syntax highlighting, indenting and refilling of comments."

I have taken the above sentence from
https://github.com/NixOS/nix/blob/master/misc/emacs/README

> +    (license license:gpl3+)))

Nix is under the LGPL 2.1 license. So, nix-mode should also be under the
same license, right?

Could you send an updated patch? Thanks!

Message #11 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>, 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 16:46:29 +0000

[Message part 1 (text/plain, inline)]

Arun Isaac transcribed 1.1K bytes:
> 
> Thanks for the patch!
> 
> Oleg Pykhalov writes:
> 
> > +(define-public emacs-nixos-mode
> > +  (package
> > +    (name "emacs-nixos-mode")
> > +    (version "1.11.13")
> 
> misc/emacs/nix-mode.el says the version number is 1.0. This contradicts
> the release version number 1.11.13. But, I guess we can go with the
> release version number.
> 
> > +    (arguments
> > +     `(#:phases
> > +       (modify-phases %standard-phases
> > +         (add-after 'unpack 'chdir-elisp
> > +           (lambda _
> > +             (chdir "misc/emacs"))))))
> 
> It is kinda obvious, but do add a short comment explaining why we are
> changing directory.
> 
> > +    (synopsis "Emacs major mode for editing Nix expressions")
> > +    (description "@code{nixos-mode} provides an Emacs major mode for editing
> > +Nix expressions.")
> 
> Could you add the following line to the description?
> 
> "It supports syntax highlighting, indenting and refilling of comments."
> 
> I have taken the above sentence from
> https://github.com/NixOS/nix/blob/master/misc/emacs/README
> 
> > +    (license license:gpl3+)))
> 
> Nix is under the LGPL 2.1 license. So, nix-mode should also be under the
> same license, right?
> 
> Could you send an updated patch? Thanks!

We have Nix in (gnu packages package-management).
Why do you fetch it again when we could just add
another output to the nix package?
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 19:56:00 +0300

[Message part 1 (text/plain, inline)]

Hello Arun,

thank you for supporting this patch.

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> Thanks for the patch!
>
> Oleg Pykhalov writes:

…

>> +    (arguments
>> +     `(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'chdir-elisp
>> +           (lambda _
>> +             (chdir "misc/emacs"))))))
>
> It is kinda obvious, but do add a short comment explaining why we are
> changing directory.

DONE.

>> +    (synopsis "Emacs major mode for editing Nix expressions")
>> +    (description "@code{nixos-mode} provides an Emacs major mode for editing
>> +Nix expressions.")
>
> Could you add the following line to the description?
>
> "It supports syntax highlighting, indenting and refilling of comments."
>
> I have taken the above sentence from
> https://github.com/NixOS/nix/blob/master/misc/emacs/README

DONE.

>> +    (license license:gpl3+)))
>
> Nix is under the LGPL 2.1 license. So, nix-mode should also be under the
> same license, right?

DONE.

> Could you send an updated patch? Thanks!

[0001-gnu-Add-emacs-nixos-mode.patch (text/x-patch, inline)]

From 796f6a09c9464812f85c77641473ac9c85ac9654 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 12 Aug 2017 09:48:53 +0300
Subject: [PATCH] gnu: Add emacs-nixos-mode.

* gnu/packages/emacs.scm (emacs-nixos-mode): New variable.
---
 gnu/packages/emacs.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index bb5d2349f..cdee59858 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5331,3 +5331,31 @@ enables you to easily define search engines, bind them to keybindings, and
 query them from the comfort of your editor.")
     (home-page "https://github.com/hrs/engine-mode")
     (license license:gpl3+)))
+
+(define-public emacs-nixos-mode
+  (package
+    (name "emacs-nixos-mode")
+    (version "1.11.13")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/NixOS/nix/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "12110drl51r9bi45ql865jwvax1gladb5hfpwk0vi5bjybns6c9b"))))
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'chdir-elisp
+           ;; Elisp directory is not in root of the source.
+           (lambda _
+             (chdir "misc/emacs"))))))
+    (synopsis "Emacs major mode for editing Nix expressions")
+    (description "@code{nixos-mode} provides an Emacs major mode for editing
+Nix expressions.  It supports syntax highlighting, indenting and refilling of
+comments.")
+    (home-page "https://github.com/NixOS/nix")
+    (license license:lgpl2.1+)))
-- 
2.14.1

[Message part 3 (text/plain, inline)]

-- 
Best regards,

Oleg.

Message #17 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 20:14:14 +0300

Hello ng0,

ng0 <ng0 <at> infotropique.org> writes:

…

> We have Nix in (gnu packages package-management).
> Why do you fetch it again when we could just add
> another output to the nix package?

Didn't think about this.  It will not fetch again if sources are same, I
guess.  But it will be more proper way for sure.  The problem is that
I'm not very familiar with mixing build systems for now.  This bug
report probably needs to wait me or somebody else will do it.

-- 
Best regards,

Oleg.

Message #20 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 17:52:19 +0000

[Message part 1 (text/plain, inline)]

Oleg Pykhalov transcribed 0.5K bytes:
> Hello ng0,
> 
> ng0 <ng0 <at> infotropique.org> writes:
> 
> …
> 
> > We have Nix in (gnu packages package-management).
> > Why do you fetch it again when we could just add
> > another output to the nix package?
> 
> Didn't think about this.  It will not fetch again if sources are same, I
> guess.  But it will be more proper way for sure.  The problem is that
> I'm not very familiar with mixing build systems for now.  This bug
> report probably needs to wait me or somebody else will do it.
> 
> -- 
> Best regards,
> 
> Oleg.

Two other options:
 - Could you ask upstream to unbundle it?
 - Could we just get the file(s) needed as inputs on their own
   and use that?
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 17:53:46 +0000

[Message part 1 (text/plain, inline)]

Oleg Pykhalov transcribed 0.5K bytes:
> Hello ng0,
> 
> ng0 <ng0 <at> infotropique.org> writes:
> 
> …
> 
> > We have Nix in (gnu packages package-management).
> > Why do you fetch it again when we could just add
> > another output to the nix package?
> 
> Didn't think about this.  It will not fetch again if sources are same, I
> guess.  But it will be more proper way for sure.  The problem is that
> I'm not very familiar with mixing build systems for now.  This bug
> report probably needs to wait me or somebody else will do it.
> 
> -- 
> Best regards,
> 
> Oleg.

Yet another option: inherit the package "nix" and adjust accordingly.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: ng0 <ng0 <at> infotropique.org>, 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 21:32:49 +0300

[Message part 1 (text/plain, inline)]

ng0 <ng0 <at> infotropique.org> writes:

…

>> > We have Nix in (gnu packages package-management).
>> > Why do you fetch it again when we could just add
>> > another output to the nix package?
>> 
>> Didn't think about this.  It will not fetch again if sources are same, I
>> guess.  But it will be more proper way for sure.  The problem is that
>> I'm not very familiar with mixing build systems for now.  This bug
>> report probably needs to wait me or somebody else will do it.

…

> Yet another option: inherit the package "nix" and adjust accordingly.

I think this is the best option.

[0001-gnu-Add-emacs-nix-mode.patch (text/x-patch, inline)]

From b69c7020ba88f541666eda41753540e571666607 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 12 Aug 2017 09:48:53 +0300
Subject: [PATCH] gnu: Add emacs-nix-mode.

* gnu/packages/emacs.scm (emacs-nix-mode): New variable.
---
 gnu/packages/emacs.scm | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index bb5d2349f..e728419a2 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5226,6 +5226,24 @@ multiplexer.")
 editing RPM spec files.")
     (license license:gpl2+)))
 
+(define-public emacs-nix-mode
+  (package
+    (inherit nix)
+    (name "emacs-nix-mode")
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'chdir-elisp
+           ;; Elisp directory is not in root of the source.
+           (lambda _
+             (chdir "misc/emacs"))))))
+    (synopsis "Emacs major mode for editing Nix expressions")
+    (description "@code{nixos-mode} provides an Emacs major mode for editing
+Nix expressions.  It supports syntax highlighting, indenting and refilling of
+comments.")
+    (license license:lgpl2.1+)))
+
 (define-public emacs-git-messenger
   (package
     (name "emacs-git-messenger")
-- 
2.14.1

[Message part 3 (text/plain, inline)]

-- 
Best regards,

Oleg.

Message #29 received at 28060 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: ng0 <ng0 <at> infotropique.org>, 28060 <at> debbugs.gnu.org
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 21:39:52 +0300

[Message part 1 (text/plain, inline)]

Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> ng0 <ng0 <at> infotropique.org> writes:
>
> …
>
>>> > We have Nix in (gnu packages package-management).
>>> > Why do you fetch it again when we could just add
>>> > another output to the nix package?
>>> 
>>> Didn't think about this.  It will not fetch again if sources are same, I
>>> guess.  But it will be more proper way for sure.  The problem is that
>>> I'm not very familiar with mixing build systems for now.  This bug
>>> report probably needs to wait me or somebody else will do it.
>
> …
>
>> Yet another option: inherit the package "nix" and adjust accordingly.
>
> I think this is the best option.

Don't need the license field.

[0001-gnu-Add-emacs-nix-mode.patch (text/x-patch, inline)]

From 0ab1fceaf6eead2c72b4764ce91ecfe005097de4 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust <at> gmail.com>
Date: Sat, 12 Aug 2017 09:48:53 +0300
Subject: [PATCH] gnu: Add emacs-nix-mode.

* gnu/packages/emacs.scm (emacs-nix-mode): New variable.
---
 gnu/packages/emacs.scm | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index bb5d2349f..5a69990c6 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -5226,6 +5226,23 @@ multiplexer.")
 editing RPM spec files.")
     (license license:gpl2+)))
 
+(define-public emacs-nix-mode
+  (package
+    (inherit nix)
+    (name "emacs-nix-mode")
+    (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'chdir-elisp
+           ;; Elisp directory is not in root of the source.
+           (lambda _
+             (chdir "misc/emacs"))))))
+    (synopsis "Emacs major mode for editing Nix expressions")
+    (description "@code{nixos-mode} provides an Emacs major mode for editing
+Nix expressions.  It supports syntax highlighting, indenting and refilling of
+comments.")))
+
 (define-public emacs-git-messenger
   (package
     (name "emacs-git-messenger")
-- 
2.14.1

[Message part 3 (text/plain, inline)]

-- 
Best regards,

Oleg.

Message #34 received at 28060-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 28060-done <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sun, 13 Aug 2017 13:24:21 +0530

>>> Yet another option: inherit the package "nix" and adjust accordingly.

Good idea!

Pushed, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.