GNU bug report logs - #28061
[PATCH] gnu: moreutils: Add more inputs to moreutils.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28061 in the body.
You can then email your comments to 28061 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: moreutils: Add more inputs to moreutils.
Date: Sat, 12 Aug 2017 12:43:39 +0100

ts requires the Time::Duration and Date::Parse perl modules for the -r option.

* gnu/packages/moreutils.scm (moreutils)[inputs]: Add perl-timedate and
  perl-time-duration.
  [arguments]: Wrap ts with PERL5LIB.
---
 gnu/packages/moreutils.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/moreutils.scm b/gnu/packages/moreutils.scm
index 03ffa8f99..bb6228af7 100644
--- a/gnu/packages/moreutils.scm
+++ b/gnu/packages/moreutils.scm
@@ -52,10 +52,18 @@
        ("libxml2" ,libxml2)
        ("libxslt" ,libxslt)))
     (inputs
-     `(("perl" ,perl)))
+     `(("perl" ,perl)
+       ("perl-timedate" ,perl-timedate)
+       ("perl-time-duration" ,perl-time-duration)))
     (arguments
      `(#:phases
        (modify-phases %standard-phases
+         (add-after 'install 'wrap-program
+                    (lambda* (#:key outputs #:allow-other-keys)
+                      (let* ((out (assoc-ref outputs "out")))
+                        (wrap-program
+                            (string-append out "/bin/ts")
+                          `("PERL5LIB" ":" prefix (,(getenv "PERL5LIB")))))))
          (delete 'configure))           ; no configure script
        #:make-flags
        (list (string-append "PREFIX=" (assoc-ref %outputs "out"))
-- 
2.13.1

Message #8 received at 28061 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Christopher Baines <mail <at> cbaines.net>, 28061 <at> debbugs.gnu.org
Subject: Re: [bug#28061] [PATCH] gnu: moreutils: Add more inputs to moreutils.
Date: Sat, 12 Aug 2017 14:18:26 +0200

[Message part 1 (text/plain, inline)]

Christopher Baines <mail <at> cbaines.net> writes:

> ts requires the Time::Duration and Date::Parse perl modules for the -r option.
>
> * gnu/packages/moreutils.scm (moreutils)[inputs]: Add perl-timedate and
>   perl-time-duration.
>   [arguments]: Wrap ts with PERL5LIB.

LGTM. Hopefully we can get #27003 et.al in with the next core-updates
cycle so the wrapping is done automatically.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 28061-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 28061-done <at> debbugs.gnu.org
Subject: Re: [bug#28061] [PATCH] gnu: moreutils: Add more inputs to moreutils.
Date: Sat, 12 Aug 2017 22:11:27 +0100

[Message part 1 (text/plain, inline)]

On Sat, 12 Aug 2017 14:18:26 +0200
Marius Bakke <mbakke <at> fastmail.com> wrote:

> Christopher Baines <mail <at> cbaines.net> writes:
> 
> > ts requires the Time::Duration and Date::Parse perl modules for the
> > -r option.
> >
> > * gnu/packages/moreutils.scm (moreutils)[inputs]: Add perl-timedate
> > and perl-time-duration.
> >   [arguments]: Wrap ts with PERL5LIB.  
> 
> LGTM. Hopefully we can get #27003 et.al in with the next core-updates
> cycle so the wrapping is done automatically.

Thanks for your review Marius :) I've now pushed this.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.