GNU bug report logs - #28060
[PATCH] gnu: Add emacs-nixos-mode.

Previous Next

Full log

View this message in rfc822 format

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 28060 <at> debbugs.gnu.org
Subject: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Date: Sat, 12 Aug 2017 20:36:28 +0530

Thanks for the patch!

Oleg Pykhalov writes:

> +(define-public emacs-nixos-mode
> +  (package
> +    (name "emacs-nixos-mode")
> +    (version "1.11.13")

misc/emacs/nix-mode.el says the version number is 1.0. This contradicts
the release version number 1.11.13. But, I guess we can go with the
release version number.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'chdir-elisp
> +           (lambda _
> +             (chdir "misc/emacs"))))))

It is kinda obvious, but do add a short comment explaining why we are
changing directory.

> +    (synopsis "Emacs major mode for editing Nix expressions")
> +    (description "@code{nixos-mode} provides an Emacs major mode for editing
> +Nix expressions.")

Could you add the following line to the description?

"It supports syntax highlighting, indenting and refilling of comments."

I have taken the above sentence from
https://github.com/NixOS/nix/blob/master/misc/emacs/README

> +    (license license:gpl3+)))

Nix is under the LGPL 2.1 license. So, nix-mode should also be under the
same license, right?

Could you send an updated patch? Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.