GNU bug report logs - #27907
[PATCH] graph: Provide access to the package record in the emit

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 27907 <at> debbugs.gnu.org
Subject: [bug#27907] [PATCH] graph: Provide access to the package record in the emit
Date: Fri, 25 Aug 2017 16:50:52 +0200

Roel Janssen <roel <at> gnu.org> skribis:

> Oops!  I am sorry about this.  Would it not break if we include a check for whether
> the node type is a package or not.  Then, non-package node types are
> handled the “old way” and packages are handled the “new way”.
>
> I think we cannot have a generic way of exposing the specifics of a node
> type, so if we need to expose more information for the other node types,
> we have to add a type-specific implementation.

Actually, we might need to discuss the specifics of why you wanted to do
it in the first place.  :-)

It is to pass extra rendering info to the backends?  (It would be
helpful for instance to adjust the node color or size depending on
certain parameters such as its size or number of dependents.)

> If this sounds like a good idea I'll write a new patch.  And while I'm
> at it, what set of commands fully cover the graph code for all node
> types?  Just all variants in 'guix graph --type=X'?

“make check TESTS=tests/graph.scm” covers all the node types I think.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.