GNU bug report logs - #27906
[PATCH] r-foreign: Update hash and remove duplicate recipe.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27906 in the body.
You can then email your comments to 27906 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] r-foreign: Update hash and remove duplicate recipe.
Date: Tue, 01 Aug 2017 15:58:59 +0200

[0001-r-foreign-Update-hash-and-remove-duplicate-recipe.patch (text/x-diff, attachment)]

[Message part 2 (text/plain, inline)]

Dear Guix,

It seems we have two (almost identical) package recipes for r-foreign.
This patch removes one of them.

Also, the upstream tarball seems to have changed, so I updated the
SHA256 hash.

If someone has the old tarball, we could look at what exactly has
changed.

Kind regards,
Roel Janssen

Message #8 received at 27906 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 27906 <at> debbugs.gnu.org
Subject: re: [PATCH] r-foreign: Update hash and remove duplicate recipe.
Date: Tue, 1 Aug 2017 18:44:48 +0300

[Message part 1 (text/plain, inline)]

I have /gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz
if that would help
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz (application/x-tar-gz, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 27906 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 27906 <at> debbugs.gnu.org
Subject: Re: [bug#27906] [PATCH] r-foreign: Update hash and remove duplicate
 recipe.
Date: Tue, 01 Aug 2017 19:21:56 +0200

Efraim Flashner writes:

> I have /gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz
> if that would help

Now this is odd:
$ wget http://cran.r-project.org/src/contrib/Archive/foreign/foreign_0.8-67.tar.gz
$ tar axvf l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz 
$ mv foreign foreign-orig
$ tar axvf foreign_0.8-67.tar.gz 
$ mv foreign foreign-new
$ diff -r foreign-orig/ foreign-new/
$

So, no difference?

Let's check the tarball md5 sums:
ab00fa606625711a46c54d772c0cefe8  l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz
896db4d1a62fe09c6ecc12d759492267  foreign_0.8-67.tar.gz

Could anyone confirm that they get a different hash as well?:
guix gc -d /gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz
guix build -S r-foreign --no-substitutes

I get:
From http://cran.r-project.org/src/contrib/Archive/foreign/foreign_0.8-67.tar.gz...
 ...8-67.tar.gz  326KiB             833KiB/s 00:00 [####################] 100.0%
sha256 hash mismatch for output path `/gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz'
  expected: 1mcrm2pydimbyjhkrw5h380bifj1jhwzifph1xgh90asf3lvd1xd
  actual:   0j0z815zyp8n97rk6hlk68d1r8b26vls39s03viq0pnx3cbpwyga
@ build-failed /gnu/store/7wm6w3b4ll9nq35ldchi56mzspz4gsi8-foreign_0.8-67.tar.gz.drv - 1 sha256 hash mismatch for outp
ut path `/gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz'                                          
  expected: 1mcrm2pydimbyjhkrw5h380bifj1jhwzifph1xgh90asf3lvd1xd
  actual:   0j0z815zyp8n97rk6hlk68d1r8b26vls39s03viq0pnx3cbpwyga
guix build: error: build failed: build of `/gnu/store/7wm6w3b4ll9nq35ldchi56mzspz4gsi8-foreign_0.8-67.tar.gz.drv' fail
ed

Thanks in advance!

Kind regards,
Roel Janssen

Message #14 received at 27906 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Roel Janssen <roel <at> gnu.org>
Cc: 27906 <at> debbugs.gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#27906] [PATCH] r-foreign: Update hash and remove duplicate
 recipe.
Date: Tue, 01 Aug 2017 21:24:48 +0200

Roel Janssen <roel <at> gnu.org> skribis:

> Efraim Flashner writes:
>
>> I have /gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz
>> if that would help
>
> Now this is odd:
> $ wget http://cran.r-project.org/src/contrib/Archive/foreign/foreign_0.8-67.tar.gz

The other one is at:

  https://mirror.hydra.gnu.org/file/foreign_0.8-67.tar.gz/sha256/1mcrm2pydimbyjhkrw5h380bifj1jhwzifph1xgh90asf3lvd1xd

The contents are identical per “diff -r --no-dereference”.  However
metadata differs:

--8<---------------cut here---------------start------------->8---
ludo <at> ribbon /tmp$ tar tvf t.tgz |head
drwxr-xr-x hornik/users      0 2016-09-13 13:04 foreign/
drwxr-xr-x hornik/users      0 2014-03-28 10:08 foreign/po/
-rw-r--r-- hornik/users   5913 2012-10-04 12:33 foreign/po/R-fr.po
-rw-r--r-- hornik/users  27343 2014-03-28 10:08 foreign/po/de.po
-rw-r--r-- hornik/users  49598 2014-03-28 10:08 foreign/po/pl.po
-rw-r--r-- hornik/users   5203 2012-10-11 18:41 foreign/po/R-de.po
-rw-r--r-- hornik/users  28708 2014-03-28 10:08 foreign/po/fr.po
-rw-r--r-- hornik/users  17250 2014-03-28 10:08 foreign/po/foreign.pot
-rw-r--r-- hornik/users   2853 2014-03-28 10:08 foreign/po/R-foreign.pot
-rw-r--r-- hornik/users  10262 2014-03-28 10:08 foreign/po/R-pl.po
ludo <at> ribbon /tmp$ tar tvf foreign_0.8-67.tar.gz |head
drwxr-xr-x ligges/users      0 2016-09-13 13:04 foreign/
drwxr-xr-x ligges/users      0 2014-03-28 10:08 foreign/po/
-rw-r--r-- ligges/users   5913 2012-10-04 12:33 foreign/po/R-fr.po
-rw-r--r-- ligges/users  27343 2014-03-28 10:08 foreign/po/de.po
-rw-r--r-- ligges/users  49598 2014-03-28 10:08 foreign/po/pl.po
-rw-r--r-- ligges/users   5203 2012-10-11 18:41 foreign/po/R-de.po
-rw-r--r-- ligges/users  28708 2014-03-28 10:08 foreign/po/fr.po
-rw-r--r-- ligges/users  17250 2014-03-28 10:08 foreign/po/foreign.pot
-rw-r--r-- ligges/users   2853 2014-03-28 10:08 foreign/po/R-foreign.pot
-rw-r--r-- ligges/users  10262 2014-03-28 10:08 foreign/po/R-pl.po
--8<---------------cut here---------------end--------------->8---

In short, it’s safe to update the hash.

Ludo’.

Message #19 received at 27906-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Efraim Flashner <efraim <at> flashner.co.il>, 27906-done <at> debbugs.gnu.org
Subject: Re: [bug#27906] [PATCH] r-foreign: Update hash and remove duplicate
 recipe.
Date: Wed, 02 Aug 2017 00:49:24 +0200

Ludovic Courtès writes:

> Roel Janssen <roel <at> gnu.org> skribis:
>
>> Efraim Flashner writes:
>>
>>> I have /gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz
>>> if that would help
>>
>> Now this is odd:
>> $ wget http://cran.r-project.org/src/contrib/Archive/foreign/foreign_0.8-67.tar.gz
>
> The other one is at:
>
>   https://mirror.hydra.gnu.org/file/foreign_0.8-67.tar.gz/sha256/1mcrm2pydimbyjhkrw5h380bifj1jhwzifph1xgh90asf3lvd1xd
>
> The contents are identical per “diff -r --no-dereference”.  However
> metadata differs:
>
> --8<---------------cut here---------------start------------->8---
> ludo <at> ribbon /tmp$ tar tvf t.tgz |head
> drwxr-xr-x hornik/users      0 2016-09-13 13:04 foreign/
> drwxr-xr-x hornik/users      0 2014-03-28 10:08 foreign/po/
> -rw-r--r-- hornik/users   5913 2012-10-04 12:33 foreign/po/R-fr.po
> -rw-r--r-- hornik/users  27343 2014-03-28 10:08 foreign/po/de.po
> -rw-r--r-- hornik/users  49598 2014-03-28 10:08 foreign/po/pl.po
> -rw-r--r-- hornik/users   5203 2012-10-11 18:41 foreign/po/R-de.po
> -rw-r--r-- hornik/users  28708 2014-03-28 10:08 foreign/po/fr.po
> -rw-r--r-- hornik/users  17250 2014-03-28 10:08 foreign/po/foreign.pot
> -rw-r--r-- hornik/users   2853 2014-03-28 10:08 foreign/po/R-foreign.pot
> -rw-r--r-- hornik/users  10262 2014-03-28 10:08 foreign/po/R-pl.po
> ludo <at> ribbon /tmp$ tar tvf foreign_0.8-67.tar.gz |head
> drwxr-xr-x ligges/users      0 2016-09-13 13:04 foreign/
> drwxr-xr-x ligges/users      0 2014-03-28 10:08 foreign/po/
> -rw-r--r-- ligges/users   5913 2012-10-04 12:33 foreign/po/R-fr.po
> -rw-r--r-- ligges/users  27343 2014-03-28 10:08 foreign/po/de.po
> -rw-r--r-- ligges/users  49598 2014-03-28 10:08 foreign/po/pl.po
> -rw-r--r-- ligges/users   5203 2012-10-11 18:41 foreign/po/R-de.po
> -rw-r--r-- ligges/users  28708 2014-03-28 10:08 foreign/po/fr.po
> -rw-r--r-- ligges/users  17250 2014-03-28 10:08 foreign/po/foreign.pot
> -rw-r--r-- ligges/users   2853 2014-03-28 10:08 foreign/po/R-foreign.pot
> -rw-r--r-- ligges/users  10262 2014-03-28 10:08 foreign/po/R-pl.po
> --8<---------------cut here---------------end--------------->8---
>
> In short, it’s safe to update the hash.
>
> Ludo’.

Thanks for explaining the differences.  I pushed the hash change as a
separate commit from the removal of the duplicate recipe.

Kind regards,
Roel Janssen

Message #22 received at 27906 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Roel Janssen <roel <at> gnu.org>
Cc: 27906 <at> debbugs.gnu.org
Subject: Re: [bug#27906] [PATCH] r-foreign: Update hash and remove duplicate
 recipe.
Date: Tue, 01 Aug 2017 21:29:29 -0400

Hi,

Roel Janssen <roel <at> gnu.org> writes:

> Dear Guix,
>
> It seems we have two (almost identical) package recipes for r-foreign.
> This patch removes one of them.
>
> Also, the upstream tarball seems to have changed, so I updated the
> SHA256 hash.
>
> If someone has the old tarball, we could look at what exactly has
> changed.

Wouldn't the old tarball be available on one of our Hydra servers, as
can be gotten using "guix build -S"?

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.