GNU bug report logs - #27908
[PATCH] gnu: calibre: Add python2-msgpack as an native-input.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27908 in the body.
You can then email your comments to 27908 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: manolis837 <at> gmail.com
To: guix-patches <at> gnu.org
Cc: Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: [PATCH] gnu: calibre: Add python2-msgpack as an native-input.
Date: Tue,  1 Aug 2017 18:02:04 +0300

From: Manolis Ragkousis <manolis837 <at> gmail.com>

* gnu/packages/ebook.scm (calibre)[native-inputs]: Add python2-msgpack.
---
 gnu/packages/ebook.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
index bbb127a7d..4d893ec48 100644
--- a/gnu/packages/ebook.scm
+++ b/gnu/packages/ebook.scm
@@ -41,6 +41,7 @@
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages python)
   #:use-module (gnu packages qt)
+  #:use-module (gnu packages serialization)
   #:use-module (gnu packages tls)
   #:use-module (gnu packages web)
   #:use-module (gnu packages xorg))
@@ -100,7 +101,9 @@
        ;; also creates lots of messages
        ;; mkdir: cannot create directory '/homeless-shelter': Permission denied
        ("python2-flake8" ,python2-flake8)
-       ("xdg-utils" ,xdg-utils)))
+       ("xdg-utils" ,xdg-utils)
+       ;; python2-msgpack is needed for the network content server to work.
+       ("python2-msgpack" ,python2-msgpack)))
     ;; Beautifulsoup3 is bundled but obsolete and not packaged, so just leave it bundled.
     (inputs
      `(("chmlib" ,chmlib)
-- 
2.13.3

Message #10 received at 27908-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 27908-done <at> debbugs.gnu.org
Subject: re: [PATCH] gnu: calibre: Add python2-msgpack as an native-input.
Date: Tue, 1 Aug 2017 18:39:12 +0300

[Message part 1 (text/plain, inline)]

Looks good to me

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #15 received at 27908 <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: efraim <at> flashner.co.il
Cc: 27908 <at> debbugs.gnu.org
Subject: Re: bug#27908: [PATCH] gnu: calibre: Add python2-msgpack as an
 native-input.
Date: Wed, 2 Aug 2017 20:12:33 +0300

Hey Efraim

On 08/01/2017 06:39 PM, Efraim Flashner wrote:
> Looks good to me
> 

I looked at my patch again and I think that python2-msgpack should be an
input, not a native-input. It's needed at run-time. I will make the
appropriate changes and push to master.

Thank you,
Manolis

Message #20 received at 27908-done <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: 27908-done <at> debbugs.gnu.org
Subject: Re: [bug#27908] [PATCH] gnu: calibre: Add python2-msgpack as an
 native-input.
Date: Wed, 2 Aug 2017 20:31:16 +0300

Pushed to master.

On 08/02/2017 08:12 PM, Manolis Ragkousis wrote:
> Hey Efraim
> 
> On 08/01/2017 06:39 PM, Efraim Flashner wrote:
>> Looks good to me
>>
> 
> I looked at my patch again and I think that python2-msgpack should be an
> input, not a native-input. It's needed at run-time. I will make the
> appropriate changes and push to master.
> 
> Thank you,
> Manolis
> 
> 
> 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.